Hibernate
/
hibernate-orm
mirror of https://github.com/hibernate/hibernate-orm
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

HHH-16091 Optimize also AbstractStandardBasicType#compare and #fromString

This commit is contained in:
Sanne Grinovero 2023-01-24 17:45:51 +00:00 committed by Sanne Grinovero
parent 12c7252c59
commit 2d7774b9ab
1 changed files with 11 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
hibernate-core/src/main/java/org/hibernate/type/AbstractStandardBasicType.java
View File

@ -12,6 +12,7 @@ import java.sql.PreparedStatement;
import java.sql.SQLException; import java.sql.SQLException;
import java.sql.Types; import java.sql.Types;
import java.time.ZonedDateTime; import java.time.ZonedDateTime;
import java.util.Comparator;
import java.util.Map; import java.util.Map;
import org.hibernate.Hibernate; import org.hibernate.Hibernate;
@ -51,6 +52,7 @@ public abstract class AbstractStandardBasicType<T>
private final AbstractClassJavaType<T> javaTypeAsAbstractClassJavaType; private final AbstractClassJavaType<T> javaTypeAsAbstractClassJavaType;
private final Class javaTypeClass; private final Class javaTypeClass;
private final MutabilityPlan<T> mutabilityPlan; private final MutabilityPlan<T> mutabilityPlan;
private final Comparator<T> javatypeComparator;
public AbstractStandardBasicType(JdbcType jdbcType, JavaType<T> javaType) { public AbstractStandardBasicType(JdbcType jdbcType, JavaType<T> javaType) {
this.jdbcType = jdbcType; this.jdbcType = jdbcType;
@ -64,6 +66,7 @@ public abstract class AbstractStandardBasicType<T>
//A very simple dispatch optimisation, make these a constant: //A very simple dispatch optimisation, make these a constant:
this.javaTypeClass = javaType.getJavaTypeClass(); this.javaTypeClass = javaType.getJavaTypeClass();
this.mutabilityPlan = javaType.getMutabilityPlan(); this.mutabilityPlan = javaType.getMutabilityPlan();
this.javatypeComparator = javaType.getComparator();
//This is a dispatch optimisation to avoid megamorphic invocations on the most common type: //This is a dispatch optimisation to avoid megamorphic invocations on the most common type:
if ( javaType instanceof AbstractClassJavaType ) { if ( javaType instanceof AbstractClassJavaType ) {
this.javaTypeAsAbstractClassJavaType = (AbstractClassJavaType) javaType; this.javaTypeAsAbstractClassJavaType = (AbstractClassJavaType) javaType;
@ -94,7 +97,13 @@ public abstract class AbstractStandardBasicType<T>
} }
public T fromString(CharSequence string) { public T fromString(CharSequence string) {
return javaType.fromString( string ); final AbstractClassJavaType<T> type = this.javaTypeAsAbstractClassJavaType;
if ( type != null ) {
return type.fromString( string );
}
else {
return javaType.fromString( string );
}
} }
protected MutabilityPlan<T> getMutabilityPlan() { protected MutabilityPlan<T> getMutabilityPlan() {
@ -219,7 +228,7 @@ public abstract class AbstractStandardBasicType<T>
@Override @Override
@SuppressWarnings("unchecked") @SuppressWarnings("unchecked")
public final int compare(Object x, Object y) { public final int compare(Object x, Object y) {
return javaType.getComparator().compare( (T) x, (T) y ); return this.javatypeComparator.compare( (T) x, (T) y );
} }
@Override @Override