HHH-5275 - Criteria.setLockMode does not work correctly
This commit is contained in:
Steve Ebersole
parent
1e591f09ac
commit
2ddaeedd1e
|
|
@ -1,10 +1,10 @@
|
|||
/*
|
||||
* Hibernate, Relational Persistence for Idiomatic Java
|
||||
*
|
||||
* Copyright (c) 2008, Red Hat Middleware LLC or third-party contributors as
|
||||
* Copyright (c) 2008-2011, Red Hat Inc. or third-party contributors as
|
||||
* indicated by the @author tags or express copyright attribution
|
||||
* statements applied by the authors. All third-party contributions are
|
||||
* distributed under license by Red Hat Middleware LLC.
|
||||
* distributed under license by Red Hat Inc.
|
||||
*
|
||||
* This copyrighted material is made available to anyone wishing to use, modify,
|
||||
* copy, or redistribute it subject to the terms and conditions of the GNU
|
||||
|
|
@ -20,9 +20,9 @@
|
|||
* Free Software Foundation, Inc.
|
||||
* 51 Franklin Street, Fifth Floor
|
||||
* Boston, MA 02110-1301 USA
|
||||
*
|
||||
*/
|
||||
package org.hibernate.exception;
|
||||
|
||||
import java.sql.SQLException;
|
||||
|
||||
import org.hibernate.JDBCException;
|
||||
|
|
|
|||
|
|
@ -0,0 +1,67 @@
|
|||
/*
|
||||
* Hibernate, Relational Persistence for Idiomatic Java
|
||||
*
|
||||
* Copyright (c) 2011, Red Hat Inc. or third-party contributors as
|
||||
* indicated by the @author tags or express copyright attribution
|
||||
* statements applied by the authors. All third-party contributions are
|
||||
* distributed under license by Red Hat Inc.
|
||||
*
|
||||
* This copyrighted material is made available to anyone wishing to use, modify,
|
||||
* copy, or redistribute it subject to the terms and conditions of the GNU
|
||||
* Lesser General Public License, as published by the Free Software Foundation.
|
||||
*
|
||||
* This program is distributed in the hope that it will be useful,
|
||||
* but WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY
|
||||
* or FITNESS FOR A PARTICULAR PURPOSE. See the GNU Lesser General Public License
|
||||
* for more details.
|
||||
*
|
||||
* You should have received a copy of the GNU Lesser General Public License
|
||||
* along with this distribution; if not, write to:
|
||||
* Free Software Foundation, Inc.
|
||||
* 51 Franklin Street, Fifth Floor
|
||||
* Boston, MA 02110-1301 USA
|
||||
*/
|
||||
package org.hibernate.test.locking;
|
||||
|
||||
import javax.persistence.Entity;
|
||||
import javax.persistence.GeneratedValue;
|
||||
import javax.persistence.Id;
|
||||
import javax.persistence.Table;
|
||||
|
||||
import org.hibernate.annotations.GenericGenerator;
|
||||
|
||||
/**
|
||||
* @author Steve Ebersole
|
||||
*/
|
||||
@Entity
|
||||
@Table( name = "T_LOCK_A" )
|
||||
public class A {
|
||||
private Integer id;
|
||||
private String value;
|
||||
|
||||
public A() {
|
||||
}
|
||||
|
||||
public A(String value) {
|
||||
this.value = value;
|
||||
}
|
||||
|
||||
@Id
|
||||
@GeneratedValue( generator = "increment" )
|
||||
@GenericGenerator( name = "increment", strategy = "increment" )
|
||||
public Integer getId() {
|
||||
return id;
|
||||
}
|
||||
|
||||
public void setId(Integer id) {
|
||||
this.id = id;
|
||||
}
|
||||
|
||||
public String getValue() {
|
||||
return value;
|
||||
}
|
||||
|
||||
public void setValue(String value) {
|
||||
this.value = value;
|
||||
}
|
||||
}
|
||||
|
|
@ -0,0 +1,271 @@
|
|||
/*
|
||||
* Hibernate, Relational Persistence for Idiomatic Java
|
||||
*
|
||||
* Copyright (c) 2011, Red Hat Inc. or third-party contributors as
|
||||
* indicated by the @author tags or express copyright attribution
|
||||
* statements applied by the authors. All third-party contributions are
|
||||
* distributed under license by Red Hat Inc.
|
||||
*
|
||||
* This copyrighted material is made available to anyone wishing to use, modify,
|
||||
* copy, or redistribute it subject to the terms and conditions of the GNU
|
||||
* Lesser General Public License, as published by the Free Software Foundation.
|
||||
*
|
||||
* This program is distributed in the hope that it will be useful,
|
||||
* but WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY
|
||||
* or FITNESS FOR A PARTICULAR PURPOSE. See the GNU Lesser General Public License
|
||||
* for more details.
|
||||
*
|
||||
* You should have received a copy of the GNU Lesser General Public License
|
||||
* along with this distribution; if not, write to:
|
||||
* Free Software Foundation, Inc.
|
||||
* 51 Franklin Street, Fifth Floor
|
||||
* Boston, MA 02110-1301 USA
|
||||
*/
|
||||
package org.hibernate.test.locking;
|
||||
|
||||
import org.hibernate.LockMode;
|
||||
import org.hibernate.LockOptions;
|
||||
import org.hibernate.PessimisticLockException;
|
||||
import org.hibernate.Session;
|
||||
import org.hibernate.exception.GenericJDBCException;
|
||||
import org.hibernate.exception.LockAcquisitionException;
|
||||
|
||||
import org.junit.After;
|
||||
import org.junit.Before;
|
||||
import org.junit.Test;
|
||||
|
||||
import org.hibernate.testing.FailureExpected;
|
||||
import org.hibernate.testing.TestForIssue;
|
||||
import org.hibernate.testing.junit4.BaseCoreFunctionalTestCase;
|
||||
|
||||
import static org.junit.Assert.assertNotNull;
|
||||
import static org.junit.Assert.fail;
|
||||
|
||||
/**
|
||||
* Make sure that directly specifying lock modes, even though deprecated, continues to work until removed.
|
||||
*
|
||||
* @author Steve Ebersole
|
||||
*/
|
||||
@TestForIssue( jiraKey = "HHH-5275")
|
||||
public class LockModeTest extends BaseCoreFunctionalTestCase {
|
||||
@Override
|
||||
protected Class<?>[] getAnnotatedClasses() {
|
||||
return new Class[] { A.class };
|
||||
}
|
||||
|
||||
@Before
|
||||
public void createData() {
|
||||
Session session = sessionFactory().openSession();
|
||||
session.beginTransaction();
|
||||
session.save( new A( "it" ) );
|
||||
session.getTransaction().commit();
|
||||
session.close();
|
||||
}
|
||||
|
||||
@After
|
||||
public void cleanupData() {
|
||||
Session session = sessionFactory().openSession();
|
||||
session.beginTransaction();
|
||||
session.createQuery( "delete A" ).executeUpdate();
|
||||
session.getTransaction().commit();
|
||||
session.close();
|
||||
}
|
||||
|
||||
@Test
|
||||
@SuppressWarnings( {"deprecation"})
|
||||
public void testLoading() {
|
||||
// open a session, begin a transaction and lock row
|
||||
Session s1 = sessionFactory().openSession();
|
||||
s1.beginTransaction();
|
||||
try {
|
||||
A it = (A) s1.get( A.class, 1, LockMode.PESSIMISTIC_WRITE );
|
||||
// make sure we got it
|
||||
assertNotNull( it );
|
||||
|
||||
// that initial transaction is still active and so the lock should still be held.
|
||||
// Lets open another session/transaction and verify
|
||||
Session s2 = sessionFactory().openSession();
|
||||
s2.beginTransaction();
|
||||
try {
|
||||
s2.get( A.class, 1, LockMode.PESSIMISTIC_WRITE );
|
||||
fail( "Pessimistic lock was not obtained/held" );
|
||||
}
|
||||
catch ( Exception e ) {
|
||||
// grr, exception can be any number of types based on database
|
||||
// see HHH-6887
|
||||
if ( LockAcquisitionException.class.isInstance( e )
|
||||
|| GenericJDBCException.class.isInstance( e )
|
||||
|| PessimisticLockException.class.isInstance( e ) ) {
|
||||
// "ok"
|
||||
}
|
||||
else {
|
||||
fail( "Unexpected error type testing pessimistic locking : " + e.getClass().getName() );
|
||||
}
|
||||
}
|
||||
finally {
|
||||
s2.getTransaction().commit();
|
||||
s2.close();
|
||||
}
|
||||
}
|
||||
finally {
|
||||
s1.getTransaction().commit();
|
||||
s1.close();
|
||||
}
|
||||
}
|
||||
|
||||
@Test
|
||||
@FailureExpected( jiraKey = "HHH-5275" )
|
||||
public void testLegacyCriteria() {
|
||||
// open a session, begin a transaction and lock row
|
||||
Session s1 = sessionFactory().openSession();
|
||||
s1.beginTransaction();
|
||||
try {
|
||||
A it = (A) s1.createCriteria( A.class )
|
||||
.setLockMode( LockMode.PESSIMISTIC_WRITE )
|
||||
.uniqueResult();
|
||||
// make sure we got it
|
||||
assertNotNull( it );
|
||||
|
||||
// that initial transaction is still active and so the lock should still be held.
|
||||
// Lets open another session/transaction and verify
|
||||
Session s2 = sessionFactory().openSession();
|
||||
s2.beginTransaction();
|
||||
try {
|
||||
s2.createCriteria( A.class )
|
||||
.setLockMode( LockMode.PESSIMISTIC_WRITE )
|
||||
.uniqueResult();
|
||||
|
||||
fail( "Pessimistic lock was not obtained/held" );
|
||||
}
|
||||
catch ( Exception e ) {
|
||||
// grr, exception can be any number of types based on database
|
||||
// see HHH-6887
|
||||
if ( LockAcquisitionException.class.isInstance( e )
|
||||
|| GenericJDBCException.class.isInstance( e )
|
||||
|| PessimisticLockException.class.isInstance( e ) ) {
|
||||
// "ok"
|
||||
}
|
||||
else {
|
||||
fail( "Unexpected error type testing pessimistic locking : " + e.getClass().getName() );
|
||||
}
|
||||
}
|
||||
finally {
|
||||
s2.getTransaction().commit();
|
||||
s2.close();
|
||||
}
|
||||
}
|
||||
finally {
|
||||
s1.getTransaction().commit();
|
||||
s1.close();
|
||||
}
|
||||
}
|
||||
|
||||
@Test
|
||||
@FailureExpected( jiraKey = "HHH-5275" )
|
||||
public void testLegacyCriteriaAliasSpecific() {
|
||||
// open a session, begin a transaction and lock row
|
||||
Session s1 = sessionFactory().openSession();
|
||||
s1.beginTransaction();
|
||||
try {
|
||||
A it = (A) s1.createCriteria( A.class )
|
||||
.setLockMode( "this", LockMode.PESSIMISTIC_WRITE )
|
||||
.uniqueResult();
|
||||
// make sure we got it
|
||||
assertNotNull( it );
|
||||
|
||||
// that initial transaction is still active and so the lock should still be held.
|
||||
// Lets open another session/transaction and verify
|
||||
Session s2 = sessionFactory().openSession();
|
||||
s2.beginTransaction();
|
||||
try {
|
||||
s2.createCriteria( A.class )
|
||||
.setLockMode( "this", LockMode.PESSIMISTIC_WRITE )
|
||||
.uniqueResult();
|
||||
|
||||
fail( "Pessimistic lock was not obtained/held" );
|
||||
}
|
||||
catch ( Exception e ) {
|
||||
// grr, exception can be any number of types based on database
|
||||
// see HHH-6887
|
||||
if ( LockAcquisitionException.class.isInstance( e )
|
||||
|| GenericJDBCException.class.isInstance( e )
|
||||
|| PessimisticLockException.class.isInstance( e ) ) {
|
||||
// "ok"
|
||||
}
|
||||
else {
|
||||
fail( "Unexpected error type testing pessimistic locking : " + e.getClass().getName() );
|
||||
}
|
||||
}
|
||||
finally {
|
||||
s2.getTransaction().commit();
|
||||
s2.close();
|
||||
}
|
||||
}
|
||||
finally {
|
||||
s1.getTransaction().commit();
|
||||
s1.close();
|
||||
}
|
||||
}
|
||||
|
||||
@Test
|
||||
@FailureExpected( jiraKey = "HHH-5275" )
|
||||
public void testQuery() {
|
||||
// open a session, begin a transaction and lock row
|
||||
Session s1 = sessionFactory().openSession();
|
||||
s1.beginTransaction();
|
||||
try {
|
||||
A it = (A) s1.createQuery( "from A a" )
|
||||
.setLockMode( "a", LockMode.PESSIMISTIC_WRITE )
|
||||
.uniqueResult();
|
||||
// make sure we got it
|
||||
assertNotNull( it );
|
||||
|
||||
// that initial transaction is still active and so the lock should still be held.
|
||||
// Lets open another session/transaction and verify
|
||||
Session s2 = sessionFactory().openSession();
|
||||
s2.beginTransaction();
|
||||
try {
|
||||
s2.createQuery( "from A a" )
|
||||
.setLockMode( "a", LockMode.PESSIMISTIC_WRITE )
|
||||
.uniqueResult();
|
||||
|
||||
fail( "Pessimistic lock was not obtained/held" );
|
||||
}
|
||||
catch ( Exception e ) {
|
||||
// grr, exception can be any number of types based on database
|
||||
// see HHH-6887
|
||||
if ( LockAcquisitionException.class.isInstance( e )
|
||||
|| GenericJDBCException.class.isInstance( e )
|
||||
|| PessimisticLockException.class.isInstance( e ) ) {
|
||||
// "ok"
|
||||
}
|
||||
else {
|
||||
fail( "Unexpected error type testing pessimistic locking : " + e.getClass().getName() );
|
||||
}
|
||||
}
|
||||
finally {
|
||||
s2.getTransaction().commit();
|
||||
s2.close();
|
||||
}
|
||||
}
|
||||
finally {
|
||||
s1.getTransaction().commit();
|
||||
s1.close();
|
||||
}
|
||||
}
|
||||
|
||||
@Test
|
||||
public void testQueryUsingLockOptions() {
|
||||
// todo : need an association here to make sure the alias-specific lock modes are applied correctly
|
||||
Session s1 = sessionFactory().openSession();
|
||||
s1.beginTransaction();
|
||||
s1.createQuery( "from A a" )
|
||||
.setLockOptions( new LockOptions( LockMode.PESSIMISTIC_WRITE ) )
|
||||
.uniqueResult();
|
||||
s1.createQuery( "from A a" )
|
||||
.setLockOptions( new LockOptions().setAliasSpecificLockMode( "a", LockMode.PESSIMISTIC_WRITE ) )
|
||||
.uniqueResult();
|
||||
s1.getTransaction().commit();
|
||||
s1.close();
|
||||
}
|
||||
}
|
||||
Loading…
Reference in New Issue