From 34b479a719b9d97dc2f966cea36da7ec947ad7c4 Mon Sep 17 00:00:00 2001
From: Andrea Boriero <andrea@hibernate.org>
Date: Wed, 18 Sep 2024 17:35:01 +0200
Subject: [PATCH] HHH-18631 AssertionError when loading an entity after
 removing another, associated entity

---
 .../entity/internal/EntityInitializerImpl.java   | 16 +++++++++-------
 1 file changed, 9 insertions(+), 7 deletions(-)

diff --git a/hibernate-core/src/main/java/org/hibernate/sql/results/graph/entity/internal/EntityInitializerImpl.java b/hibernate-core/src/main/java/org/hibernate/sql/results/graph/entity/internal/EntityInitializerImpl.java
index d9610b4f03..2b8a643245 100644
--- a/hibernate-core/src/main/java/org/hibernate/sql/results/graph/entity/internal/EntityInitializerImpl.java
+++ b/hibernate-core/src/main/java/org/hibernate/sql/results/graph/entity/internal/EntityInitializerImpl.java
@@ -85,7 +85,6 @@ import static org.hibernate.bytecode.enhance.spi.LazyPropertyInitializer.UNFETCH
 import static org.hibernate.engine.internal.ManagedTypeHelper.asPersistentAttributeInterceptable;
 import static org.hibernate.engine.internal.ManagedTypeHelper.isPersistentAttributeInterceptable;
 import static org.hibernate.internal.util.NullnessUtil.castNonNull;
-import static org.hibernate.metamodel.mapping.ForeignKeyDescriptor.Nature.TARGET;
 import static org.hibernate.proxy.HibernateProxy.extractLazyInitializer;
 
 /**
@@ -931,12 +930,15 @@ public class EntityInitializerImpl extends AbstractInitializer<EntityInitializer
 			);
 			data.entityHolder = persistenceContext.getEntityHolder( data.entityKey );
 			if ( data.entityHolder == null ) {
-				// Entity was most probably removed in the same session without setting the reference to null
-				resolveKey( data );
-				assert data.getState() == State.MISSING;
-				assert referencedModelPart instanceof ToOneAttributeMapping
-					&& ( (ToOneAttributeMapping) referencedModelPart ).getSideNature() == TARGET;
-				return;
+				// Entity was most probably removed in the same session without setting this association to null.
+				// Since this load request can happen through `find()` which doesn't auto-flush on association joins,
+				// the entity must be fully initialized, even if it is removed already
+				data.entityHolder = persistenceContext.claimEntityHolderIfPossible(
+						data.entityKey,
+						data.entityInstanceForNotify,
+						rowProcessingState.getJdbcValuesSourceProcessingState(),
+						this
+				);
 			}
 			if ( data.concreteDescriptor.getBytecodeEnhancementMetadata().isEnhancedForLazyLoading()
 					&& isPersistentAttributeInterceptable( data.entityInstanceForNotify )