Hibernate/hibernate-orm
1
0
Fork 0
mirror of https://github.com/hibernate/hibernate-orm synced 2025-02-17 00:24:57 +00:00
Code Issues Packages Projects Releases Wiki Activity

HHH-5929 PooledLoOptimizer is not thread-safe

Browse Source 
All Optimizers in OptimizerFactory are thread safe by having the
 #generate(AccessCallback) method synchronized. The only exception is
PooledLoOptimizer who's #generate(AccessCallback) method is not
synchronized.

 - make PooledLoOptimizer#generate(AccessCallback) synchronized

 https://hibernate.onjira.com/browse/HHH-5929
 https://hibernate.onjira.com/browse/HHH-6829
This commit is contained in:
Philippe Marschall 2012-06-09 19:38:30 +02:00 committed by Strong Liu
parent a86997c7ba
commit 3e4786220c
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
hibernate-core/src/main/java/org/hibernate/id/enhanced/OptimizerFactory.java
View File

@ -514,7 +514,7 @@ public PooledLoOptimizer(Class returnClass, int incrementSize) {
}
@Override
public Serializable generate(AccessCallback callback) {
public synchronized Serializable generate(AccessCallback callback) {
if ( lastSourceValue == null || ! value.lt( lastSourceValue.copy().add( incrementSize ) ) ) {
lastSourceValue = callback.getNextValue();
value = lastSourceValue.copy();