Hibernate
/
hibernate-orm
mirror of https://github.com/hibernate/hibernate-orm
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Use try-with-resources to close reader / writer

This commit is contained in:
Zhihong Yu 2023-06-30 14:56:03 -07:00 committed by Christian Beikov
parent de09122ba4
commit 402a89eb03
2 changed files with 11 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
hibernate-core/src/main/java/org/hibernate/tool/schema/internal/script/SingleLineSqlScriptExtractor.java
View File

@ -32,8 +32,7 @@ public class SingleLineSqlScriptExtractor implements SqlScriptCommandExtractor {
public List<String> extractCommands(Reader reader, Dialect dialect) { public List<String> extractCommands(Reader reader, Dialect dialect) {
final List<String> statementList = new LinkedList<>(); final List<String> statementList = new LinkedList<>();
final BufferedReader bufferedReader = new BufferedReader( reader ); try (final BufferedReader bufferedReader = new BufferedReader( reader )) {
try {
for ( String line = bufferedReader.readLine(); line != null; line = bufferedReader.readLine() ) { for ( String line = bufferedReader.readLine(); line != null; line = bufferedReader.readLine() ) {
final String trimmedLine = line.trim(); final String trimmedLine = line.trim();

15
local-build-plugins/src/main/java/org/hibernate/orm/antlr/AntlrHelper.java
View File

@ -51,23 +51,20 @@ public class AntlrHelper {
tmpFile.getParentFile().mkdirs(); tmpFile.getParentFile().mkdirs();
tmpFile.createNewFile(); tmpFile.createNewFile();
final BufferedReader reader = new BufferedReader( new FileReader( generatedJavaFile ) ); try (final BufferedReader reader = new BufferedReader( new FileReader( generatedJavaFile ) );
final BufferedWriter writer = new BufferedWriter( new FileWriter( tmpFile ) ); final BufferedWriter writer = new BufferedWriter( new FileWriter( tmpFile ) )) {
boolean found = false; boolean found = false;
String currentLine; String currentLine;
while ( ( currentLine = reader.readLine() ) != null ) { while ((currentLine = reader.readLine()) != null) {
if ( ! found && currentLine.startsWith( "// Generated from" ) ) { if (!found && currentLine.startsWith("// Generated from")) {
found = true; found = true;
continue; continue;
} }
writer.write( currentLine + System.lineSeparator() ); writer.write(currentLine + System.lineSeparator());
}
} }
writer.close();
reader.close();
generatedJavaFile.delete(); generatedJavaFile.delete();
tmpFile.renameTo( generatedJavaFile ); tmpFile.renameTo( generatedJavaFile );
} }