Hibernate
/
hibernate-orm
mirror of https://github.com/hibernate/hibernate-orm
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Replace StringBuffer with StringBuilder 

avoid unnecessary synchronization
This commit is contained in:
Yanming Zhou 2020-09-03 15:35:50 +08:00 committed by Christian Beikov
parent 7f6ead80cc
commit 4499abd9a9
18 changed files with 21 additions and 26 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
hibernate-core/src/main/java/org/hibernate/cfg/DefaultComponentSafeNamingStrategy.java
View File

@ -61,8 +61,7 @@ public class DefaultComponentSafeNamingStrategy extends EJB3NamingStrategy {
return tableName;
}
else {
//use of a stringbuffer to workaround a JDK bug
return new StringBuffer( ownerEntityTable ).append( "_" )
return new StringBuilder( ownerEntityTable ).append( "_" )
.append(
associatedEntityTable != null ?
associatedEntityTable :

3
hibernate-core/src/main/java/org/hibernate/cfg/DefaultNamingStrategy.java
View File

@ -96,8 +96,7 @@ public class DefaultNamingStrategy implements NamingStrategy, Serializable {
return tableName;
}
else {
//use of a stringbuffer to workaround a JDK bug
return new StringBuffer(ownerEntityTable).append("_")
return new StringBuilder(ownerEntityTable).append("_")
.append(
associatedEntityTable != null ?
associatedEntityTable :

3
hibernate-core/src/main/java/org/hibernate/cfg/EJB3NamingStrategy.java
View File

@ -72,8 +72,7 @@ public class EJB3NamingStrategy implements NamingStrategy, Serializable {
return tableName;
}
else {
//use of a stringbuffer to workaround a JDK bug
return new StringBuffer( ownerEntityTable ).append( "_" )
return new StringBuilder( ownerEntityTable ).append( "_" )
.append(
associatedEntityTable != null ?
associatedEntityTable :

3
hibernate-core/src/main/java/org/hibernate/cfg/ImprovedNamingStrategy.java
View File

@ -110,8 +110,7 @@ public class ImprovedNamingStrategy implements NamingStrategy, Serializable {
return tableName;
}
else {
//use of a stringbuffer to workaround a JDK bug
return new StringBuffer(ownerEntityTable).append("_")
return new StringBuilder(ownerEntityTable).append("_")
.append(
associatedEntityTable != null ?
associatedEntityTable :

2
hibernate-core/src/main/java/org/hibernate/hql/internal/classic/QueryTranslatorImpl.java
View File

@ -771,7 +771,7 @@ public class QueryTranslatorImpl extends BasicLoader implements FilterTranslator
}
/*private String renderOrderByPropertiesSelect() {
StringBuffer buf = new StringBuffer(10);
StringBuilder buf = new StringBuilder(10);
//add the columns we are ordering by to the select ID select clause
Iterator iter = orderByTokens.iterator();

2
hibernate-core/src/test/java/org/hibernate/jpa/test/criteria/idclass/WidgetId.java
View File

@ -49,7 +49,7 @@ public class WidgetId implements Serializable {
@Override
public String toString( ) {
StringBuffer buf = new StringBuffer( "[id:" );
StringBuilder buf = new StringBuilder( "[id:" );
buf.append( ( this.getCode( ) == null ) ? "null" : this.getCode( ).toString( ) );
buf.append( ";code:" );
buf.append( ( this.getDivision( ) == null ) ? "null" : this.getDivision( ) );

2
hibernate-core/src/test/java/org/hibernate/jpa/test/pack/defaultpar/Version.java
View File

@ -44,6 +44,6 @@ public class Version {
}
public String toString() {
return new StringBuffer( major ).append( DOT ).append( minor ).append( DOT ).append( micro ).toString();
return new StringBuilder( major ).append( DOT ).append( minor ).append( DOT ).append( micro ).toString();
}
}

2
hibernate-core/src/test/java/org/hibernate/jpa/test/pack/defaultpar_1_0/Version1.java
View File

@ -44,6 +44,6 @@ public class Version1 {
}
public String toString() {
return new StringBuffer( major ).append( DOT ).append( minor ).append( DOT ).append( micro ).toString();
return new StringBuilder( major ).append( DOT ).append( minor ).append( DOT ).append( micro ).toString();
}
}

2
hibernate-core/src/test/java/org/hibernate/jpa/test/pack/war/Version.java
View File

@ -44,6 +44,6 @@ public class Version {
}
public String toString() {
return new StringBuffer( major ).append( DOT ).append( minor ).append( DOT ).append( micro ).toString();
return new StringBuilder( major ).append( DOT ).append( minor ).append( DOT ).append( micro ).toString();
}
}

3
hibernate-core/src/test/java/org/hibernate/test/annotations/AlternativeNamingStrategy.java
View File

@ -63,8 +63,7 @@ public class AlternativeNamingStrategy extends EJB3NamingStrategy {
return tableName;
}
else {
//use of a stringbuffer to workaround a JDK bug
return new StringBuffer( ownerEntityTable ).append( "_" )
return new StringBuilder( ownerEntityTable ).append( "_" )
.append(
associatedEntityTable != null ?
associatedEntityTable :

2
hibernate-spatial/src/main/java/org/hibernate/spatial/dialect/oracle/GetDimensionFunction.java
View File

@ -23,7 +23,7 @@ class GetDimensionFunction extends SDOObjectMethod {
}
public String render(Type firstArgumentType, final List args, final SessionFactoryImplementor factory) {
final StringBuffer buf = new StringBuffer();
final StringBuilder buf = new StringBuilder();
if ( args.isEmpty() ) {
throw new IllegalArgumentException(
"First Argument in arglist must be object to "

2
hibernate-spatial/src/main/java/org/hibernate/spatial/dialect/oracle/GetGeometryTypeFunction.java
View File

@ -23,7 +23,7 @@ class GetGeometryTypeFunction extends SDOObjectMethod {
}
public String render(Type firstArgumentType, final List args, final SessionFactoryImplementor factory) {
final StringBuffer buf = new StringBuffer();
final StringBuilder buf = new StringBuilder();
if ( args.isEmpty() ) {
throw new IllegalArgumentException(
"First Argument in arglist must be object to which"

6
hibernate-spatial/src/main/java/org/hibernate/spatial/dialect/oracle/OracleSDOSupport.java
View File

@ -106,7 +106,7 @@ class OracleSDOSupport implements SpatialDialect, Serializable, WithCustomJPAFil
}
public String getOGCSpatialRelateSQL(String arg1, String arg2, int spatialRelation) {
final StringBuffer ogcFunction = new StringBuffer( "MDSYS." );
final StringBuilder ogcFunction = new StringBuilder( "MDSYS." );
switch ( spatialRelation ) {
case SpatialRelation.INTERSECTS:
ogcFunction.append( "OGC_INTERSECTS" );
@ -229,7 +229,7 @@ class OracleSDOSupport implements SpatialDialect, Serializable, WithCustomJPAFil
*/
@Override
public String getSpatialFilterExpression(String columnName) {
final StringBuffer buffer = new StringBuffer( "SDO_FILTER(" );
final StringBuilder buffer = new StringBuilder( "SDO_FILTER(" );
buffer.append( columnName );
buffer.append( ",?) = 'TRUE' " );
return buffer.toString();
@ -245,7 +245,7 @@ class OracleSDOSupport implements SpatialDialect, Serializable, WithCustomJPAFil
*/
@Override
public String getSpatialAggregateSQL(String columnName, int aggregation) {
final StringBuffer aggregateFunction = new StringBuffer();
final StringBuilder aggregateFunction = new StringBuilder();
final SpatialAggregate sa = new SpatialAggregate( aggregation );
if ( sa.getAggregateSyntax() == null ) {

4
hibernate-spatial/src/main/java/org/hibernate/spatial/dialect/oracle/OracleSpatialFunctions.java
View File

@ -175,7 +175,7 @@ class OracleSpatialFunctions extends SpatialFunctionsRegistry {
static String getOGCSpatialAnalysisSQL(List args, int spatialAnalysisFunction) {
boolean[] geomArgs;
final StringBuffer ogcFunction = new StringBuffer( "MDSYS." );
final StringBuilder ogcFunction = new StringBuilder( "MDSYS." );
boolean isGeomReturn = true;
switch ( spatialAnalysisFunction ) {
case SpatialAnalysis.BUFFER:
@ -240,7 +240,7 @@ class OracleSpatialFunctions extends SpatialFunctionsRegistry {
return ogcFunction.toString();
}
private static StringBuffer wrapInSTGeometry(String geomColumn, StringBuffer toAdd) {
private static StringBuilder wrapInSTGeometry(String geomColumn, StringBuilder toAdd) {
return toAdd.append( "MDSYS.ST_GEOMETRY(" ).append( geomColumn )
.append( ")" );
}

2
hibernate-spatial/src/main/java/org/hibernate/spatial/dialect/oracle/SDOObjectMethod.java
View File

@ -67,7 +67,7 @@ class SDOObjectMethod implements SQLFunction {
*/
public String render(Type firstArgumentType, List args, SessionFactoryImplementor factory) throws QueryException {
final StringBuffer buf = new StringBuffer();
final StringBuilder buf = new StringBuilder();
if ( args.isEmpty() ) {
throw new QueryException(
"First Argument in arglist must be object to which method is applied"

2
hibernate-spatial/src/main/java/org/hibernate/spatial/dialect/oracle/SDOObjectProperty.java
View File

@ -68,7 +68,7 @@ class SDOObjectProperty implements SQLFunction {
public String render(Type firstArgtype, List args, SessionFactoryImplementor factory)
throws QueryException {
final StringBuffer buf = new StringBuffer();
final StringBuilder buf = new StringBuilder();
if ( args.isEmpty() ) {
throw new QueryException(
"First Argument in arglist must be object of which property is queried"

2
hibernate-spatial/src/main/java/org/hibernate/spatial/dialect/oracle/criterion/OracleSpatialProjection.java
View File

@ -49,7 +49,7 @@ public class OracleSpatialProjection extends SimpleProjection {
if ( dialect instanceof SpatialDialect ) {
final SpatialDialect seDialect = (SpatialDialect) dialect;
return new StringBuffer(
return new StringBuilder(
seDialect.getSpatialAggregateSQL(
columns[0], this.aggregate
)

2
hibernate-spatial/src/main/java/org/hibernate/spatial/dialect/sqlserver/SqlServerMethod.java
View File

@ -24,7 +24,7 @@ class SqlServerMethod extends StandardSQLFunction {
@Override
public String render(Type firstArgumentType, List arguments, SessionFactoryImplementor sessionFactory) {
final StringBuffer buf = new StringBuffer();
final StringBuilder buf = new StringBuilder();
if ( arguments.size() < 1 ) {
buf.append( getName() ).append( "()" );
}