From 461383c8d1b7b869ad4a6da1a4836767ec57f3c4 Mon Sep 17 00:00:00 2001
From: Marco Belladelli <mbellade@redhat.com>
Date: Mon, 2 Jan 2023 12:10:47 +0100
Subject: [PATCH] HHH-15866 Add test for issue

---
 .../OneToManyEmbeddedIdFKNotNullableTest.java | 173 ++++++++++++++++++
 1 file changed, 173 insertions(+)
 create mode 100644 hibernate-core/src/test/java/org/hibernate/orm/test/compositefk/OneToManyEmbeddedIdFKNotNullableTest.java

diff --git a/hibernate-core/src/test/java/org/hibernate/orm/test/compositefk/OneToManyEmbeddedIdFKNotNullableTest.java b/hibernate-core/src/test/java/org/hibernate/orm/test/compositefk/OneToManyEmbeddedIdFKNotNullableTest.java
new file mode 100644
index 0000000000..57404c786e
--- /dev/null
+++ b/hibernate-core/src/test/java/org/hibernate/orm/test/compositefk/OneToManyEmbeddedIdFKNotNullableTest.java
@@ -0,0 +1,173 @@
+/*
+ * Hibernate, Relational Persistence for Idiomatic Java
+ *
+ * License: GNU Lesser General Public License (LGPL), version 2.1 or later
+ * See the lgpl.txt file in the root directory or http://www.gnu.org/licenses/lgpl-2.1.html
+ */
+package org.hibernate.orm.test.compositefk;
+
+import java.io.Serializable;
+import java.util.Collections;
+import java.util.List;
+
+import org.hibernate.Session;
+import org.hibernate.exception.ConstraintViolationException;
+
+import org.hibernate.testing.orm.junit.DomainModel;
+import org.hibernate.testing.orm.junit.JiraKey;
+import org.hibernate.testing.orm.junit.SessionFactory;
+import org.hibernate.testing.orm.junit.SessionFactoryScope;
+
+import org.junit.Assert;
+import org.junit.jupiter.api.AfterAll;
+import org.junit.jupiter.api.Test;
+
+import jakarta.persistence.CascadeType;
+import jakarta.persistence.Embeddable;
+import jakarta.persistence.EmbeddedId;
+import jakarta.persistence.Entity;
+import jakarta.persistence.GeneratedValue;
+import jakarta.persistence.GenerationType;
+import jakarta.persistence.Id;
+import jakarta.persistence.JoinColumn;
+import jakarta.persistence.JoinColumns;
+import jakarta.persistence.OneToMany;
+import jakarta.persistence.PersistenceException;
+import jakarta.persistence.Table;
+
+import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertTrue;
+import static org.junit.jupiter.api.Assertions.fail;
+
+/**
+ * @author Marco Belladelli
+ */
+@DomainModel(annotatedClasses = {
+		OneToManyEmbeddedIdFKNotNullableTest.ChildEntity.class,
+		OneToManyEmbeddedIdFKNotNullableTest.ParentEntity.class
+})
+@SessionFactory
+@JiraKey("HHH-15866")
+public class OneToManyEmbeddedIdFKNotNullableTest {
+	@AfterAll
+	public void tearDown(SessionFactoryScope scope) {
+		scope.inTransaction( session -> {
+			session.createMutationQuery( "delete from ChildEntity" ).executeUpdate();
+			session.createMutationQuery( "delete from ParentEntity" ).executeUpdate();
+		} );
+	}
+
+	@Test
+	public void testEmbeddedIdNotNullable(SessionFactoryScope scope) {
+		scope.inTransaction( session -> {
+			ChildEntity c1 = new ChildEntity();
+			ChildEntity c2 = new ChildEntity();
+			ParentEntity parentEntity = new ParentEntity(
+					new ParentEntityId( 1, "1" ),
+					List.of( c1, c2 )
+			);
+			session.persist( parentEntity );
+			assertEquals( 2, parentEntity.getChildEntities().size() );
+		} );
+	}
+
+	@Test
+	public void testNullFKShouldThrowException(SessionFactoryScope scope) {
+		try {
+			scope.inTransaction( session -> {
+				ChildEntity childEntity = new ChildEntity();
+				session.persist( childEntity );
+			} );
+			fail( "Inserting child entity without FK should not be allowed." );
+		}
+		catch (PersistenceException e) {
+			assertEquals( ConstraintViolationException.class, e.getClass() );
+		}
+	}
+
+	@Entity(name = "ChildEntity")
+	@Table(name = "child_entity")
+	public static class ChildEntity {
+		@Id
+		@GeneratedValue
+		private int id;
+
+		public int getId() {
+			return id;
+		}
+
+		public void setId(int id) {
+			this.id = id;
+		}
+	}
+
+	@Embeddable
+	public static class ParentEntityId implements Serializable {
+		private int id;
+
+		private String name;
+
+		public ParentEntityId() {
+		}
+
+		public ParentEntityId(int id, String name) {
+			this.id = id;
+			this.name = name;
+		}
+
+		public int getId() {
+			return id;
+		}
+
+		public void setId(int id) {
+			this.id = id;
+		}
+
+		public String getName() {
+			return name;
+		}
+
+		public void setName(String name) {
+			this.name = name;
+		}
+	}
+
+
+	@Entity(name = "ParentEntity")
+	@Table(name = "parent_entity")
+	public static class ParentEntity {
+		@OneToMany(cascade = CascadeType.ALL)
+		@JoinColumns({
+				@JoinColumn(name = "parent_entity_id", referencedColumnName = "id", nullable = false),
+				@JoinColumn(name = "parent_entity_name", referencedColumnName = "name", nullable = false)
+		})
+		private List<ChildEntity> childEntities;
+
+		public ParentEntity() {
+		}
+
+		@EmbeddedId
+		private ParentEntityId id;
+
+		public ParentEntity(ParentEntityId id, List<ChildEntity> childEntities) {
+			this.id = id;
+			this.childEntities = childEntities;
+		}
+
+		public ParentEntityId getId() {
+			return id;
+		}
+
+		public void setId(ParentEntityId id) {
+			this.id = id;
+		}
+
+		public List<ChildEntity> getChildEntities() {
+			return childEntities;
+		}
+
+		public void setChildEntities(List<ChildEntity> childEntities) {
+			this.childEntities = childEntities;
+		}
+	}
+}