Hibernate
/
hibernate-orm
mirror of https://github.com/hibernate/hibernate-orm
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

use switch expression in ColumnDefinitions 

Signed-off-by: Gavin King <gavin@hibernate.org>
This commit is contained in:
Gavin King 2024-11-11 10:15:30 +01:00
parent ba77bd2e04
commit 4bd5223e6c
1 changed files with 15 additions and 24 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

39
hibernate-core/src/main/java/org/hibernate/tool/schema/internal/ColumnDefinitions.java
View File

@ -57,7 +57,7 @@ class ColumnDefinitions {
return true;
}
else {
int sqlType = columnInformation.getTypeCode();
final int sqlType = columnInformation.getTypeCode();
if ( isStringType( sqlType ) ) {
final int actualLength = columnInformation.getColumnSize();
final Size size = column.getColumnSize( dialect, metadata );
@ -91,14 +91,14 @@ class ColumnDefinitions {
Metadata metadata,
Dialect dialect,
SqlStringGenerationContext context) {
StringBuilder definition = new StringBuilder();
final StringBuilder definition = new StringBuilder();
appendColumn( definition, column, table, metadata, dialect, context );
return definition.toString();
}
static String getColumnDefinition(Column column, Metadata metadata, Dialect dialect) {
StringBuilder definition = new StringBuilder();
final StringBuilder definition = new StringBuilder();
appendColumnDefinition( definition, column, metadata, dialect );
appendComment( definition, column, dialect );
return definition.toString();
@ -235,28 +235,19 @@ class ColumnDefinitions {
}
else {
final String lowercaseTypeName = typeName.toLowerCase(Locale.ROOT);
switch (lowercaseTypeName) {
case "int":
return "integer";
case "character":
return "char";
case "character varying":
return "varchar";
case "binary varying":
return "varbinary";
case "character large object":
return "clob";
case "binary large object":
return "blob";
case "interval second":
return "interval";
case "double precision":
return "double";
return switch ( lowercaseTypeName ) {
case "int" -> "integer";
case "character" -> "char";
case "character varying" -> "varchar";
case "binary varying" -> "varbinary";
case "character large object" -> "clob";
case "binary large object" -> "blob";
case "interval second" -> "interval";
case "double precision" -> "double";
// todo: normalize DECIMAL to NUMERIC?
// normalize REAL to FLOAT?
default:
return lowercaseTypeName;
}
default -> lowercaseTypeName;
};
}
}
@ -265,7 +256,7 @@ class ColumnDefinitions {
return null;
}
else {
int i = typeExpression.indexOf('(');
final int i = typeExpression.indexOf('(');
return i>0 ? typeExpression.substring(0,i).trim() : typeExpression;
}
}