Hibernate
/
hibernate-orm
mirror of https://github.com/hibernate/hibernate-orm
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

HHH-10803 - Fix test to assert based on exception typing.

This commit is contained in:
Chris Cranford 2016-06-06 09:21:10 -05:00
parent 131127a498
commit 5318cef733
1 changed files with 13 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

27
hibernate-core/src/test/java/org/hibernate/jpa/test/query/QueryTest.java
View File

@ -1061,18 +1061,18 @@ public class QueryTest extends BaseEntityManagerFunctionalTestCase {
jpaQuery.setParameter( 2, "Expensive" );
fail( "Should fail due to a user error in parameters" );
}
catch (IllegalArgumentException e) {
// success, expected
catch (Exception e) {
assertTyping( IllegalArgumentException.class, e );
}
// using jpa-style, position index specified not in query - test exception type
jpaQuery = em.createQuery( "select w from Wallet w " );
try {
String parameterName = jpaQuery.getParameter( 1 ).getName();
Parameter parameter = jpaQuery.getParameter( 1 );
fail( "Should fail due to a user error in parameters" );
}
catch ( IllegalArgumentException e ) {
// success, expected.
catch (Exception e) {
assertTyping( IllegalArgumentException.class, e );
}
// using jpa-style, position index specified not in query - test exception type
@ -1081,8 +1081,8 @@ public class QueryTest extends BaseEntityManagerFunctionalTestCase {
Parameter<Integer> parameter = jpaQuery.getParameter( 1, Integer.class );
fail( "Should fail due to user error in parameters" );
}
catch ( IllegalArgumentException e ) {
// success, expected.
catch (Exception e) {
assertTyping( IllegalArgumentException.class, e );
}
// using hql-style, should be 0-based
@ -1092,9 +1092,8 @@ public class QueryTest extends BaseEntityManagerFunctionalTestCase {
hqlQuery.setParameter( 2, "Expensive" );
fail( "Should fail due to a user error in parameters" );
}
catch (IllegalArgumentException e) {
// success expected
e.printStackTrace();
catch (Exception e) {
assertTyping( IllegalArgumentException.class, e );
}
}
finally {
@ -1123,8 +1122,8 @@ public class QueryTest extends BaseEntityManagerFunctionalTestCase {
Parameter<?> parameter = jpaQuery.getParameter( "brand" );
fail( "Should fail due to user error in parameters" );
}
catch ( IllegalArgumentException e ) {
// success, expected
catch (Exception e) {
assertTyping( IllegalArgumentException.class, e );
}
jpaQuery = em.createQuery( "select w from Wallet w" );
@ -1132,8 +1131,8 @@ public class QueryTest extends BaseEntityManagerFunctionalTestCase {
Parameter<String> parameter = jpaQuery.getParameter( "brand", String.class );
fail( "Should fail due to user error in parameters" );
}
catch ( IllegalArgumentException e ) {
// success, expected
catch (Exception e) {
assertTyping( IllegalArgumentException.class, e );
}
}