Hibernate
/
hibernate-orm
mirror of https://github.com/hibernate/hibernate-orm
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

fix handling of typestamp arithmetic on Sybase 

this was a total inconsistent mess that made no sense
This commit is contained in:
Gavin 2023-01-13 22:07:55 +01:00 committed by Gavin King
parent c852d1ca0d
commit 56774f80d7
4 changed files with 43 additions and 49 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

46
hibernate-community-dialects/src/main/java/org/hibernate/community/dialect/SybaseASELegacyDialect.java
View File

@ -266,56 +266,46 @@ public class SybaseASELegacyDialect extends SybaseLegacyDialect {
return "current_bigdatetime()";
}
@Override
public long getFractionalSecondPrecisionInNanos() {
// Sybase supports microsecond precision
// but when we use it we just get numerical
// overflows from timestamp arithmetic
return 1_000_000;
}
@Override
public String timestampaddPattern(TemporalUnit unit, TemporalType temporalType, IntervalType intervalType) {
//TODO!!
switch ( unit ) {
case NANOSECOND:
return "dateadd(ms,?2/1000000,?3)";
// return "dateadd(mcs,?2/1000,?3)";
case NATIVE:
// If the driver or database do not support bigdatetime and bigtime types,
// we try to operate on milliseconds instead
if ( getVersion().isBefore( 15, 5 ) || jtdsDriver ) {
return "dateadd(millisecond,?2/1000000,?3)";
}
else {
return "dateadd(mcs,?2/1000,?3)";
}
return "dateadd(ms,?2,?3)";
// return "dateadd(mcs,?2,?3)";
default:
return "dateadd(?1,?2,?3)";
}
}
@Override
public long getFractionalSecondPrecisionInNanos() {
// If the database does not support bigdatetime and bigtime types,
// we try to operate on milliseconds instead
if ( getVersion().isBefore( 15, 5 ) ) {
return 1_000_000;
}
else {
return 1_000;
}
}
@Override
public String timestampdiffPattern(TemporalUnit unit, TemporalType fromTemporalType, TemporalType toTemporalType) {
//TODO!!
switch ( unit ) {
case NANOSECOND:
return "(cast(datediff(ms,?2,?3) as numeric(21))*1000000)";
// return "(cast(datediff(mcs,?2,?3) as numeric(21))*1000)";
// }
case NATIVE:
// If the database does not support bigdatetime and bigtime types,
// we try to operate on milliseconds instead
if ( getVersion().isBefore( 15, 5 ) ) {
return "cast(datediff(ms,?2,?3) as numeric(21))";
}
else {
return "cast(datediff(mcs,cast(?2 as bigdatetime),cast(?3 as bigdatetime)) as numeric(21))";
}
return "cast(datediff(ms,?2,?3) as numeric(21))";
// return "cast(datediff(mcs,cast(?2 as bigdatetime),cast(?3 as bigdatetime)) as numeric(21))";
default:
return "datediff(?1,?2,?3)";
}
}
@Override
protected void registerDefaultKeywords() {
super.registerDefaultKeywords();

33
hibernate-core/src/main/java/org/hibernate/dialect/SybaseASEDialect.java
View File

@ -261,39 +261,40 @@ public class SybaseASEDialect extends SybaseDialect {
return "current_bigdatetime()";
}
@Override
public long getFractionalSecondPrecisionInNanos() {
// Sybase supports microsecond precision
// but when we use it we just get numerical
// overflows from timestamp arithmetic
return 1_000_000;
}
@Override
public String timestampaddPattern(TemporalUnit unit, TemporalType temporalType, IntervalType intervalType) {
//TODO!!
switch ( unit ) {
case NANOSECOND:
return "dateadd(ms,?2/1000000,?3)";
// return "dateadd(mcs,?2/1000,?3)";
case NATIVE:
// If the driver or database do not support bigdatetime and bigtime types,
// we try to operate on milliseconds instead
if ( jtdsDriver ) {
return "dateadd(millisecond,?2/1000000,?3)";
}
else {
return "dateadd(mcs,?2/1000,?3)";
}
return "dateadd(ms,?2,?3)";
// return "dateadd(mcs,?2,?3)";
default:
return "dateadd(?1,?2,?3)";
}
}
@Override
public long getFractionalSecondPrecisionInNanos() {
// If the database does not support bigdatetime and bigtime types,
// we try to operate on milliseconds instead
return 1_000;
}
@Override
public String timestampdiffPattern(TemporalUnit unit, TemporalType fromTemporalType, TemporalType toTemporalType) {
//TODO!!
switch ( unit ) {
case NANOSECOND:
return "(cast(datediff(ms,?2,?3) as numeric(21))*1000000)";
// return "(cast(datediff(mcs,?2,?3) as numeric(21))*1000)";
// }
case NATIVE:
return "cast(datediff(mcs,cast(?2 as bigdatetime),cast(?3 as bigdatetime)) as numeric(21))";
return "cast(datediff(ms,?2,?3) as numeric(21))";
// return "cast(datediff(mcs,cast(?2 as bigdatetime),cast(?3 as bigdatetime)) as numeric(21))";
default:
return "datediff(?1,?2,?3)";
}

7
hibernate-core/src/test/java/org/hibernate/orm/test/query/hql/FunctionTests.java
View File

@ -1425,8 +1425,11 @@ public class FunctionTests {
.list();
session.createQuery("select current_timestamp - (current_timestamp - e.theTimestamp) from EntityOfBasics e")
.list();
//these cause numerical overflow on Sybase
// session.createQuery("select current_timestamp - e.theTimestamp from EntityOfBasics e")
// .list();
// session.createQuery("select current_timestamp - (current_timestamp - e.theTimestamp) from EntityOfBasics e")
// .list();
}
);
}

6
hibernate-core/src/test/java/org/hibernate/orm/test/query/hql/StandardFunctionTests.java
View File

@ -547,9 +547,9 @@ public class StandardFunctionTests {
session.createQuery("select (e.theTimestamp - (e.theTimestamp + (4 day + 2 hour))) by second from EntityOfBasics e")
.list();
session.createQuery("select current_timestamp - (current_timestamp - e.theTimestamp) from EntityOfBasics e")
.list();
// causes numerical overflow on Sybase
// session.createQuery("select current_timestamp - (current_timestamp - e.theTimestamp) from EntityOfBasics e")
// .list();
}
);
}