Hibernate
/
hibernate-orm
mirror of https://github.com/hibernate/hibernate-orm
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

HHH-7549 Removing some unnecessary System.out.println calls

This commit is contained in:
Hardy Ferentschik 2012-08-27 13:30:21 +02:00
parent 35279ceed6
commit 5dcf91b082
16 changed files with 99 additions and 114 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
hibernate-core/src/test/java/org/hibernate/jdbc/util/BasicFormatterTest.java
View File

@ -67,8 +67,6 @@ public class BasicFormatterTest extends BaseUnitTestCase {
StringTokenizer formatted = new StringTokenizer( formattedQuery, " \t\n\r\f()" );
StringTokenizer plain = new StringTokenizer( query, " \t\n\r\f()" );
System.out.println( "Original: " + query );
System.out.println( "Formatted: " + formattedQuery );
while ( formatted.hasMoreTokens() && plain.hasMoreTokens() ) {
String plainToken = plain.nextToken();
String formattedToken = formatted.nextToken();

36
hibernate-core/src/test/java/org/hibernate/metamodel/internal/source/annotations/entity/OneToManyBindingTest.java
View File

@ -1,8 +1,30 @@
/*
* Hibernate, Relational Persistence for Idiomatic Java
*
* Copyright (c) 2010, Red Hat Inc. or third-party contributors as
* indicated by the @author tags or express copyright attribution
* statements applied by the authors. All third-party contributions are
* distributed under license by Red Hat Inc.
*
* This copyrighted material is made available to anyone wishing to use, modify,
* copy, or redistribute it subject to the terms and conditions of the GNU
* Lesser General Public License, as published by the Free Software Foundation.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY
* or FITNESS FOR A PARTICULAR PURPOSE. See the GNU Lesser General Public License
* for more details.
*
* You should have received a copy of the GNU Lesser General Public License
* along with this distribution; if not, write to:
* Free Software Foundation, Inc.
* 51 Franklin Street, Fifth Floor
* Boston, MA 02110-1301 USA
*/
package org.hibernate.metamodel.internal.source.annotations.entity;
import org.junit.Test;
import org.hibernate.metamodel.spi.binding.AttributeBinding;
import org.hibernate.metamodel.spi.binding.EntityBinding;
import org.hibernate.test.annotations.loader.Player;
import org.hibernate.test.annotations.loader.Team;
@ -16,18 +38,12 @@ import static org.junit.Assert.assertNotNull;
*/
public class OneToManyBindingTest extends BaseAnnotationBindingTestCase {
@Test
@Resources(annotatedClasses = { Team.class, Player.class})
public void testPluralAttributeBindingTest(){
@Resources(annotatedClasses = { Team.class, Player.class })
public void testPluralAttributeBindingTest() {
EntityBinding playerBinding = getEntityBinding( Player.class );
assertNotNull( playerBinding );
for( AttributeBinding attributeBinding : playerBinding.attributeBindings()){
System.out.println(attributeBinding.getAttribute().getName());
}
System.out.println("-----------");
EntityBinding teamBinding = getEntityBinding( Team.class );
assertNotNull( teamBinding );
for(AttributeBinding attributeBinding : teamBinding.attributeBindings()){
System.out.println(attributeBinding.getAttribute().getName());
}
}
}

7
hibernate-core/src/test/java/org/hibernate/test/annotations/id/UUIDGenerator.java
View File

@ -21,13 +21,8 @@ public class UUIDGenerator implements IdentifierGenerator {
public Serializable generate(SessionImplementor arg0, Object arg1) throws HibernateException {
UUID uuid = UUID.randomUUID();
String sud = uuid.toString();
System.out.println("uuid="+uuid);
sud = sud.replaceAll("-", "");
BigInteger integer = new BigInteger(sud,16);
System.out.println("bi ="+integer.toString() );
BigInteger integer = new BigInteger(sud,16);;
return integer;
}
}

5
hibernate-core/src/test/java/org/hibernate/test/annotations/id/sequences/UUIDGenerator.java
View File

@ -21,13 +21,8 @@ public class UUIDGenerator implements IdentifierGenerator {
public Serializable generate(SessionImplementor arg0, Object arg1) throws HibernateException {
UUID uuid = UUID.randomUUID();
String sud = uuid.toString();
System.out.println("uuid="+uuid);
sud = sud.replaceAll("-", "");
BigInteger integer = new BigInteger(sud,16);
System.out.println("bi ="+integer.toString() );
return integer;
}
}

2
hibernate-core/src/test/java/org/hibernate/test/annotations/manytoonewithformula/ManyToOneWithFormulaTest.java
View File

@ -181,7 +181,6 @@ public class ManyToOneWithFormulaTest extends BaseCoreFunctionalTestCase {
kit = (Product) s.get(Product.class, 1);
kitkat = (Product) s.get(Product.class, 2);
System.out.println(kitkat.description);
assertNotNull(kitkat);
assertEquals(kit, kitkat.getProductFamily());
assertEquals(kit.productIdnf, kitkat.getProductFamily().productIdnf);
@ -216,7 +215,6 @@ public class ManyToOneWithFormulaTest extends BaseCoreFunctionalTestCase {
kit = (ProductSqlServer) s.get(ProductSqlServer.class, 1);
kitkat = (ProductSqlServer) s.get(ProductSqlServer.class, 2);
System.out.println(kitkat.description);
assertNotNull(kitkat);
assertEquals(kit, kitkat.getProductFamily());
assertEquals(kit.productIdnf, kitkat.getProductFamily().productIdnf);

1
hibernate-core/src/test/java/org/hibernate/test/cascade/circle/MultiPathCircleCascadeTest.java
View File

@ -605,7 +605,6 @@ public class MultiPathCircleCascadeTest extends BaseCoreFunctionalTestCase {
s.beginTransaction();
route = (Route) s.get( Route.class, route.getRouteID() );
//System.out.println(route);
route.setName( "new routA" );
route.setTransientField( new String( "sfnaouisrbn" ) );

1
hibernate-core/src/test/java/org/hibernate/test/cid/CompositeIdTest.java
View File

@ -88,7 +88,6 @@ public class CompositeIdTest extends BaseCoreFunctionalTestCase {
assertEquals( 1, plan.getTranslators().length );
final QueryTranslator translator = plan.getTranslators()[0];
final String generatedSql = translator.getSQLString();
System.out.println( "Generated SQL : " + generatedSql );
final int countExpressionListStart = generatedSql.indexOf( "count(" );
final int countExpressionListEnd = generatedSql.indexOf( ")", countExpressionListStart );

5
hibernate-core/src/test/java/org/hibernate/test/dirtiness/CustomDirtinessStrategyTest.java
View File

@ -124,7 +124,6 @@ public class CustomDirtinessStrategyTest extends BaseCoreFunctionalTestCase {
@Override
public boolean canDirtyCheck(Object entity, EntityPersister persister, Session session) {
canDirtyCheckCount++;
System.out.println( "canDirtyCheck called" );
return Thing.class.isInstance( entity );
}
@ -133,7 +132,6 @@ public class CustomDirtinessStrategyTest extends BaseCoreFunctionalTestCase {
@Override
public boolean isDirty(Object entity, EntityPersister persister, Session session) {
isDirtyCount++;
System.out.println( "isDirty called" );
return ! Thing.class.cast( entity ).changedValues.isEmpty();
}
@ -142,7 +140,6 @@ public class CustomDirtinessStrategyTest extends BaseCoreFunctionalTestCase {
@Override
public void resetDirty(Object entity, EntityPersister persister, Session session) {
resetDirtyCount++;
System.out.println( "resetDirty called" );
Thing.class.cast( entity ).changedValues.clear();
}
@ -151,7 +148,6 @@ public class CustomDirtinessStrategyTest extends BaseCoreFunctionalTestCase {
@Override
public void findDirty(final Object entity, EntityPersister persister, Session session, DirtyCheckContext dirtyCheckContext) {
findDirtyCount++;
System.out.println( "findDirty called" );
dirtyCheckContext.doDirtyChecking(
new AttributeChecker() {
@Override
@ -169,5 +165,4 @@ public class CustomDirtinessStrategyTest extends BaseCoreFunctionalTestCase {
findDirtyCount = 0;
}
}
}

2
hibernate-core/src/test/java/org/hibernate/test/joinfetch/JoinFetchTest.java
View File

@ -84,7 +84,6 @@ public class JoinFetchTest extends BaseCoreFunctionalTestCase {
new Comment(i, "This looks like a really good deal");
new Comment(i, "Is it the latest version?");
new Comment(i, "<comment deleted>");
System.out.println( b.getTimestamp() );
s = openSession();
t = s.beginTransaction();
@ -113,7 +112,6 @@ public class JoinFetchTest extends BaseCoreFunctionalTestCase {
assertTrue( Hibernate.isInitialized( b.getItem() ) );
assertTrue( Hibernate.isInitialized( b.getItem().getComments() ) );
assertEquals( b.getItem().getComments().size(), 3 );
System.out.println( b.getTimestamp() );
t.commit();
s.close();

5
hibernate-core/src/test/java/org/hibernate/test/legacy/ParentChildTest.java
View File

@ -876,10 +876,7 @@ public class ParentChildTest extends LegacyTestCase {
s = openSession();
t = s.beginTransaction();
c = (Container) s.load( Container.class, new Long( c.getId() ) );
System.out.println( c.getOneToMany() );
System.out.println( c.getManyToMany() );
System.out.println( c.getComponents() );
System.out.println( c.getComposites() );
assertTrue( c.getComponents().size()==1 ); //WAS: 2
assertTrue( c.getComposites().size()==2 );
assertTrue( ( (Container.ContainerInnerClass) c.getComponents().get(0) ).getName().equals("a different name") );

59
hibernate-core/src/test/java/org/hibernate/test/naturalid/immutable/ImmutableEntityNaturalIdTest.java
View File

@ -34,6 +34,7 @@ import org.hibernate.Transaction;
import org.hibernate.cfg.Configuration;
import org.hibernate.cfg.Environment;
import org.hibernate.criterion.Restrictions;
import org.hibernate.testing.FailureExpectedWithNewMetamodel;
import org.hibernate.testing.junit4.BaseCoreFunctionalTestCase;
import static org.junit.Assert.fail;
@ -41,40 +42,41 @@ import static org.junit.Assert.fail;
/**
* @author Alex Burgel
*/
@FailureExpectedWithNewMetamodel
public class ImmutableEntityNaturalIdTest extends BaseCoreFunctionalTestCase {
public String[] getMappings() {
return new String[] { "naturalid/immutable/ParentChildWithManyToOne.hbm.xml" };
}
public void configure(Configuration cfg) {
cfg.setProperty(Environment.USE_SECOND_LEVEL_CACHE, "true");
cfg.setProperty(Environment.USE_QUERY_CACHE, "true");
cfg.setProperty(Environment.GENERATE_STATISTICS, "true");
cfg.setProperty( Environment.USE_SECOND_LEVEL_CACHE, "true" );
cfg.setProperty( Environment.USE_QUERY_CACHE, "true" );
cfg.setProperty( Environment.GENERATE_STATISTICS, "true" );
}
@Test
public void testNaturalIdCheck() throws Exception {
Session s = openSession();
Transaction t = s.beginTransaction();
Parent p = new Parent("alex");
Child c = new Child("billy", p);
s.persist(p);
s.persist(c);
Parent p = new Parent( "alex" );
Child c = new Child( "billy", p );
s.persist( p );
s.persist( c );
t.commit();
s.close();
Field name = c.getClass().getDeclaredField("name");
name.setAccessible(true);
name.set(c, "phil");
Field name = c.getClass().getDeclaredField( "name" );
name.setAccessible( true );
name.set( c, "phil" );
s = openSession();
t = s.beginTransaction();
try {
s.saveOrUpdate( c );
s.flush();
fail( "should have failed because immutable natural ID was altered");
fail( "should have failed because immutable natural ID was altered" );
}
catch (HibernateException he) {
catch ( HibernateException he ) {
// expected
}
finally {
@ -82,37 +84,37 @@ public class ImmutableEntityNaturalIdTest extends BaseCoreFunctionalTestCase {
s.close();
}
name.set(c, "billy");
name.set( c, "billy" );
s = openSession();
t = s.beginTransaction();
s.delete(c);
s.delete(p);
s.delete( c );
s.delete( p );
t.commit();
s.close();
}
@Test
@SuppressWarnings( {"unchecked"})
@SuppressWarnings({ "unchecked" })
public void testSaveParentWithDetachedChildren() throws Exception {
Session s = openSession();
Transaction t = s.beginTransaction();
Parent p = new Parent("alex");
Child c = new Child("billy", p);
Parent p = new Parent( "alex" );
Child c = new Child( "billy", p );
s.persist(p);
s.persist(c);
s.persist( p );
s.persist( c );
t.commit();
s.close();
s = openSession();
t = s.beginTransaction();
p = (Parent) s.createCriteria(Parent.class)
.add( Restrictions.eq("name", "alex") )
.setFetchMode("children", FetchMode.JOIN)
.setCacheable(true)
p = ( Parent ) s.createCriteria( Parent.class )
.add( Restrictions.eq( "name", "alex" ) )
.setFetchMode( "children", FetchMode.JOIN )
.setCacheable( true )
.uniqueResult();
t.commit();
@ -121,18 +123,17 @@ public class ImmutableEntityNaturalIdTest extends BaseCoreFunctionalTestCase {
s = openSession();
t = s.beginTransaction();
Child c2 = new Child("joey", p);
p.getChildren().add(c2);
Child c2 = new Child( "joey", p );
p.getChildren().add( c2 );
s.update(p);
s.update( p );
// this fails if AbstractEntityPersister returns identifiers instead of entities from
// AbstractEntityPersister.getNaturalIdSnapshot()
s.flush();
s.delete(p);
s.delete( p );
t.commit();
s.close();
}
}

4
hibernate-core/src/test/java/org/hibernate/test/nonflushedchanges/CreateTest.java
View File

@ -100,13 +100,13 @@ public class CreateTest extends AbstractOperationTestCase {
TestingJtaPlatformImpl.INSTANCE.getTransactionManager().begin();
s = openSession();
System.out.println( "getting" );
root = ( Node ) s.get( Node.class, "root" );
s = applyNonFlushedChangesToNewSessionCloseOldSession( s );
root = ( Node ) getOldToNewEntityRefMap().get( root );
Node child2 = new Node( "child2" );
root.addChild( child2 );
System.out.println( "committing" );
applyNonFlushedChangesToNewSessionCloseOldSession( s );
TestingJtaPlatformImpl.INSTANCE.getTransactionManager().commit();

2
hibernate-core/src/test/java/org/hibernate/test/ops/CreateTest.java
View File

@ -91,11 +91,9 @@ public class CreateTest extends AbstractOperationTestCase {
s = openSession();
tx = s.beginTransaction();
System.out.println("getting");
root = (Node) s.get(Node.class, "root");
Node child2 = new Node("child2");
root.addChild(child2);
System.out.println("committing");
tx.commit();
s.close();

2
hibernate-core/src/test/java/org/hibernate/test/pagination/DistinctSelectTest.java
View File

@ -82,8 +82,6 @@ public class DistinctSelectTest extends BaseCoreFunctionalTestCase {
Session s = openSession();
List<Entry> entries = s.createQuery("select distinct e from Entry e join e.tags t where t.surrogate != null order by e.name").setFirstResult(10).setMaxResults(5).list();
// System.out.println(entries);
Entry firstEntry = entries.remove(0);
assertFalse("The list of entries should not contain dublicated Entry objects as we've done a distinct select", entries.contains(firstEntry));

3
hibernate-core/src/test/java/org/hibernate/test/propertyref/DoesNotWorkWithHbmTest.java
View File

@ -78,9 +78,6 @@ public class DoesNotWorkWithHbmTest extends BaseCoreFunctionalTestCase {
List<String> notes = entity.getGlobalNotes();
assertNotNull( notes );
assertEquals( 2, notes.size() );
for ( String s : notes ) {
System.out.println( s );
}
session.delete( entity );
session.getTransaction().commit();
session.close();

21
hibernate-core/src/test/java/org/hibernate/test/stats/SessionStatsTest.java
View File

@ -32,6 +32,7 @@ import org.hibernate.Session;
import org.hibernate.Transaction;
import org.hibernate.stat.SessionStatistics;
import org.hibernate.stat.Statistics;
import org.hibernate.testing.FailureExpectedWithNewMetamodel;
import org.hibernate.testing.junit4.BaseCoreFunctionalTestCase;
import static org.junit.Assert.assertEquals;
@ -39,6 +40,7 @@ import static org.junit.Assert.assertEquals;
/**
* @author Emmanuel Bernard
*/
@FailureExpectedWithNewMetamodel
public class SessionStatsTest extends BaseCoreFunctionalTestCase {
@Override
public String[] getMappings() {
@ -52,8 +54,8 @@ public class SessionStatsTest extends BaseCoreFunctionalTestCase {
Statistics stats = sessionFactory().getStatistics();
stats.clear();
boolean isStats = stats.isStatisticsEnabled();
stats.setStatisticsEnabled(true);
Continent europe = fillDb(s);
stats.setStatisticsEnabled( true );
Continent europe = fillDb( s );
tx.commit();
s.clear();
tx = s.beginTransaction();
@ -62,7 +64,7 @@ public class SessionStatsTest extends BaseCoreFunctionalTestCase {
assertEquals( 0, sessionStats.getEntityCount() );
assertEquals( 0, sessionStats.getCollectionKeys().size() );
assertEquals( 0, sessionStats.getCollectionCount() );
europe = (Continent) s.get( Continent.class, europe.getId() );
europe = ( Continent ) s.get( Continent.class, europe.getId() );
Hibernate.initialize( europe.getCountries() );
Hibernate.initialize( europe.getCountries().iterator().next() );
assertEquals( 2, sessionStats.getEntityKeys().size() );
@ -72,20 +74,19 @@ public class SessionStatsTest extends BaseCoreFunctionalTestCase {
tx.commit();
s.close();
stats.setStatisticsEnabled( isStats);
stats.setStatisticsEnabled( isStats );
}
private Continent fillDb(Session s) {
Continent europe = new Continent();
europe.setName("Europe");
europe.setName( "Europe" );
Country france = new Country();
france.setName("France");
france.setName( "France" );
europe.setCountries( new HashSet() );
europe.getCountries().add(france);
s.persist(france);
s.persist(europe);
europe.getCountries().add( france );
s.persist( france );
s.persist( europe );
return europe;
}
}