Hibernate
/
hibernate-orm
mirror of https://github.com/hibernate/hibernate-orm
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

HHH-2592 : Dialect.forceLimitUsage 

git-svn-id: https://svn.jboss.org/repos/hibernate/core/trunk@15192 1b8cb986-b30d-0410-93ca-fae66ebed9b2
This commit is contained in:
Steve Ebersole 2008-09-12 06:17:00 +00:00
parent f85f5cc0c8
commit 664029469b
2 changed files with 13 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
core/src/main/java/org/hibernate/dialect/Dialect.java
View File

@ -767,16 +767,6 @@ public abstract class Dialect {
return false; return false;
} }
/**
* Generally, if there is no limit applied to a Hibernate query we do not apply any limits
* to the SQL query. This option forces that the limit be written to the SQL query.
*
* @return True to force limit into SQL query even if none specified in Hibernate query; false otherwise.
*/
public boolean forceLimitUsage() {
return true;
}
/** /**
* Does this dialect's LIMIT support (if any) additionally * Does this dialect's LIMIT support (if any) additionally
* support specifying an offset? * support specifying an offset?
@ -837,6 +827,16 @@ public abstract class Dialect {
return false; return false;
} }
/**
* Generally, if there is no limit applied to a Hibernate query we do not apply any limits
* to the SQL query. This option forces that the limit be written to the SQL query.
*
* @return True to force limit into SQL query even if none specified in Hibernate query; false otherwise.
*/
public boolean forceLimitUsage() {
return false;
}
/** /**
* Given a limit and an offset, apply the limit clause to the query. * Given a limit and an offset, apply the limit clause to the query.
* *
@ -846,7 +846,7 @@ public abstract class Dialect {
* @return The modified query statement with the limit applied. * @return The modified query statement with the limit applied.
*/ */
public String getLimitString(String query, int offset, int limit) { public String getLimitString(String query, int offset, int limit) {
return getLimitString( query, offset > 0 ); return getLimitString( query, ( offset > 0 || forceLimitUsage() ) );
} }
/** /**

4
core/src/main/java/org/hibernate/loader/Loader.java
View File

@ -1526,7 +1526,7 @@ public abstract class Loader {
* LIMIT clause. * LIMIT clause.
*/ */
private static boolean useLimit(final RowSelection selection, final Dialect dialect) { private static boolean useLimit(final RowSelection selection, final Dialect dialect) {
return dialect.supportsLimit() && ( hasMaxRows( selection ) || dialect.forceLimitUsage() ); return dialect.supportsLimit() && hasMaxRows( selection );
} }
/** /**
@ -1659,7 +1659,7 @@ public abstract class Loader {
} }
int firstRow = getFirstRow( selection ); int firstRow = getFirstRow( selection );
int lastRow = getMaxOrLimit( selection, dialect ); int lastRow = getMaxOrLimit( selection, dialect );
boolean hasFirstRow = firstRow > 0 && dialect.supportsLimitOffset(); boolean hasFirstRow = dialect.supportsLimitOffset() && ( firstRow > 0 || dialect.forceLimitUsage() );
boolean reverse = dialect.bindLimitParametersInReverseOrder(); boolean reverse = dialect.bindLimitParametersInReverseOrder();
if ( hasFirstRow ) { if ( hasFirstRow ) {
statement.setInt( index + ( reverse ? 1 : 0 ), firstRow ); statement.setInt( index + ( reverse ? 1 : 0 ), firstRow );