Hibernate/hibernate-orm
1
0
Fork 0
mirror of https://github.com/hibernate/hibernate-orm synced 2025-02-13 06:34:50 +00:00
Code Issues Packages Projects Releases Wiki Activity

HHH-13580 Ignore LocalTimeTest and OffsetTimeTest's 'nativeWriteThenRead' test for MySQL

Browse Source 
The returned time is right (otherwise #writeThenRead would fail), it's
just that a different day is returned, but it won't affect the LocalTime
representation manipulated by the user.
This commit is contained in:
Yoann Rodière 2019-08-26 13:31:17 +02:00 committed by gbadner
parent 8fce51c765
commit 74d35b2d59
2 changed files with 14 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
hibernate-core/src/test/java/org/hibernate/test/type/LocalTimeTest.java
View File

@ -23,6 +23,7 @@
import org.hibernate.dialect.AbstractHANADialect; import org.hibernate.dialect.AbstractHANADialect;
import org.hibernate.dialect.MariaDBDialect; import org.hibernate.dialect.MariaDBDialect;
import org.hibernate.dialect.MySQL5Dialect;
import org.hibernate.dialect.MySQLDialect; import org.hibernate.dialect.MySQLDialect;
import org.hibernate.type.descriptor.sql.TimestampTypeDescriptor; import org.hibernate.type.descriptor.sql.TimestampTypeDescriptor;
@ -186,6 +187,12 @@ protected Object getActualJdbcValue(ResultSet resultSet, int columnIndex) throws
@Override @Override
@Test @Test
@SkipForDialect(value = AbstractHANADialect.class, comment = "HANA seems to return a java.sql.Timestamp instead of a java.sql.Time") @SkipForDialect(value = AbstractHANADialect.class, comment = "HANA seems to return a java.sql.Timestamp instead of a java.sql.Time")
@SkipForDialect(value = MySQL5Dialect.class,
comment = "HHH-13580 MySQL seems to store the whole timestamp, not just the time,"
+ " which for some timezones results in a date other than 1970-01-01 being returned"
+ " (typically 1969-12-31), even though the time is always right."
+ " Since java.sql.Time holds the whole timestamp, not just the time,"
+ " its equals() method ends up returning false in this test.")
public void writeThenNativeRead() { public void writeThenNativeRead() {
super.writeThenNativeRead(); super.writeThenNativeRead();
} }

7
hibernate-core/src/test/java/org/hibernate/test/type/OffsetTimeTest.java
View File

@ -25,6 +25,7 @@
import org.hibernate.dialect.AbstractHANADialect; import org.hibernate.dialect.AbstractHANADialect;
import org.hibernate.dialect.MariaDBDialect; import org.hibernate.dialect.MariaDBDialect;
import org.hibernate.dialect.MySQL5Dialect;
import org.hibernate.dialect.MySQLDialect; import org.hibernate.dialect.MySQLDialect;
import org.hibernate.type.descriptor.sql.BigIntTypeDescriptor; import org.hibernate.type.descriptor.sql.BigIntTypeDescriptor;
import org.hibernate.type.descriptor.sql.TimestampTypeDescriptor; import org.hibernate.type.descriptor.sql.TimestampTypeDescriptor;
@ -215,6 +216,12 @@ protected Object getActualJdbcValue(ResultSet resultSet, int columnIndex) throws
@Override @Override
@Test @Test
@SkipForDialect(value = AbstractHANADialect.class, comment = "HANA seems to return a java.sql.Timestamp instead of a java.sql.Time") @SkipForDialect(value = AbstractHANADialect.class, comment = "HANA seems to return a java.sql.Timestamp instead of a java.sql.Time")
@SkipForDialect(value = MySQL5Dialect.class,
comment = "HHH-13580 MySQL seems to store the whole timestamp, not just the time,"
+ " which for some timezones results in a date other than 1970-01-01 being returned"
+ " (typically 1969-12-31), even though the time is always right."
+ " Since java.sql.Time holds the whole timestamp, not just the time,"
+ " its equals() method ends up returning false in this test.")
public void writeThenNativeRead() { public void writeThenNativeRead() {
super.writeThenNativeRead(); super.writeThenNativeRead();
} }