Polishing JakartaPublishingPlugin

1. fix `Note: Recompile with -Xlint:unchecked for details.`
2. return value of method `addVariant` is not used.
3. refine lambda.
4. remove unused import.
This commit is contained in:
Yanming Zhou 2024-09-18 10:34:38 +08:00 committed by Christian Beikov
parent bad79af6bd
commit 75ac785517
1 changed files with 3 additions and 9 deletions

View File

@ -24,7 +24,6 @@ import org.gradle.api.component.SoftwareComponentFactory;
import org.gradle.api.model.ObjectFactory; import org.gradle.api.model.ObjectFactory;
import org.gradle.api.tasks.TaskContainer; import org.gradle.api.tasks.TaskContainer;
import org.gradle.api.tasks.TaskProvider; import org.gradle.api.tasks.TaskProvider;
import org.gradle.api.tasks.testing.Test;
/** /**
* Models a publishable Jakartafied project * Models a publishable Jakartafied project
@ -168,7 +167,7 @@ public class JakartaPublishingPlugin implements Plugin<Project> {
} }
private Configuration addVariant( private void addVariant(
String configName, String configName,
String jarTaskName, String jarTaskName,
String classifier, String classifier,
@ -199,17 +198,14 @@ public class JakartaPublishingPlugin implements Plugin<Project> {
mainJarTask = tasks.register( mainJarTask = tasks.register(
jarTaskName, jarTaskName,
JakartaJarTransformation.class, JakartaJarTransformation.class,
(jakartaficationTask) -> jakartaficationTask.setDescription( "Produces the Jakartafied main jar for `" + project.getPath() + "`" )
(jakartaficationTask) -> {
jakartaficationTask.setDescription( "Produces the Jakartafied main jar for `" + project.getPath() + "`" );
}
); );
if ( tasks.getNames().contains( "assemble" ) ) { if ( tasks.getNames().contains( "assemble" ) ) {
tasks.named( "assemble" ).configure( (assembleTask) -> assembleTask.dependsOn( mainJarTask ) ); tasks.named( "assemble" ).configure( (assembleTask) -> assembleTask.dependsOn( mainJarTask ) );
} }
} }
else { else {
mainJarTask = (TaskProvider) tasks.named( jarTaskName ); mainJarTask = tasks.named( jarTaskName, JakartaJarTransformation.class );
} }
variantConfig.getOutgoing().artifact( variantConfig.getOutgoing().artifact(
@ -220,8 +216,6 @@ public class JakartaPublishingPlugin implements Plugin<Project> {
artifact.builtBy( jakartaJarTask ); artifact.builtBy( jakartaJarTask );
} }
); );
return variantConfig;
} }
} }