Hibernate
/
hibernate-orm
mirror of https://github.com/hibernate/hibernate-orm
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

remove two useless @FailureExpected tests 

having failing tests for features we have never supported
isn't actually useful at all, and just slows us down
This commit is contained in:
Gavin King 2024-09-16 21:43:40 +02:00
parent 49a3ecd2c0
commit 79c8b41298
2 changed files with 0 additions and 298 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

198
hibernate-core/src/test/java/org/hibernate/orm/test/annotations/cid/CompositeIdFkGeneratedValueIdentityTest.java
View File

@ -1,198 +0,0 @@
/*
* SPDX-License-Identifier: LGPL-2.1-or-later
* Copyright Red Hat Inc. and Hibernate Authors
*/
package org.hibernate.orm.test.annotations.cid;
import java.io.Serializable;
import java.util.Objects;
import jakarta.persistence.Entity;
import jakarta.persistence.GeneratedValue;
import jakarta.persistence.GenerationType;
import jakarta.persistence.Id;
import jakarta.persistence.IdClass;
import jakarta.persistence.ManyToOne;
import org.hibernate.testing.orm.junit.JiraKey;
import org.hibernate.testing.orm.junit.DialectFeatureChecks;
import org.hibernate.testing.orm.junit.DomainModel;
import org.hibernate.testing.orm.junit.FailureExpected;
import org.hibernate.testing.orm.junit.RequiresDialectFeature;
import org.hibernate.testing.orm.junit.SessionFactory;
import org.hibernate.testing.orm.junit.SessionFactoryScope;
import org.junit.jupiter.api.Test;
@JiraKey(value = "HHH-10956")
@RequiresDialectFeature(feature = DialectFeatureChecks.SupportsIdentityColumns.class)
@DomainModel(
annotatedClasses = {
CompositeIdFkGeneratedValueIdentityTest.HeadI.class,
CompositeIdFkGeneratedValueIdentityTest.NodeI.class,
CompositeIdFkGeneratedValueIdentityTest.ComplexNodeI.class
}
)
@SessionFactory
public class CompositeIdFkGeneratedValueIdentityTest {
@Test
@FailureExpected(jiraKey = "HHH-9662", reason = "Could not set field value [POST_INSERT_INDICATOR]")
public void testCompositePkWithIdentityAndFKByIdentity(SessionFactoryScope scope) {
scope.inTransaction( session -> {
HeadI head = new HeadI();
head.name = "Head by Identity";
session.persist( head );
System.out.println( "VALUE =>" + head.name + "=" + head.hid );
NodeI node = new NodeI();
node.hid = head;
node.name = "Node by Identity";
try {
session.persist( node );
}
catch (Error | RuntimeException e) {
// expected failure...
e.printStackTrace( System.out );
throw e;
}
System.out.println( "VALUE =>" + node.name + "=" + node.nid + ":" + node.hid.hid );
} );
}
@Test
public void testCompositePkWithIdentityAndFKByIdentity2(SessionFactoryScope scope) {
scope.inTransaction( session -> {
HeadI head = new HeadI();
head.name = "Head by Identity";
session.persist( head );
System.out.println( "VALUE =>" + head.name + "=" + head.hid );
ComplexNodeI node = new ComplexNodeI();
node.hid = head;
node.name = "Node by Identity";
session.persist( node );
System.out.println( "VALUE =>" + node.name + "=" + node.nid + ":" + node.hid.hid + " with parent="
+ ( node.parent == null ?
null :
node.parent.nid + ":" + node.parent.hid.hid ) );
ComplexNodeI node2 = new ComplexNodeI();
node2.hid = head;
node2.name = "Node 2 by Identity";
node2.parent = node;
session.persist( node2 );
System.out.println( "VALUE =>" + node2.name + "=" + node2.nid + ":" + node2.hid.hid + " with parent="
+ ( node2.parent == null ?
null :
node2.parent.nid + ":" + node2.parent.hid.hid ) );
} );
}
@Entity(name = "HeadI")
public static class HeadI {
@Id
@GeneratedValue(strategy = GenerationType.IDENTITY)
private Long hid;
private String name;
}
@Entity(name = "NodeI")
@IdClass(NodeI.PK.class)
public static class NodeI {
@Id
@GeneratedValue(strategy = GenerationType.IDENTITY)
private Long nid;
@Id
@ManyToOne
private HeadI hid;
private String name;
public static class PK implements Serializable {
private Long nid;
private Long hid;
public PK(Long nid, Long hid) {
this.nid = nid;
this.hid = hid;
}
private PK() {
}
@Override
public boolean equals(Object o) {
if ( this == o ) {
return true;
}
if ( o == null || getClass() != o.getClass() ) {
return false;
}
PK pk = (PK) o;
return Objects.equals( nid, pk.nid ) && Objects.equals( hid, pk.hid );
}
@Override
public int hashCode() {
return Objects.hash( nid, hid );
}
}
}
@Entity(name = "ComplexNodeI")
@IdClass(ComplexNodeI.PK.class)
public static class ComplexNodeI {
@Id
@GeneratedValue(strategy = GenerationType.SEQUENCE)
private Long nid;
@Id
@ManyToOne
private HeadI hid;
@ManyToOne
private ComplexNodeI parent;
private String name;
public static class PK implements Serializable {
private Long nid;
private Long hid;
public PK(Long nid, Long hid) {
this.nid = nid;
this.hid = hid;
}
private PK() {
}
@Override
public boolean equals(Object o) {
if ( this == o ) {
return true;
}
if ( o == null || getClass() != o.getClass() ) {
return false;
}
PK pk = (PK) o;
return Objects.equals( nid, pk.nid ) && Objects.equals( hid, pk.hid );
}
@Override
public int hashCode() {
return Objects.hash( nid, hid );
}
}
}
}

100
hibernate-core/src/test/java/org/hibernate/orm/test/annotations/cid/CompositeIdIdentityTest.java
View File

@ -1,100 +0,0 @@
/*
* SPDX-License-Identifier: LGPL-2.1-or-later
* Copyright Red Hat Inc. and Hibernate Authors
*/
package org.hibernate.orm.test.annotations.cid;
import java.io.Serializable;
import jakarta.persistence.Column;
import jakarta.persistence.Entity;
import jakarta.persistence.GeneratedValue;
import jakarta.persistence.GenerationType;
import jakarta.persistence.Id;
import jakarta.persistence.IdClass;
import jakarta.persistence.Table;
import org.hibernate.testing.DialectChecks;
import org.hibernate.testing.FailureExpected;
import org.hibernate.testing.RequiresDialectFeature;
import org.hibernate.testing.orm.junit.JiraKey;
import org.hibernate.testing.junit4.BaseCoreFunctionalTestCase;
import org.junit.Test;
import static org.hibernate.testing.transaction.TransactionUtil.doInHibernate;
/**
* @author Vlad Mihalcea
*/
@RequiresDialectFeature(DialectChecks.SupportsIdentityColumns.class)
@JiraKey( value = "HHH-9662" )
public class CompositeIdIdentityTest extends BaseCoreFunctionalTestCase {
@Test
@FailureExpected( jiraKey = "HHH-9662" )
public void testCompositePkWithIdentity() throws Exception {
doInHibernate( this::sessionFactory, session -> {
Animal animal = new Animal();
animal.setSubId( 123L );
session.persist(animal);
} );
}
@Override
protected Class[] getAnnotatedClasses() {
return new Class[] {
Animal.class
};
}
@Entity
@Table(name = "animal")
@IdClass(IdWithSubId.class)
public static class Animal {
@Id
@GeneratedValue(strategy = GenerationType.IDENTITY)
private Long id;
@Id
@Column(name = "sub_id")
private Long subId;
public Long getId() {
return id;
}
public void setId(Long id) {
this.id = id;
}
public Long getSubId() {
return subId;
}
public void setSubId(Long subId) {
this.subId = subId;
}
}
public static class IdWithSubId implements Serializable {
private Long id;
private Long subId;
public Long getId() {
return id;
}
public void setId(Long id) {
this.id = id;
}
public Long getSubId() {
return subId;
}
public void setSubId(Long subId) {
this.subId = subId;
}
}
}