From 7c6b358d4fd4775c5a9d381de7d855acaacdc296 Mon Sep 17 00:00:00 2001 From: Steve Ebersole Date: Thu, 26 Sep 2013 15:40:49 -0500 Subject: [PATCH] HHH-8551 - Cannot use with-clause on the RHS of a join --- .../hql/internal/ast/HqlSqlWalker.java | 17 +++++++++++------ 1 file changed, 11 insertions(+), 6 deletions(-) diff --git a/hibernate-core/src/main/java/org/hibernate/hql/internal/ast/HqlSqlWalker.java b/hibernate-core/src/main/java/org/hibernate/hql/internal/ast/HqlSqlWalker.java index 23251ee617..81003e2284 100644 --- a/hibernate-core/src/main/java/org/hibernate/hql/internal/ast/HqlSqlWalker.java +++ b/hibernate-core/src/main/java/org/hibernate/hql/internal/ast/HqlSqlWalker.java @@ -400,16 +400,18 @@ public class HqlSqlWalker extends HqlSqlBaseWalker implements ErrorReporter, Par } } - if (LOG.isDebugEnabled()) LOG.debugf("createFromJoinElement() : %s", - getASTPrinter().showAsString(fromElement, "-- join tree --")); + if ( LOG.isDebugEnabled() ) { + LOG.debug("createFromJoinElement() : " + getASTPrinter().showAsString(fromElement, "-- join tree --") ); + } } private void handleWithFragment(FromElement fromElement, AST hqlWithNode) throws SemanticException { try { withClause( hqlWithNode ); AST hqlSqlWithNode = returnAST; - if (LOG.isDebugEnabled()) LOG.debugf("handleWithFragment() : %s", - getASTPrinter().showAsString(hqlSqlWithNode, "-- with clause --")); + if ( LOG.isDebugEnabled() ) { + LOG.debug( "handleWithFragment() : " + getASTPrinter().showAsString(hqlSqlWithNode, "-- with clause --") ); + } WithClauseVisitor visitor = new WithClauseVisitor( fromElement, queryTranslatorImpl ); NodeTraverser traverser = new NodeTraverser( visitor ); traverser.traverseDepthFirst( hqlSqlWithNode ); @@ -421,8 +423,11 @@ public class HqlSqlWalker extends HqlSqlBaseWalker implements ErrorReporter, Par else { FromElement referencedFromElement = visitor.getReferencedFromElement(); if ( referencedFromElement != fromElement ) { - LOG.warn( "with-clause expressions do not reference the from-clause element to which the with-clause was associated. The query may not work as expected..." - + queryTranslatorImpl.getQueryString() ); + LOG.warnf( + "with-clause expressions do not reference the from-clause element to which the " + + "with-clause was associated. The query may not work as expected [%s]", + queryTranslatorImpl.getQueryString() + ); } }