Hibernate
/
hibernate-orm
mirror of https://github.com/hibernate/hibernate-orm
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

HHH-17245 Better conform to SQLite/Xerial driver limitations. 

Added getAlterTableToAddUniqueKeyCommand(), which always returns "", 
because SQLite does not support unique constraints in ALTER TABLE 
statements (see here). 
Added getDefaultUseGetGeneratedKey(), which always returns false, as the 
Xerial driver does support GET_GENERATED_KEYS.
This commit is contained in:
Hendrik Schreiber 2023-09-22 17:09:11 +02:00 committed by Christian Beikov
parent 59d254cae1
commit 82d5d07750
1 changed files with 25 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

25
hibernate-community-dialects/src/main/java/org/hibernate/community/dialect/SQLiteDialect.java
View File

@ -13,6 +13,7 @@ import java.util.Date;
import java.util.TimeZone; import java.util.TimeZone;
import org.hibernate.ScrollMode; import org.hibernate.ScrollMode;
import org.hibernate.boot.Metadata;
import org.hibernate.boot.model.FunctionContributions; import org.hibernate.boot.model.FunctionContributions;
import org.hibernate.boot.model.TypeContributions; import org.hibernate.boot.model.TypeContributions;
import org.hibernate.boot.model.relational.SqlStringGenerationContext; import org.hibernate.boot.model.relational.SqlStringGenerationContext;
@ -37,6 +38,7 @@ import org.hibernate.exception.spi.TemplatedViolatedConstraintNameExtractor;
import org.hibernate.exception.spi.ViolatedConstraintNameExtractor; import org.hibernate.exception.spi.ViolatedConstraintNameExtractor;
import org.hibernate.internal.util.JdbcExceptionHelper; import org.hibernate.internal.util.JdbcExceptionHelper;
import org.hibernate.mapping.Column; import org.hibernate.mapping.Column;
import org.hibernate.mapping.UniqueKey;
import org.hibernate.query.SemanticException; import org.hibernate.query.SemanticException;
import org.hibernate.query.sqm.IntervalType; import org.hibernate.query.sqm.IntervalType;
import org.hibernate.dialect.NullOrdering; import org.hibernate.dialect.NullOrdering;
@ -149,6 +151,19 @@ public class SQLiteDialect extends Dialect {
public String getColumnDefinitionUniquenessFragment(Column column, SqlStringGenerationContext context) { public String getColumnDefinitionUniquenessFragment(Column column, SqlStringGenerationContext context) {
return " unique"; return " unique";
} }
/**
* Alter table support in SQLite is very limited and does
* not include adding a unique constraint (as of 9/2023).
*
* @return always empty String
* @see <a href="https://www.sqlite.org/omitted.html">SQLite SQL omissions</a>
*/
@Override
public String getAlterTableToAddUniqueKeyCommand(UniqueKey uniqueKey, Metadata metadata, SqlStringGenerationContext context) {
return "";
}
} }
@Override @Override
@ -402,6 +417,16 @@ public class SQLiteDialect extends Dialect {
return NullOrdering.SMALLEST; return NullOrdering.SMALLEST;
} }
/**
* Generated keys are not supported by the (standard) Xerial driver (9/2022).
*
* @return false
*/
@Override
public boolean getDefaultUseGetGeneratedKeys() {
return false;
}
@Override @Override
public SqlAstTranslatorFactory getSqlAstTranslatorFactory() { public SqlAstTranslatorFactory getSqlAstTranslatorFactory() {
return new StandardSqlAstTranslatorFactory() { return new StandardSqlAstTranslatorFactory() {