Hibernate
/
hibernate-orm
mirror of https://github.com/hibernate/hibernate-orm
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

HHH-16577 Bytecode enhancement and @DynamicUpdate causes Index Out of Bound Exception

This commit is contained in:
Andrea Boriero 2023-08-09 16:22:49 +02:00 committed by Andrea Boriero
parent 54fbe10116
commit 8630d79e79
1 changed files with 15 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

31
hibernate-core/src/main/java/org/hibernate/bytecode/enhance/spi/interceptor/EnhancementAsProxyLazinessInterceptor.java
View File

@ -17,6 +17,7 @@ import org.hibernate.bytecode.enhance.spi.LazyPropertyInitializer;
import org.hibernate.engine.spi.EntityKey; import org.hibernate.engine.spi.EntityKey;
import org.hibernate.engine.spi.SharedSessionContractImplementor; import org.hibernate.engine.spi.SharedSessionContractImplementor;
import org.hibernate.internal.util.collections.ArrayHelper; import org.hibernate.internal.util.collections.ArrayHelper;
import org.hibernate.metamodel.mapping.AttributeMapping;
import org.hibernate.persister.entity.EntityPersister; import org.hibernate.persister.entity.EntityPersister;
import org.hibernate.type.CompositeType; import org.hibernate.type.CompositeType;
import org.hibernate.type.Type; import org.hibernate.type.Type;
@ -105,7 +106,8 @@ public class EnhancementAsProxyLazinessInterceptor extends AbstractLazyLoadInter
return EnhancementHelper.performWork( return EnhancementHelper.performWork(
this, this,
(session, isTempSession) -> { (session, isTempSession) -> {
final Object[] writtenValues; final Object[] writtenAttributeValues;
final AttributeMapping[] writtenAttributeMappings;
final EntityPersister entityPersister = final EntityPersister entityPersister =
session.getFactory().getMappingMetamodel() session.getFactory().getMappingMetamodel()
@ -125,16 +127,19 @@ public class EnhancementAsProxyLazinessInterceptor extends AbstractLazyLoadInter
// the force initialization below so that we can "replay" them after the // the force initialization below so that we can "replay" them after the
// initialization // initialization
writtenValues = new Object[writtenFieldNames.size()]; writtenAttributeValues = new Object[writtenFieldNames.size()];
writtenAttributeMappings = new AttributeMapping[writtenFieldNames.size()];
int index = 0; int index = 0;
for ( String writtenFieldName : writtenFieldNames ) { for ( String writtenFieldName : writtenFieldNames ) {
writtenValues[index] = entityPersister.getPropertyValue( target, writtenFieldName ); writtenAttributeMappings[index] = entityPersister.findAttributeMapping( writtenFieldName );
writtenAttributeValues[index] = writtenAttributeMappings[index].getValue( target );
index++; index++;
} }
} }
else { else {
writtenValues = null; writtenAttributeValues = null;
writtenAttributeMappings = null;
} }
final Object initializedValue = forceInitialize( final Object initializedValue = forceInitialize(
@ -146,19 +151,13 @@ public class EnhancementAsProxyLazinessInterceptor extends AbstractLazyLoadInter
setInitialized(); setInitialized();
if ( writtenValues != null ) { if ( writtenAttributeValues != null ) {
// here is the replaying of the explicitly set values we prepared above // here is the replaying of the explicitly set values we prepared above
for ( String writtenFieldName : writtenFieldNames ) { for ( int i = 0; i < writtenAttributeMappings.length; i++ ) {
final int size = entityPersister.getNumberOfAttributeMappings(); final AttributeMapping attribute = writtenAttributeMappings[i];
for ( int index = 0; index < size; index++ ) { attribute.setValue( target, writtenAttributeValues[i] );
final String name = entityPersister.getAttributeMapping( index ).getAttributeName(); if ( inLineDirtyChecking ) {
if ( writtenFieldName.contains( name ) ) { asSelfDirtinessTracker( target ).$$_hibernate_trackChange( attribute.getAttributeName() );
entityPersister.setValue(
target,
index,
writtenValues[index]
);
}
} }
} }
writtenFieldNames.clear(); writtenFieldNames.clear();