Hibernate
/
hibernate-orm
mirror of https://github.com/hibernate/hibernate-orm
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

HHH-16933 Stop using syntax sugar JSON item-methods

This commit is contained in:
Christian Beikov 2023-09-27 20:22:53 +02:00
parent 2751cdacb1
commit 875e0cac3c
1 changed files with 20 additions and 77 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

97
hibernate-core/src/main/java/org/hibernate/dialect/aggregate/OracleAggregateSupport.java
View File

@ -53,6 +53,9 @@ public class OracleAggregateSupport extends AggregateSupportImpl {
private static final AggregateSupport V12_INSTANCE = new OracleAggregateSupport( false, JsonSupport.QUERY ); private static final AggregateSupport V12_INSTANCE = new OracleAggregateSupport( false, JsonSupport.QUERY );
private static final AggregateSupport LEGACY_INSTANCE = new OracleAggregateSupport( false, JsonSupport.NONE ); private static final AggregateSupport LEGACY_INSTANCE = new OracleAggregateSupport( false, JsonSupport.NONE );
private static final String JSON_QUERY_START = "json_query(";
private static final String JSON_QUERY_END = "')";
private final boolean checkConstraintSupport; private final boolean checkConstraintSupport;
private final JsonSupport jsonSupport; private final JsonSupport jsonSupport;
@ -98,82 +101,22 @@ public class OracleAggregateSupport extends AggregateSupportImpl {
switch ( jsonSupport ) { switch ( jsonSupport ) {
case OSON: case OSON:
case MERGEPATCH: case MERGEPATCH:
switch ( columnType.getTypeCode() ) {
case BOOLEAN:
if ( columnType.getTypeName().toLowerCase( Locale.ROOT ).trim().startsWith( "number" ) ) {
return template.replace(
placeholder,
"decode(" + aggregateParentReadExpression + "." + column + ".boolean(),'true',1,'false',0,null)"
);
}
case TINYINT:
case SMALLINT:
case INTEGER:
case BIGINT:
return template.replace(
placeholder,
"" + aggregateParentReadExpression + "." + column + ".number()"
);
case DATE:
return template.replace(
placeholder,
aggregateParentReadExpression + "." + column + ".date()"
);
case TIME:
case TIME_WITH_TIMEZONE:
case TIME_UTC:
return template.replace(
placeholder,
"to_timestamp(" + aggregateParentReadExpression + "." + column + ".string(),'hh24:mi:ss')"
);
case TIMESTAMP:
return template.replace(
placeholder,
// Don't use .timestamp() directly because that is limited to precision 6
"to_timestamp(" + aggregateParentReadExpression + "." + column + ".string(),'YYYY-MM-DD\"T\"hh24:mi:ss.FF9')"
);
case TIMESTAMP_WITH_TIMEZONE:
case TIMESTAMP_UTC:
return template.replace(
placeholder,
// Don't use .timestamp() directly because that is limited to precision 6
"to_timestamp_tz(" + aggregateParentReadExpression + "." + column + ".string(),'YYYY-MM-DD\"T\"hh24:mi:ss.FF9TZH:TZM')"
);
case BINARY:
case VARBINARY:
case LONG32VARBINARY:
// We encode binary data as hex, so we have to decode here
return template.replace(
placeholder,
"hextoraw(" + aggregateParentReadExpression + "." + column + ".string())"
);
case CLOB:
case NCLOB:
case BLOB:
// We encode binary data as hex, so we have to decode here
return template.replace(
placeholder,
"(select * from json_table(" + aggregateParentReadExpression + ",'$' columns (" + column + " " + columnType.getTypeName() + " path '$." + column + "')))"
);
case JSON:
return template.replace(
placeholder,
aggregateParentReadExpression + "." + column
);
default:
return template.replace(
placeholder,
"cast(" + aggregateParentReadExpression + "." + column + ".string() as " + columnType.getTypeName() + ')'
);
}
case QUERY_AND_PATH: case QUERY_AND_PATH:
case QUERY: case QUERY:
final String parentPartExpression;
if ( aggregateParentReadExpression.startsWith( JSON_QUERY_START )
&& aggregateParentReadExpression.endsWith( JSON_QUERY_END ) ) {
parentPartExpression = aggregateParentReadExpression.substring( JSON_QUERY_START.length(), aggregateParentReadExpression.length() - JSON_QUERY_END.length() ) + ".";
}
else {
parentPartExpression = aggregateParentReadExpression + ",'$.";
}
switch ( columnType.getTypeCode() ) { switch ( columnType.getTypeCode() ) {
case BOOLEAN: case BOOLEAN:
if ( columnType.getTypeName().toLowerCase( Locale.ROOT ).trim().startsWith( "number" ) ) { if ( columnType.getTypeName().toLowerCase( Locale.ROOT ).trim().startsWith( "number" ) ) {
return template.replace( return template.replace(
placeholder, placeholder,
"decode(json_value(" + aggregateParentReadExpression + ",'$." + column + "'),'true',1,'false',0,null)" "decode(json_value(" + parentPartExpression + column + "'),'true',1,'false',0,null)"
); );
} }
case TINYINT: case TINYINT:
@ -182,28 +125,28 @@ public class OracleAggregateSupport extends AggregateSupportImpl {
case BIGINT: case BIGINT:
return template.replace( return template.replace(
placeholder, placeholder,
"json_value(" + aggregateParentReadExpression + ",'$." + column + "' returning " + columnType.getTypeName() + ')' "json_value(" + parentPartExpression + column + "' returning " + columnType.getTypeName() + ')'
); );
case DATE: case DATE:
return template.replace( return template.replace(
placeholder, placeholder,
"to_date(json_value(" + aggregateParentReadExpression + ",'$." + column + "'),'YYYY-MM-DD')" "to_date(json_value(" + parentPartExpression + column + "'),'YYYY-MM-DD')"
); );
case TIME: case TIME:
return template.replace( return template.replace(
placeholder, placeholder,
"to_timestamp(json_value(" + aggregateParentReadExpression + ",'$." + column + "'),'hh24:mi:ss')" "to_timestamp(json_value(" + parentPartExpression + column + "'),'hh24:mi:ss')"
); );
case TIMESTAMP: case TIMESTAMP:
return template.replace( return template.replace(
placeholder, placeholder,
"to_timestamp(json_value(" + aggregateParentReadExpression + ",'$." + column + "'),'YYYY-MM-DD\"T\"hh24:mi:ss.FF9')" "to_timestamp(json_value(" + parentPartExpression + column + "'),'YYYY-MM-DD\"T\"hh24:mi:ss.FF9')"
); );
case TIMESTAMP_WITH_TIMEZONE: case TIMESTAMP_WITH_TIMEZONE:
case TIMESTAMP_UTC: case TIMESTAMP_UTC:
return template.replace( return template.replace(
placeholder, placeholder,
"to_timestamp_tz(json_value(" + aggregateParentReadExpression + ",'$." + column + "'),'YYYY-MM-DD\"T\"hh24:mi:ss.FF9TZH:TZM')" "to_timestamp_tz(json_value(" + parentPartExpression + column + "'),'YYYY-MM-DD\"T\"hh24:mi:ss.FF9TZH:TZM')"
); );
case BINARY: case BINARY:
case VARBINARY: case VARBINARY:
@ -211,7 +154,7 @@ public class OracleAggregateSupport extends AggregateSupportImpl {
// We encode binary data as hex, so we have to decode here // We encode binary data as hex, so we have to decode here
return template.replace( return template.replace(
placeholder, placeholder,
"hextoraw(json_value(" + aggregateParentReadExpression + ",'$." + column + "'))" "hextoraw(json_value(" + parentPartExpression + column + "'))"
); );
case CLOB: case CLOB:
case NCLOB: case NCLOB:
@ -224,12 +167,12 @@ public class OracleAggregateSupport extends AggregateSupportImpl {
case JSON: case JSON:
return template.replace( return template.replace(
placeholder, placeholder,
"json_value(" + aggregateParentReadExpression + ",'$." + column + "')" "json_query(" + parentPartExpression + column + "')"
); );
default: default:
return template.replace( return template.replace(
placeholder, placeholder,
"cast(json_value(" + aggregateParentReadExpression + ",'$." + column + "') as " + columnType.getTypeName() + ')' "cast(json_value(" + parentPartExpression + column + "') as " + columnType.getTypeName() + ')'
); );
} }
case NONE: case NONE: