HHH-7498 some tests were targeting to the H2 only but now runs on db matrix

hibernate-core/src/test/java/org/hibernate/metamodel/source/annotations/entity/IdentifierGeneratorTest.java

@@ -43,6 +43,9 @@ import org.hibernate.metamodel.binding.EntityBinding;
 import org.hibernate.metamodel.binding.EntityIdentifier;
 import org.hibernate.metamodel.source.MappingException;
 import org.hibernate.service.ServiceRegistryBuilder;
+import org.hibernate.testing.DialectCheck;
+import org.hibernate.testing.DialectChecks;
+import org.hibernate.testing.RequiresDialectFeature;
 
 import static junit.framework.Assert.assertEquals;
 import static junit.framework.Assert.assertFalse;
@@ -53,6 +56,7 @@ import static junit.framework.Assert.fail;
 /**
  * @author Hardy Ferentschik
  */
+@RequiresDialectFeature( DialectChecks.SupportsSequences.class )
 public class IdentifierGeneratorTest extends BaseAnnotationBindingTestCase {
 	@Entity
 	class NoGenerationEntity {

hibernate-core/src/test/java/org/hibernate/test/annotations/embeddables/EmbeddableIntegratorTest.java

@@ -34,6 +34,7 @@ import java.util.List;
 import org.hibernate.Session;
 import org.hibernate.SessionFactory;
 import org.hibernate.cfg.Configuration;
+import org.hibernate.dialect.H2Dialect;
 import org.hibernate.exception.GenericJDBCException;
 import org.hibernate.integrator.internal.IntegratorServiceImpl;
 import org.hibernate.integrator.spi.Integrator;
@@ -43,12 +44,14 @@ import org.hibernate.service.ServiceRegistryBuilder;
 import org.hibernate.service.classloading.internal.ClassLoaderServiceImpl;
 import org.hibernate.service.classloading.spi.ClassLoaderService;
 import org.hibernate.service.internal.BootstrapServiceRegistryImpl;
+import org.hibernate.testing.RequiresDialect;
 import org.hibernate.testing.junit4.BaseUnitTestCase;
 import org.junit.Test;
 
 /**
  * @author Chris Pheby
  */
+@RequiresDialect(H2Dialect.class)
 public class EmbeddableIntegratorTest extends BaseUnitTestCase {
 
 	/**

hibernate-core/src/test/java/org/hibernate/test/annotations/filter/secondarytable/User.java

@@ -13,11 +13,11 @@ import org.hibernate.annotations.ParamDef;
 import org.hibernate.annotations.SqlFragmentAlias;
 
 @Entity
-@Table(name="USER")
+@Table(name="T_USER")
 @SecondaryTable(name="SECURITY_USER")
 @FilterDef(name="ageFilter", parameters=@ParamDef(name="age", type="integer"))
 @Filter(name="ageFilter", condition="{u}.AGE < :age AND {s}.LOCKED_OUT <> 1", 
-				aliases={@SqlFragmentAlias(alias="u", table="USER"), @SqlFragmentAlias(alias="s", table="SECURITY_USER")})
+				aliases={@SqlFragmentAlias(alias="u", table="T_USER"), @SqlFragmentAlias(alias="s", table="SECURITY_USER")})
 public class User {
 	
 	@Id
@@ -31,10 +31,10 @@ public class User {
 	@Column(name="AGE")
 	private int age;
 	
-	@Column(name="USERNAME", table="SECURITY_USER")
+	@Column(name="SECURITY_USERNAME", table="SECURITY_USER")
 	private String username;
 	
-	@Column(name="PASSWORD", table="SECURITY_USER")
+	@Column(name="SECURITY_PASSWORD", table="SECURITY_USER")
 	private String password;
 	
 	@Column(name="LOCKED_OUT", table="SECURITY_USER")

hibernate-core/src/test/java/org/hibernate/test/connections/AggressiveReleaseTest.java

@@ -14,9 +14,11 @@ import org.hibernate.ScrollableResults;
 import org.hibernate.Session;
 import org.hibernate.cfg.Configuration;
 import org.hibernate.cfg.Environment;
+import org.hibernate.dialect.H2Dialect;
 import org.hibernate.engine.transaction.internal.jta.CMTTransactionFactory;
 import org.hibernate.internal.util.SerializationHelper;
 import org.hibernate.service.jdbc.connections.spi.ConnectionProvider;
+import org.hibernate.testing.RequiresDialect;
 import org.hibernate.testing.jta.TestingJtaBootstrap;
 import org.hibernate.testing.jta.TestingJtaPlatformImpl;
 
@@ -29,6 +31,7 @@ import static org.junit.Assert.fail;
  *
  * @author Steve Ebersole
  */
+@RequiresDialect(H2Dialect.class)
 public class AggressiveReleaseTest extends ConnectionManagementTestCase {
 	@Override
 	public void configure(Configuration cfg) {

hibernate-core/src/test/java/org/hibernate/test/connections/BasicConnectionProviderTest.java

@@ -27,12 +27,15 @@ import org.hibernate.ConnectionReleaseMode;
 import org.hibernate.Session;
 import org.hibernate.cfg.Configuration;
 import org.hibernate.cfg.Environment;
+import org.hibernate.dialect.H2Dialect;
+import org.hibernate.testing.RequiresDialect;
 
 /**
  * Implementation of BasicConnectionProviderTest.
  *
  * @author Steve Ebersole
  */
+@RequiresDialect(H2Dialect.class)
 public class BasicConnectionProviderTest extends ConnectionManagementTestCase {
 	@Override
 	protected Session getSessionUnderTest() {

hibernate-core/src/test/java/org/hibernate/test/connections/ConnectionManagementTestCase.java

@@ -26,7 +26,9 @@ import org.junit.Test;
 
 import org.hibernate.Session;
 import org.hibernate.Transaction;
+import org.hibernate.dialect.H2Dialect;
 import org.hibernate.internal.util.SerializationHelper;
+import org.hibernate.testing.RequiresDialect;
 import org.hibernate.testing.junit4.BaseCoreFunctionalTestCase;
 
 import static org.junit.Assert.assertFalse;
@@ -45,6 +47,7 @@ import static org.junit.Assert.fail;
  *
  * @author Steve Ebersole
  */
+
 public abstract class ConnectionManagementTestCase extends BaseCoreFunctionalTestCase {
 	@Override
 	public final String[] getMappings() {

hibernate-core/src/test/java/org/hibernate/test/connections/CurrentSessionConnectionTest.java

@@ -24,12 +24,15 @@
 package org.hibernate.test.connections;
 
 import org.hibernate.Session;
+import org.hibernate.dialect.H2Dialect;
+import org.hibernate.testing.RequiresDialect;
 
 /**
  * Implementation of CurrentSessionConnectionTest.
  *
  * @author Steve Ebersole
  */
+@RequiresDialect(H2Dialect.class)
 public class CurrentSessionConnectionTest extends AggressiveReleaseTest {
 	@Override
 	protected Session getSessionUnderTest() throws Throwable {

hibernate-core/src/test/java/org/hibernate/test/connections/SuppliedConnectionTest.java

@@ -31,11 +31,13 @@ import org.hibernate.ConnectionReleaseMode;
 import org.hibernate.Session;
 import org.hibernate.cfg.Configuration;
 import org.hibernate.cfg.Environment;
+import org.hibernate.dialect.H2Dialect;
 import org.hibernate.service.jdbc.connections.internal.UserSuppliedConnectionProviderImpl;
 import org.hibernate.service.jdbc.connections.spi.ConnectionProvider;
 import org.hibernate.service.spi.Stoppable;
 import org.hibernate.testing.AfterClassOnce;
 import org.hibernate.testing.BeforeClassOnce;
+import org.hibernate.testing.RequiresDialect;
 import org.hibernate.testing.env.ConnectionProviderBuilder;
 import org.hibernate.tool.hbm2ddl.SchemaExport;
 
@@ -44,6 +46,7 @@ import org.hibernate.tool.hbm2ddl.SchemaExport;
  *
  * @author Steve Ebersole
  */
+@RequiresDialect(H2Dialect.class)
 public class SuppliedConnectionTest extends ConnectionManagementTestCase {
 	private ConnectionProvider cp = ConnectionProviderBuilder.buildConnectionProvider();
 	private Connection connectionUnderTest;

hibernate-core/src/test/java/org/hibernate/test/connections/ThreadLocalCurrentSessionTest.java

@@ -30,8 +30,10 @@ import org.hibernate.Session;
 import org.hibernate.cfg.Configuration;
 import org.hibernate.cfg.Environment;
 import org.hibernate.context.internal.ThreadLocalSessionContext;
+import org.hibernate.dialect.H2Dialect;
 import org.hibernate.engine.spi.SessionFactoryImplementor;
 import org.hibernate.engine.transaction.spi.LocalStatus;
+import org.hibernate.testing.RequiresDialect;
 
 import static org.junit.Assert.assertEquals;
 import static org.junit.Assert.assertFalse;
@@ -41,6 +43,7 @@ import static org.junit.Assert.fail;
 /**
  * @author Steve Ebersole
  */
+@RequiresDialect(H2Dialect.class)
 public class ThreadLocalCurrentSessionTest extends ConnectionManagementTestCase {
 	@Override
 	public void configure(Configuration cfg) {

hibernate-core/src/test/java/org/hibernate/test/fileimport/CommandExtractorServiceTest.java

@@ -25,7 +25,9 @@ package org.hibernate.test.fileimport;
 
 import org.hibernate.cfg.Configuration;
 import org.hibernate.cfg.Environment;
+import org.hibernate.dialect.H2Dialect;
 import org.hibernate.service.ServiceRegistryBuilder;
+import org.hibernate.testing.RequiresDialect;
 import org.hibernate.testing.TestForIssue;
 import org.hibernate.tool.hbm2ddl.ImportSqlCommandExtractor;
 import org.hibernate.tool.hbm2ddl.MultipleLinesSqlCommandExtractor;
@@ -34,6 +36,10 @@ import org.hibernate.tool.hbm2ddl.MultipleLinesSqlCommandExtractor;
  * @author Lukasz Antoniak (lukasz dot antoniak at gmail dot com)
  */
 @TestForIssue( jiraKey = "HHH-2403" )
+@RequiresDialect(value = H2Dialect.class,
+		jiraKey = "HHH-6286",
+		comment = "Only running the tests against H2, because the sql statements in the import file are not generic. " +
+				"This test should actually not test directly against the db")
 public class CommandExtractorServiceTest extends MultiLineImportFileTest {
 	@Override
 	public void configure(Configuration cfg) {

hibernate-core/src/test/java/org/hibernate/test/propertyref/DoesNotWorkTest.java

@@ -32,11 +32,14 @@ import org.hibernate.cfg.Configuration;
 
 import org.junit.Test;
 
+import org.hibernate.dialect.H2Dialect;
+import org.hibernate.testing.RequiresDialect;
 import org.hibernate.testing.junit4.BaseCoreFunctionalTestCase;
 
 /**
  * @author Steve Ebersole
  */
+@RequiresDialect(H2Dialect.class)
 public class DoesNotWorkTest extends BaseCoreFunctionalTestCase {
 	@Override
 	protected Class<?>[] getAnnotatedClasses() {

hibernate-core/src/test/java/org/hibernate/test/propertyref/DoesNotWorkWithHbmTest.java

@@ -31,6 +31,8 @@ import org.hibernate.cfg.Configuration;
 
 import org.junit.Test;
 
+import org.hibernate.dialect.H2Dialect;
+import org.hibernate.testing.RequiresDialect;
 import org.hibernate.testing.junit4.BaseCoreFunctionalTestCase;
 
 import static org.junit.Assert.assertEquals;
@@ -39,6 +41,7 @@ import static org.junit.Assert.assertNotNull;
 /**
  * @author Steve Ebersole
  */
+@RequiresDialect(H2Dialect.class)
 public class DoesNotWorkWithHbmTest extends BaseCoreFunctionalTestCase {
 
 	@Override

hibernate-core/src/test/java/org/hibernate/test/service/ServiceBootstrappingTest.java

@@ -35,6 +35,7 @@ import org.hibernate.service.internal.StandardServiceRegistryImpl;
 import org.hibernate.service.jdbc.connections.internal.DriverManagerConnectionProviderImpl;
 import org.hibernate.service.jdbc.connections.internal.UserSuppliedConnectionProviderImpl;
 import org.hibernate.service.jdbc.connections.spi.ConnectionProvider;
+import org.hibernate.testing.RequiresDialect;
 import org.hibernate.testing.env.ConnectionProviderBuilder;
 import org.hibernate.testing.junit4.BaseUnitTestCase;
 
@@ -44,6 +45,7 @@ import static org.junit.Assert.assertTrue;
 /**
  * @author Steve Ebersole
  */
+@RequiresDialect( H2Dialect.class )
 public class ServiceBootstrappingTest extends BaseUnitTestCase {
 	@Test
 	public void testBasicBuild() {

hibernate-entitymanager/src/test/java/org/hibernate/ejb/test/ejb3configuration/ProgrammaticConfTest.java

@@ -11,14 +11,17 @@ import org.junit.Assert;
 import org.junit.Test;
 
 import org.hibernate.cfg.Environment;
+import org.hibernate.dialect.H2Dialect;
 import org.hibernate.ejb.Ejb3Configuration;
 import org.hibernate.ejb.test.Cat;
 import org.hibernate.ejb.test.Kitten;
 import org.hibernate.internal.util.ConfigHelper;
+import org.hibernate.testing.RequiresDialect;
 
 /**
  * @author Emmanuel Bernard
  */
+@RequiresDialect(H2Dialect.class)
 public class ProgrammaticConfTest {
     @Test
 	public void testProgrammaticAPI() throws Exception {

hibernate-entitymanager/src/test/java/org/hibernate/ejb/test/packaging/JarVisitorTest.java

@@ -36,6 +36,7 @@ import javax.persistence.MappedSuperclass;
 
 import org.junit.Test;
 
+import org.hibernate.dialect.H2Dialect;
 import org.hibernate.ejb.packaging.ClassFilter;
 import org.hibernate.ejb.packaging.Entry;
 import org.hibernate.ejb.packaging.ExplodedJarVisitor;
@@ -49,6 +50,7 @@ import org.hibernate.ejb.packaging.JarVisitorFactory;
 import org.hibernate.ejb.packaging.PackageFilter;
 import org.hibernate.ejb.test.pack.defaultpar.ApplicationServer;
 import org.hibernate.ejb.test.pack.explodedpar.Carpet;
+import org.hibernate.testing.RequiresDialect;
 import org.hibernate.testing.TestForIssue;
 
 import static org.junit.Assert.assertEquals;
@@ -61,6 +63,7 @@ import static org.junit.Assert.assertTrue;
  * @author Hardy Ferentschik
  */
 @SuppressWarnings("unchecked")
+@RequiresDialect(H2Dialect.class)
 public class JarVisitorTest extends PackagingTestCase {
 	@Test
 	public void testHttp() throws Exception {

hibernate-entitymanager/src/test/java/org/hibernate/ejb/test/packaging/PackagedEntityManagerTest.java

@@ -34,6 +34,7 @@ import javax.persistence.PersistenceException;
 
 import org.junit.Test;
 
+import org.hibernate.dialect.H2Dialect;
 import org.hibernate.ejb.AvailableSettings;
 import org.hibernate.ejb.HibernateEntityManagerFactory;
 import org.hibernate.ejb.test.Distributor;
@@ -62,6 +63,7 @@ import org.hibernate.event.service.spi.EventListenerRegistry;
 import org.hibernate.event.spi.EventType;
 import org.hibernate.internal.util.ConfigHelper;
 import org.hibernate.stat.Statistics;
+import org.hibernate.testing.RequiresDialect;
 
 import static org.junit.Assert.assertEquals;
 import static org.junit.Assert.assertNotNull;
@@ -79,6 +81,7 @@ import static org.junit.Assert.fail;
  * @author Hardy Ferentschik
  */
 @SuppressWarnings("unchecked")
+@RequiresDialect(H2Dialect.class)
 public class PackagedEntityManagerTest extends PackagingTestCase {
 	@Test
 	public void testDefaultPar() throws Exception {

hibernate-entitymanager/src/test/java/org/hibernate/ejb/test/packaging/ScannerTest.java

@@ -36,11 +36,13 @@ import javax.persistence.Persistence;
 
 import org.junit.Test;
 
+import org.hibernate.dialect.H2Dialect;
 import org.hibernate.ejb.AvailableSettings;
 import org.hibernate.ejb.packaging.NamedInputStream;
 import org.hibernate.ejb.packaging.NativeScanner;
 import org.hibernate.ejb.packaging.Scanner;
 import org.hibernate.ejb.test.pack.defaultpar.ApplicationServer;
+import org.hibernate.testing.RequiresDialect;
 
 import static org.junit.Assert.assertEquals;
 import static org.junit.Assert.assertNotNull;
@@ -50,6 +52,7 @@ import static org.junit.Assert.assertTrue;
  * @author Emmanuel Bernard
  * @author Hardy Ferentschik
  */
+@RequiresDialect(H2Dialect.class)
 public class ScannerTest extends PackagingTestCase {
 	@Test
 	public void testNativeScanner() throws Exception {