Hibernate
/
hibernate-orm
mirror of https://github.com/hibernate/hibernate-orm
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

HHH-7869 bad performance problem with org.hibernate.internal.util.StringHelper#firstIndexOfChar

This commit is contained in:
Strong Liu 2012-12-17 14:08:51 +08:00
parent 941579da74
commit 8850c1fa91
2 changed files with 23 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
hibernate-core/src/main/java/org/hibernate/hql/internal/classic/ParserHelper.java
View File

@ -23,6 +23,7 @@
* *
*/ */
package org.hibernate.hql.internal.classic; package org.hibernate.hql.internal.classic;
import java.util.BitSet;
import java.util.StringTokenizer; import java.util.StringTokenizer;
import org.hibernate.QueryException; import org.hibernate.QueryException;
@ -33,6 +34,12 @@ public final class ParserHelper {
public static final String HQL_VARIABLE_PREFIX = ":"; public static final String HQL_VARIABLE_PREFIX = ":";
public static final String HQL_SEPARATORS = " \n\r\f\t,()=<>&|+-=/*'^![]#~\\"; public static final String HQL_SEPARATORS = " \n\r\f\t,()=<>&|+-=/*'^![]#~\\";
public static final BitSet HQL_SEPARATORS_BITSET = new BitSet( );
static {
for(int i=0;i<HQL_SEPARATORS.length();i++){
HQL_SEPARATORS_BITSET.set( HQL_SEPARATORS.charAt( i ) );
}
}
//NOTICE: no " or . since they are part of (compound) identifiers //NOTICE: no " or . since they are part of (compound) identifiers
public static final String PATH_SEPARATORS = "."; public static final String PATH_SEPARATORS = ".";

29
hibernate-core/src/main/java/org/hibernate/internal/util/StringHelper.java
View File

@ -27,6 +27,7 @@ package org.hibernate.internal.util;
import java.io.Serializable; import java.io.Serializable;
import java.util.ArrayList; import java.util.ArrayList;
import java.util.Arrays; import java.util.Arrays;
import java.util.BitSet;
import java.util.Iterator; import java.util.Iterator;
import java.util.StringTokenizer; import java.util.StringTokenizer;
import java.util.UUID; import java.util.UUID;
@ -472,21 +473,23 @@ public final class StringHelper {
} }
return qualified; return qualified;
} }
public static int firstIndexOfChar(String sqlString, BitSet keys, int startindex) {
public static int firstIndexOfChar(String sqlString, String string, int startindex) { for ( int i = startindex, size = sqlString.length(); i < size; i++ ) {
int matchAt = -1; if ( keys.get( sqlString.charAt( i ) ) ) {
for ( int i = 0; i < string.length(); i++ ) { return i;
int curMatch = sqlString.indexOf( string.charAt( i ), startindex );
if ( curMatch >= 0 ) {
if ( matchAt == -1 ) { // first time we find match!
matchAt = curMatch;
}
else {
matchAt = Math.min( matchAt, curMatch );
}
} }
} }
return matchAt; return -1;
}
public static int firstIndexOfChar(String sqlString, String string, int startindex) {
BitSet keys = new BitSet();
for ( int i = 0, size = string.length(); i < size; i++ ) {
keys.set( string.charAt( i ) );
}
return firstIndexOfChar( sqlString, keys, startindex );
} }
public static String truncate(String string, int length) { public static String truncate(String string, int length) {