Hibernate
/
hibernate-orm
mirror of https://github.com/hibernate/hibernate-orm
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

HHH-5427 - derby 10.6.1.0 native sequence support broken 

git-svn-id: https://svn.jboss.org/repos/hibernate/core/trunk@20268 1b8cb986-b30d-0410-93ca-fae66ebed9b2
This commit is contained in:
Steve Ebersole 2010-08-26 18:53:07 +00:00
parent 43122d96c3
commit 88ef160293
1 changed files with 25 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

40
core/src/main/java/org/hibernate/dialect/DerbyDialect.java
View File

@ -29,9 +29,9 @@ import java.lang.reflect.Method;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
import org.hibernate.MappingException;
import org.hibernate.dialect.function.AnsiTrimFunction;
import org.hibernate.dialect.function.DerbyConcatFunction;
import org.hibernate.id.TableHiLoGenerator;
import org.hibernate.sql.CaseFragment;
import org.hibernate.sql.DerbyCaseFragment;
import org.hibernate.util.ReflectHelper;
@ -57,7 +57,8 @@ public class DerbyDialect extends DB2Dialect {
determineDriverVersion();
}
/*package*/ void determineDriverVersion() {
@SuppressWarnings({ "UnnecessaryUnboxing" })
private void determineDriverVersion() {
try {
// locate the derby sysinfo class and query its version info
final Class sysinfoClass = ReflectHelper.classForName( "org.apache.derby.tools.sysinfo", this.getClass() );
@ -73,7 +74,7 @@ public class DerbyDialect extends DB2Dialect {
}
}
/*package*/ boolean isTenPointFiveReleaseOrNewer() {
private boolean isTenPointFiveReleaseOrNewer() {
return driverVersionMajor > 10 || ( driverVersionMajor == 10 && driverVersionMinor >= 5 );
}
@ -81,13 +82,6 @@ public class DerbyDialect extends DB2Dialect {
return ", ";
}
// /**
// * This is different in Cloudscape to DB2.
// */
// public String getIdentityColumnString() {
// return "not null generated always as identity"; //$NON-NLS-1
// }
/**
* Return the case statement modified for Cloudscape.
*/
@ -99,12 +93,28 @@ public class DerbyDialect extends DB2Dialect {
return true;
}
// public Class getNativeIdentifierGeneratorClass() {
// return TableHiLoGenerator.class;
// }
public boolean supportsSequences() {
return false;
// technically sequence support was added in 10.6.1.0...
//
// The problem though is that I am not exactly sure how to differentiate 10.6.1.0 from any other 10.6.x release.
//
// http://db.apache.org/derby/docs/10.0/publishedapi/org/apache/derby/tools/sysinfo.html seems incorrect. It
// states that derby's versioning scheme is major.minor.maintenance, but obviously 10.6.1.0 has 4 components
// to it, not 3.
//
// Let alone the fact that it states that versions with the matching major.minor are 'feature
// compatible' which is clearly not the case here (sequence support is a new feature...)
return driverVersionMajor > 10 || ( driverVersionMajor == 10 && driverVersionMinor >= 6 );
}
@Override
public String getSequenceNextValString(String sequenceName) {
if ( supportsSequences() ) {
return "values next value for " + sequenceName;
}
else {
throw new MappingException( "Derby does not support sequence prior to release 10.6.1.0" );
}
}
public boolean supportsLimit() {