Hibernate
/
hibernate-orm
mirror of https://github.com/hibernate/hibernate-orm
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

HHH-12710 - BaseCoreFunctionalTestCase opens an InputStream for mapping files but never closes it

This commit is contained in:
Vlad Mihalcea 2018-06-20 17:47:47 +03:00
parent ebca36a768
commit 8bbd22967e
2 changed files with 14 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
hibernate-core/src/test/java/org/hibernate/test/annotations/access/xml/XmlAccessTest.java
View File

@ -6,6 +6,7 @@
*/
package org.hibernate.test.annotations.access.xml;
import java.io.IOException;
import java.io.InputStream;
import java.util.ArrayList;
import java.util.Collections;
@ -164,8 +165,12 @@ public class XmlAccessTest extends BaseUnitTestCase {
cfg.addAnnotatedClass( clazz );
}
for ( String configFile : configFiles ) {
InputStream is = Thread.currentThread().getContextClassLoader().getResourceAsStream( configFile );
cfg.addInputStream( is );
try ( InputStream is = Thread.currentThread().getContextClassLoader().getResourceAsStream( configFile ) ) {
cfg.addInputStream( is );
}
catch (IOException e) {
throw new IllegalArgumentException( e );
}
}
return ( SessionFactoryImplementor ) cfg.buildSessionFactory();
}

9
hibernate-testing/src/main/java/org/hibernate/testing/junit4/BaseCoreFunctionalTestCase.java
View File

@ -6,6 +6,7 @@
*/
package org.hibernate.testing.junit4;
import java.io.IOException;
import java.io.InputStream;
import java.sql.Connection;
import java.sql.SQLException;
@ -204,8 +205,12 @@ public abstract class BaseCoreFunctionalTestCase extends BaseUnitTestCase {
String[] xmlFiles = getXmlFiles();
if ( xmlFiles != null ) {
for ( String xmlFile : xmlFiles ) {
InputStream is = Thread.currentThread().getContextClassLoader().getResourceAsStream( xmlFile );
configuration.addInputStream( is );
try ( InputStream is = Thread.currentThread().getContextClassLoader().getResourceAsStream( xmlFile ) ) {
configuration.addInputStream( is );
}
catch (IOException e) {
throw new IllegalArgumentException( e );
}
}
}
}