Hibernate
/
hibernate-orm
mirror of https://github.com/hibernate/hibernate-orm
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

HHH-2655: bug fix: row_number() function is not zero and so we must increament the given limit and offset by one

This commit is contained in:
Yoryos Valotasios 2010-10-30 00:00:48 +03:00
parent 895e1bf716
commit 9b32e9462a
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
hibernate-core/src/main/java/org/hibernate/dialect/SQLServer2008Dialect.java
View File

@ -85,7 +85,9 @@ public class SQLServer2008Dialect extends SQLServerDialect {
// Wrap the query within a with statement: // Wrap the query within a with statement:
sb.insert(0, "WITH query AS (").append(") SELECT * FROM query "); sb.insert(0, "WITH query AS (").append(") SELECT * FROM query ");
sb.append("WHERE __hibernate_row_nr__ "); sb.append("WHERE __hibernate_row_nr__ ");
if (offset > 0) sb.append("BETWEEN ").append(offset).append(" AND ").append(limit);
// The row_number() function is not zero based and so we must increment the offset and limit by one
if (offset > 0) sb.append("BETWEEN ").append(offset + 1).append(" AND ").append(limit + 1);
else sb.append(" <= ").append(limit); else sb.append(" <= ").append(limit);
// As mentioned before I don't think that we really need this last order by clause // As mentioned before I don't think that we really need this last order by clause