Hibernate
/
hibernate-orm
mirror of https://github.com/hibernate/hibernate-orm
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

HHH-18840 validate collection mapping annotations

This commit is contained in:
Gavin King 2024-11-11 23:40:39 +01:00
parent 192058f2f6
commit 9facfbf2e9
1 changed files with 41 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

57
hibernate-core/src/main/java/org/hibernate/boot/model/internal/CollectionBinder.java
View File

@ -1292,23 +1292,48 @@ public abstract class CollectionBinder {
} }
private void detectMappedByProblem(boolean isMappedBy) { private void detectMappedByProblem(boolean isMappedBy) {
if ( isMappedBy if ( isMappedBy ) {
&& ( property.hasDirectAnnotationUsage( JoinColumn.class ) if ( property.hasDirectAnnotationUsage( JoinColumn.class )
|| property.hasDirectAnnotationUsage( JoinColumns.class ) ) ) { || property.hasDirectAnnotationUsage( JoinColumns.class ) ) {
throw new AnnotationException( "Association '" throw new AnnotationException( "Association '"
+ qualify( propertyHolder.getPath(), propertyName ) + qualify( propertyHolder.getPath(), propertyName )
+ "' is 'mappedBy' another entity and may not specify the '@JoinColumn'" ); + "' is 'mappedBy' another entity and may not specify the '@JoinColumn'" );
}
if ( propertyHolder.getJoinTable( property ) != null ) {
throw new AnnotationException( "Association '"
+ qualify( propertyHolder.getPath(), propertyName )
+ "' is 'mappedBy' another entity and may not specify the '@JoinTable'" );
}
if ( oneToMany ) {
if ( property.hasDirectAnnotationUsage( MapKeyColumn.class ) ) {
LOG.warn( "Association '"
+ qualify( propertyHolder.getPath(), propertyName )
+ "' is 'mappedBy' another entity and should not specify a '@MapKeyColumn'"
+ " (use '@MapKey' instead)" );
}
if ( property.hasDirectAnnotationUsage( OrderColumn.class ) ) {
LOG.warn( "Association '"
+ qualify( propertyHolder.getPath(), propertyName )
+ "' is 'mappedBy' another entity and should not specify an '@OrderColumn'"
+ " (use '@OrderBy' instead)" );
}
}
else {
if ( property.hasDirectAnnotationUsage( MapKeyColumn.class ) ) {
throw new AnnotationException( "Association '"
+ qualify( propertyHolder.getPath(), propertyName )
+ "' is 'mappedBy' another entity and may not specify a '@MapKeyColumn'"
+ " (use '@MapKey' instead)" );
}
if ( property.hasDirectAnnotationUsage( OrderColumn.class ) ) {
throw new AnnotationException( "Association '"
+ qualify( propertyHolder.getPath(), propertyName )
+ "' is 'mappedBy' another entity and may not specify an '@OrderColumn'"
+ " (use '@OrderBy' instead)" );
}
}
} }
else if ( oneToMany
if ( isMappedBy
&& propertyHolder.getJoinTable( property ) != null ) {
throw new AnnotationException( "Association '"
+ qualify( propertyHolder.getPath(), propertyName )
+ "' is 'mappedBy' another entity and may not specify the '@JoinTable'" );
}
if ( !isMappedBy
&& oneToMany
&& property.hasDirectAnnotationUsage( OnDelete.class ) && property.hasDirectAnnotationUsage( OnDelete.class )
&& !property.hasDirectAnnotationUsage( JoinColumn.class ) && !property.hasDirectAnnotationUsage( JoinColumn.class )
&& !property.hasDirectAnnotationUsage( JoinColumns.class )) { && !property.hasDirectAnnotationUsage( JoinColumns.class )) {