Hibernate
/
hibernate-orm
mirror of https://github.com/hibernate/hibernate-orm
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

HHH-13453 Optimise CascadingActions for the most likely case

This commit is contained in:
Sanne Grinovero 2019-06-22 23:59:32 +01:00
parent 007ab2f479
commit a01929c5b8
1 changed files with 8 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
hibernate-core/src/main/java/org/hibernate/engine/spi/CascadingActions.java
View File

@ -369,21 +369,20 @@ public class CascadingActions {
int propertyIndex) { int propertyIndex) {
if ( propertyType.isEntityType() ) { if ( propertyType.isEntityType() ) {
Object child = persister.getPropertyValue( parent, propertyIndex ); Object child = persister.getPropertyValue( parent, propertyIndex );
String childEntityName = ((EntityType) propertyType).getAssociatedEntityName( session.getFactory() );
if ( child != null if ( child != null
&& !isInManagedState( child, session ) && !isInManagedState( child, session )
&& !(child instanceof HibernateProxy) //a proxy cannot be transient and it breaks ForeignKeys.isTransient && !(child instanceof HibernateProxy) ) { //a proxy cannot be transient and it breaks ForeignKeys.isTransient
&& ForeignKeys.isTransient( childEntityName, child, null, session ) ) { final String childEntityName = ((EntityType) propertyType).getAssociatedEntityName(session.getFactory());
String parentEntityName = persister.getEntityName(); if (ForeignKeys.isTransient(childEntityName, child, null, session)) {
String propertyName = persister.getPropertyNames()[propertyIndex]; String parentEntityName = persister.getEntityName();
throw new TransientPropertyValueException( String propertyName = persister.getPropertyNames()[propertyIndex];
throw new TransientPropertyValueException(
"object references an unsaved transient instance - save the transient instance before flushing", "object references an unsaved transient instance - save the transient instance before flushing",
childEntityName, childEntityName,
parentEntityName, parentEntityName,
propertyName propertyName
); );
}
} }
} }
} }