Hibernate
/
hibernate-orm
mirror of https://github.com/hibernate/hibernate-orm
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

HHH-13511 Remove interning of aliases in org.hibernate.loader.DefaultEntityAliases

This commit is contained in:
Sanne Grinovero 2019-07-25 10:00:21 +01:00
parent d7a0ffe519
commit a199f77b83
2 changed files with 1 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
hibernate-core/src/main/java/org/hibernate/loader/DefaultEntityAliases.java
View File

@ -68,9 +68,7 @@ public class DefaultEntityAliases implements EntityAliases {
else { else {
aliases = keyColumnsCandidates; aliases = keyColumnsCandidates;
} }
final String[] rtn = StringHelper.unquote( aliases, persister.getFactory().getDialect() ); return StringHelper.unquote( aliases, persister.getFactory().getDialect() );
intern( rtn );
return rtn;
} }
private String[][] determinePropertyAliases(Loadable persister) { private String[][] determinePropertyAliases(Loadable persister) {
@ -132,7 +130,6 @@ public class DefaultEntityAliases implements EntityAliases {
getPropertyAliases( persister, j ) getPropertyAliases( persister, j )
); );
suffixedPropertyAliases[j] = StringHelper.unquote( suffixedPropertyAliases[j], persister.getFactory().getDialect() ); suffixedPropertyAliases[j] = StringHelper.unquote( suffixedPropertyAliases[j], persister.getFactory().getDialect() );
intern( suffixedPropertyAliases[j] );
} }
} }
else { else {
@ -171,9 +168,4 @@ public class DefaultEntityAliases implements EntityAliases {
return suffix; return suffix;
} }
private static void intern(String[] strings) {
for ( int i = 0; i < strings.length; i++ ) {
strings[i] = strings[i].intern();
}
}
} }

2
hibernate-core/src/test/java/org/hibernate/test/annotations/query/QueryAndSQLTest.java
View File

@ -32,7 +32,6 @@ import org.hibernate.dialect.function.SQLFunction;
import org.hibernate.stat.Statistics; import org.hibernate.stat.Statistics;
import org.hibernate.type.StandardBasicTypes; import org.hibernate.type.StandardBasicTypes;
import org.hibernate.testing.FailureExpected;
import org.hibernate.testing.SkipForDialect; import org.hibernate.testing.SkipForDialect;
import org.hibernate.testing.TestForIssue; import org.hibernate.testing.TestForIssue;
import org.hibernate.testing.junit4.BaseCoreFunctionalTestCase; import org.hibernate.testing.junit4.BaseCoreFunctionalTestCase;
@ -95,7 +94,6 @@ public class QueryAndSQLTest extends BaseCoreFunctionalTestCase {
} }
@Test @Test
@FailureExpected(jiraKey = "HHH-2225")
public void testNativeQueryWithFormulaAttributeWithoutAlias() { public void testNativeQueryWithFormulaAttributeWithoutAlias() {
String sql = "select TABLE_NAME , sysdate() from all_tables where TABLE_NAME = 'AUDIT_ACTIONS' "; String sql = "select TABLE_NAME , sysdate() from all_tables where TABLE_NAME = 'AUDIT_ACTIONS' ";
Session s = openSession(); Session s = openSession();