diff --git a/hibernate-core/src/main/java/org/hibernate/cfg/JdbcSettings.java b/hibernate-core/src/main/java/org/hibernate/cfg/JdbcSettings.java index 8f0f628a9d..4aa64ef79a 100644 --- a/hibernate-core/src/main/java/org/hibernate/cfg/JdbcSettings.java +++ b/hibernate-core/src/main/java/org/hibernate/cfg/JdbcSettings.java @@ -526,8 +526,9 @@ public interface JdbcSettings extends C3p0Settings, ProxoolSettings, AgroalSetti /** * @see javax.sql.DataSource * - * @deprecated The JPA-standard {@link #JAKARTA_JTA_DATASOURCE} or {@link #JAKARTA_JTA_DATASOURCE} setting - * is now preferred. + * @deprecated The JPA-standard {@value #JAKARTA_JTA_DATASOURCE} or + * {@value #JAKARTA_NON_JTA_DATASOURCE} setting are now + * preferred. */ @Deprecated String DATASOURCE = "hibernate.connection.datasource"; diff --git a/hibernate-core/src/main/java/org/hibernate/engine/jdbc/connections/internal/DatasourceConnectionProviderImpl.java b/hibernate-core/src/main/java/org/hibernate/engine/jdbc/connections/internal/DatasourceConnectionProviderImpl.java index acbc35e6fd..6f34d0b703 100644 --- a/hibernate-core/src/main/java/org/hibernate/engine/jdbc/connections/internal/DatasourceConnectionProviderImpl.java +++ b/hibernate-core/src/main/java/org/hibernate/engine/jdbc/connections/internal/DatasourceConnectionProviderImpl.java @@ -12,7 +12,8 @@ import java.util.Map; import javax.sql.DataSource; import org.hibernate.HibernateException; -import org.hibernate.cfg.Environment; +import org.hibernate.cfg.AvailableSettings; +import org.hibernate.cfg.JdbcSettings; import org.hibernate.dialect.Dialect; import org.hibernate.engine.jdbc.connections.spi.ConnectionProvider; import org.hibernate.engine.jdbc.connections.spi.DatabaseConnectionInfo; @@ -22,13 +23,17 @@ import org.hibernate.service.spi.Configurable; import org.hibernate.service.spi.InjectService; import org.hibernate.service.spi.Stoppable; +import static org.hibernate.cfg.JdbcSettings.DATASOURCE; + /** * A {@link ConnectionProvider} that manages connections from an underlying {@link DataSource}. *

* The {@link DataSource} to use may be specified by either:

* * @author Gavin King @@ -83,7 +88,7 @@ public class DatasourceConnectionProviderImpl implements ConnectionProvider, Con @Override public void configure(Map configValues) { if ( dataSource == null ) { - final Object dataSourceSetting = configValues.get( Environment.DATASOURCE ); + final Object dataSourceSetting = configValues.get( DATASOURCE ); if ( dataSourceSetting instanceof DataSource ) { dataSource = (DataSource) dataSourceSetting; } @@ -91,7 +96,7 @@ public class DatasourceConnectionProviderImpl implements ConnectionProvider, Con final String dataSourceJndiName = (String) dataSourceSetting; if ( dataSourceJndiName == null ) { throw new HibernateException( - "DataSource to use was not injected nor specified by [" + Environment.DATASOURCE + "DataSource to use was not injected nor specified by [" + DATASOURCE + "] configuration property" ); } @@ -106,8 +111,8 @@ public class DatasourceConnectionProviderImpl implements ConnectionProvider, Con throw new HibernateException( "Unable to determine appropriate DataSource to use" ); } - user = (String) configValues.get( Environment.USER ); - pass = (String) configValues.get( Environment.PASS ); + user = (String) configValues.get( AvailableSettings.USER ); + pass = (String) configValues.get( AvailableSettings.PASS ); useCredentials = user != null || pass != null; available = true; } @@ -150,7 +155,7 @@ public class DatasourceConnectionProviderImpl implements ConnectionProvider, Con @Override public String toInfoString() { return dataSourceJndiName != null - ? "\tDatasource JND name [" + dataSourceJndiName + "]" + ? "\tDatasource JNDI name [" + dataSourceJndiName + "]" : "\tProvided DataSource"; } }; diff --git a/hibernate-core/src/main/java/org/hibernate/engine/jdbc/connections/spi/DataSourceBasedMultiTenantConnectionProviderImpl.java b/hibernate-core/src/main/java/org/hibernate/engine/jdbc/connections/spi/DataSourceBasedMultiTenantConnectionProviderImpl.java index 64b544b5ff..519b9b85e6 100644 --- a/hibernate-core/src/main/java/org/hibernate/engine/jdbc/connections/spi/DataSourceBasedMultiTenantConnectionProviderImpl.java +++ b/hibernate-core/src/main/java/org/hibernate/engine/jdbc/connections/spi/DataSourceBasedMultiTenantConnectionProviderImpl.java @@ -22,19 +22,20 @@ import org.hibernate.service.spi.ServiceRegistryAwareService; import org.hibernate.service.spi.ServiceRegistryImplementor; import org.hibernate.service.spi.Stoppable; +import static org.hibernate.cfg.JdbcSettings.DATASOURCE; import static org.hibernate.cfg.MultiTenancySettings.TENANT_IDENTIFIER_TO_USE_FOR_ANY_KEY; /** - * A concrete implementation of the {@link MultiTenantConnectionProvider} contract bases on a number of - * reasonable assumptions. We assume that: