Hibernate
/
hibernate-orm
mirror of https://github.com/hibernate/hibernate-orm
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

HHH-14387 Add more tests

This commit is contained in:
Andrea Boriero 2022-09-06 16:57:15 +02:00 committed by Andrea Boriero
parent 2cf9748430
commit ab15148a01
2 changed files with 367 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

224
hibernate-core/src/test/java/org/hibernate/orm/test/annotations/collectionelement/recreate/BytecodeEnhancementElementCollectionRecreateCollectionsInDefaultGroupTest.java Normal file
View File

@ -0,0 +1,224 @@
/*
* Hibernate, Relational Persistence for Idiomatic Java
*
* License: GNU Lesser General Public License (LGPL), version 2.1 or later.
* See the lgpl.txt file in the root directory or <http://www.gnu.org/licenses/lgpl-2.1.html>.
*/
package org.hibernate.orm.test.annotations.collectionelement.recreate;
import java.util.ArrayList;
import java.util.Arrays;
import java.util.List;
import org.hibernate.boot.SessionFactoryBuilder;
import org.hibernate.testing.TestForIssue;
import org.hibernate.testing.bytecode.enhancement.BytecodeEnhancerRunner;
import org.hibernate.testing.bytecode.enhancement.EnhancementOptions;
import org.hibernate.testing.junit4.BaseNonConfigCoreFunctionalTestCase;
import org.junit.After;
import org.junit.Before;
import org.junit.Test;
import org.junit.runner.RunWith;
import jakarta.persistence.ElementCollection;
import jakarta.persistence.Entity;
import jakarta.persistence.Id;
import jakarta.persistence.OrderColumn;
import static org.assertj.core.api.Assertions.assertThat;
import static org.junit.Assert.assertTrue;
@RunWith(BytecodeEnhancerRunner.class)
@EnhancementOptions(lazyLoading = true)
@TestForIssue(jiraKey = "HHH-14387")
public class BytecodeEnhancementElementCollectionRecreateCollectionsInDefaultGroupTest
extends BaseNonConfigCoreFunctionalTestCase {
@Override
protected Class[] getAnnotatedClasses() {
return new Class[] {
MyEntity.class
};
}
@Override
protected void configureSessionFactoryBuilder(SessionFactoryBuilder sfb) {
super.configureSessionFactoryBuilder( sfb );
sfb.applyCollectionsInDefaultFetchGroup( true );
}
@Before
public void check() {
inSession(
session ->
assertTrue( session.getSessionFactory().getSessionFactoryOptions()
.isCollectionsInDefaultFetchGroupEnabled() )
);
}
@After
public void tearDown() {
inTransaction(
session ->
session.createQuery( "delete from myentity" ).executeUpdate()
);
}
@Test
public void testRecreateCollection() {
inTransaction( session -> {
MyEntity entity = new MyEntity();
entity.setId( 1 );
entity.setElements( Arrays.asList( "one", "two", "four" ) );
session.persist( entity );
} );
inTransaction( session -> {
MyEntity entity = session.get( MyEntity.class, 1 );
entity.setElements( Arrays.asList( "two", "three" ) );
session.persist( entity );
} );
inTransaction( session -> {
MyEntity entity = session.get( MyEntity.class, 1 );
assertThat( entity.getElements() )
.containsExactlyInAnyOrder( "two", "three" );
} );
}
@Test
public void testRecreateCollectionFind() {
inTransaction( session -> {
MyEntity entity = new MyEntity();
entity.setId( 1 );
entity.setElements( Arrays.asList( "one", "two", "four" ) );
session.persist( entity );
} );
inTransaction( session -> {
MyEntity entity = session.find( MyEntity.class, 1 );
entity.setElements( Arrays.asList( "two", "three" ) );
session.persist( entity );
} );
inTransaction( session -> {
MyEntity entity = session.find( MyEntity.class, 1 );
assertThat( entity.getElements() )
.containsExactlyInAnyOrder( "two", "three" );
} );
}
@Test
public void testDeleteCollection() {
inTransaction( session -> {
MyEntity entity = new MyEntity();
entity.setId( 1 );
entity.setElements( Arrays.asList( "one", "two", "four" ) );
session.persist( entity );
} );
inTransaction( session -> {
MyEntity entity = session.get( MyEntity.class, 1 );
entity.setElements( new ArrayList<>() );
} );
inTransaction( session -> {
MyEntity entity = session.get( MyEntity.class, 1 );
assertThat( entity.getElements() )
.isEmpty();
} );
}
@Test
public void testDeleteCollectionFind() {
inTransaction( session -> {
MyEntity entity = new MyEntity();
entity.setId( 1 );
entity.setElements( Arrays.asList( "one", "two", "four" ) );
session.persist( entity );
} );
inTransaction( session -> {
MyEntity entity = session.find( MyEntity.class, 1 );
entity.setElements( new ArrayList<>() );
} );
inTransaction( session -> {
MyEntity entity = session.find( MyEntity.class, 1 );
assertThat( entity.getElements() )
.isEmpty();
} );
}
@Test
public void testLoadAndCommitTransactionDoesNotDeleteCollection() {
inTransaction( session -> {
MyEntity entity = new MyEntity();
entity.setId( 1 );
entity.setElements( Arrays.asList( "one", "two", "four" ) );
session.persist( entity );
} );
inTransaction( session ->
session.get( MyEntity.class, 1 )
);
inTransaction( session -> {
MyEntity entity = session.get( MyEntity.class, 1 );
assertThat( entity.getElements() )
.containsExactlyInAnyOrder( "one", "two", "four" );
} );
}
@Test
public void testLoadAndCommitTransactionDoesNotDeleteCollectionFind() {
inTransaction( session -> {
MyEntity entity = new MyEntity();
entity.setId( 1 );
entity.setElements( Arrays.asList( "one", "two", "four" ) );
session.persist( entity );
} );
inTransaction( session ->
session.find( MyEntity.class, 1 )
);
inTransaction( session -> {
MyEntity entity = session.find( MyEntity.class, 1 );
assertThat( entity.getElements() )
.containsExactlyInAnyOrder( "one", "two", "four" );
} );
}
@Entity(name = "myentity")
public static class MyEntity {
@Id
private Integer id;
@ElementCollection
@OrderColumn
private List<String> elements;
public Integer getId() {
return id;
}
public void setId(Integer id) {
this.id = id;
}
public List<String> getElements() {
return elements;
}
public void setElements(List<String> elements) {
this.elements = elements;
}
}
}

149
hibernate-core/src/test/java/org/hibernate/orm/test/annotations/collectionelement/recreate/BytecodeEnhancementElementCollectionRecreateTest.java
View File

@ -6,14 +6,18 @@
*/
package org.hibernate.orm.test.annotations.collectionelement.recreate;
import static org.assertj.core.api.Assertions.assertThat;
import java.util.ArrayList;
import java.util.Arrays;
import java.util.List;
import org.hibernate.boot.SessionFactoryBuilder;
import org.hibernate.testing.TestForIssue;
import org.hibernate.testing.bytecode.enhancement.BytecodeEnhancerRunner;
import org.hibernate.testing.bytecode.enhancement.EnhancementOptions;
import org.hibernate.testing.junit4.BaseCoreFunctionalTestCase;
import org.hibernate.testing.junit4.BaseNonConfigCoreFunctionalTestCase;
import org.junit.After;
import org.junit.Before;
import org.junit.Test;
import org.junit.runner.RunWith;
@ -22,9 +26,13 @@ import jakarta.persistence.Entity;
import jakarta.persistence.Id;
import jakarta.persistence.OrderColumn;
@RunWith(BytecodeEnhancerRunner.class) // Pointless here, but necessary to reproduce the problem.
import static org.assertj.core.api.Assertions.assertThat;
import static org.junit.Assert.assertFalse;
@RunWith(BytecodeEnhancerRunner.class)
@EnhancementOptions(lazyLoading = true)
public class BytecodeEnhancementElementCollectionRecreateTest extends BaseCoreFunctionalTestCase {
@TestForIssue(jiraKey = "HHH-14387")
public class BytecodeEnhancementElementCollectionRecreateTest extends BaseNonConfigCoreFunctionalTestCase {
@Override
protected Class[] getAnnotatedClasses() {
@ -33,12 +41,35 @@ public class BytecodeEnhancementElementCollectionRecreateTest extends BaseCoreFu
};
}
@Override
protected void configureSessionFactoryBuilder(SessionFactoryBuilder sfb) {
super.configureSessionFactoryBuilder( sfb );
sfb.applyCollectionsInDefaultFetchGroup( false );
}
@Before
public void check() {
inSession(
session ->
assertFalse( session.getSessionFactory().getSessionFactoryOptions()
.isCollectionsInDefaultFetchGroupEnabled() )
);
}
@After
public void tearDown() {
inTransaction(
session ->
session.createQuery( "delete from myentity" ).executeUpdate()
);
}
@Test
public void testRecreateCollection() {
inTransaction( session -> {
MyEntity entity = new MyEntity();
entity.setId( 1 );
entity.setElements( Arrays.asList( "one", "two" ) );
entity.setElements( Arrays.asList( "one", "two", "four" ) );
session.persist( entity );
} );
@ -55,6 +86,112 @@ public class BytecodeEnhancementElementCollectionRecreateTest extends BaseCoreFu
} );
}
@Test
public void testRecreateCollectionFind() {
inTransaction( session -> {
MyEntity entity = new MyEntity();
entity.setId( 1 );
entity.setElements( Arrays.asList( "one", "two", "four" ) );
session.persist( entity );
} );
inTransaction( session -> {
MyEntity entity = session.find( MyEntity.class, 1 );
entity.setElements( Arrays.asList( "two", "three" ) );
session.persist( entity );
} );
inTransaction( session -> {
MyEntity entity = session.find( MyEntity.class, 1 );
assertThat( entity.getElements() )
.containsExactlyInAnyOrder( "two", "three" );
} );
}
@Test
public void testDeleteCollection() {
inTransaction( session -> {
MyEntity entity = new MyEntity();
entity.setId( 1 );
entity.setElements( Arrays.asList( "one", "two", "four" ) );
session.persist( entity );
} );
inTransaction( session -> {
MyEntity entity = session.get( MyEntity.class, 1 );
entity.setElements( new ArrayList<>() );
} );
inTransaction( session -> {
MyEntity entity = session.get( MyEntity.class, 1 );
assertThat( entity.getElements() )
.isEmpty();
} );
}
@Test
public void testDeleteCollectionFind() {
inTransaction( session -> {
MyEntity entity = new MyEntity();
entity.setId( 1 );
entity.setElements( Arrays.asList( "one", "two", "four" ) );
session.persist( entity );
} );
inTransaction( session -> {
MyEntity entity = session.find( MyEntity.class, 1 );
entity.setElements( new ArrayList<>() );
} );
inTransaction( session -> {
MyEntity entity = session.find( MyEntity.class, 1 );
assertThat( entity.getElements() )
.isEmpty();
} );
}
@Test
public void testLoadAndCommitTransactionDoesNotDeleteCollection() {
inTransaction( session -> {
MyEntity entity = new MyEntity();
entity.setId( 1 );
entity.setElements( Arrays.asList( "one", "two", "four" ) );
session.persist( entity );
} );
inTransaction( session ->
session.get( MyEntity.class, 1 )
);
inTransaction( session -> {
MyEntity entity = session.get( MyEntity.class, 1 );
assertThat( entity.getElements() )
.containsExactlyInAnyOrder( "one", "two", "four" );
} );
}
@Test
public void testLoadAndCommitTransactionDoesNotDeleteCollectionFind() {
inTransaction( session -> {
MyEntity entity = new MyEntity();
entity.setId( 1 );
entity.setElements( Arrays.asList( "one", "two", "four" ) );
session.persist( entity );
} );
inTransaction( session ->
session.find( MyEntity.class, 1 )
);
inTransaction( session -> {
MyEntity entity = session.find( MyEntity.class, 1 );
assertThat( entity.getElements() )
.containsExactlyInAnyOrder( "one", "two", "four" );
} );
}
@Entity(name = "myentity")
public static class MyEntity {
@Id