Hibernate
/
hibernate-orm
mirror of https://github.com/hibernate/hibernate-orm
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

update wrong SkipForDialect

This commit is contained in:
bb7133 2021-10-18 22:29:13 +08:00 committed by Christian Beikov
parent 5bd27eb853
commit ae8bedfa6d
7 changed files with 15 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
hibernate-core/src/main/java/org/hibernate/dialect/sequence/TiDBSequenceSupport.java
View File

@ -24,7 +24,7 @@ public class TiDBSequenceSupport implements SequenceSupport {
@Override
public String getSelectSequencePreviousValString(String sequenceName) throws MappingException {
return "currval('" + sequenceName + "')";
return "lastval(" + sequenceName + ")";
}
@Override

4
hibernate-core/src/test/java/org/hibernate/orm/test/join/OuterJoinTest.java
View File

@ -12,7 +12,7 @@ import jakarta.persistence.Table;
import jakarta.persistence.Tuple;
import org.hibernate.dialect.TiDBDialect;
import org.hibernate.testing.SkipForDialect;
import org.hibernate.testing.orm.junit.SkipForDialect;
import org.hibernate.testing.orm.junit.EntityManagerFactoryScope;
import org.hibernate.testing.orm.junit.Jpa;
import org.junit.jupiter.api.AfterAll;
@ -226,7 +226,7 @@ public class OuterJoinTest {
}
@Test
@SkipForDialect(value = TiDBDialect.class, comment = "TiDB db does not support subqueries for ON condition")
@SkipForDialect(dialectClass = TiDBDialect.class, reason = "TiDB db does not support subqueries for ON condition")
public void testJoinOrderWithRightJoinWithInnerImplicitJoins(EntityManagerFactoryScope scope) {
scope.inTransaction( em -> {
List<Tuple> resultList = em.createQuery(

7
hibernate-core/src/test/java/org/hibernate/orm/test/jpa/exception/ExceptionTest.java
View File

@ -14,11 +14,11 @@ import jakarta.persistence.PersistenceException;
import org.hibernate.cfg.AvailableSettings;
import org.hibernate.dialect.TiDBDialect;
import org.hibernate.exception.ConstraintViolationException;
import org.hibernate.testing.SkipForDialect;
import org.hibernate.testing.TestForIssue;
import org.hibernate.testing.orm.junit.EntityManagerFactoryScope;
import org.hibernate.testing.orm.junit.Jpa;
import org.hibernate.testing.orm.junit.Setting;
import org.hibernate.testing.orm.junit.SkipForDialect;
import org.junit.jupiter.api.AfterEach;
import org.junit.jupiter.api.Test;
@ -118,10 +118,7 @@ public class ExceptionTest {
}
@Test
@SkipForDialect(
value = TiDBDialect.class,
comment = "TiDB do not support FK violation checking"
)
@SkipForDialect(dialectClass = TiDBDialect.class, reason = "TiDB do not support FK violation checking")
public void testConstraintViolationException(EntityManagerFactoryScope scope) {
scope.inEntityManager(
entityManager -> {

7
hibernate-core/src/test/java/org/hibernate/orm/test/manytomany/ManyToManyBidirectionalTest.java
View File

@ -18,10 +18,10 @@ import jakarta.persistence.ManyToMany;
import org.hibernate.annotations.NaturalId;
import org.hibernate.dialect.TiDBDialect;
import org.hibernate.testing.SkipForDialect;
import org.hibernate.testing.orm.junit.EntityManagerFactoryScope;
import org.hibernate.testing.orm.junit.FailureExpected;
import org.hibernate.testing.orm.junit.Jpa;
import org.hibernate.testing.orm.junit.SkipForDialect;
import org.junit.jupiter.api.AfterEach;
import org.junit.jupiter.api.Test;
@ -74,10 +74,7 @@ public class ManyToManyBidirectionalTest {
}
@Test
@SkipForDialect(
value = TiDBDialect.class,
comment = "TiDB do not support FK violation checking"
)
@SkipForDialect(dialectClass = TiDBDialect.class, reason = "TiDB do not support FK violation checking")
@FailureExpected(jiraKey = "HHH-12239")
public void testRemoveMappedBySide(EntityManagerFactoryScope scope) {
Address _address1 = scope.fromTransaction( entityManager -> {

2
hibernate-core/src/test/java/org/hibernate/orm/test/mapping/generated/ComplexValueGenerationTests.java
View File

@ -34,6 +34,7 @@ import org.hibernate.annotations.UpdateTimestamp;
import org.hibernate.dialect.MySQLDialect;
import org.hibernate.dialect.SybaseDialect;
import org.hibernate.dialect.TiDBDialect;
import org.hibernate.testing.orm.junit.DomainModel;
import org.hibernate.testing.orm.junit.SessionFactory;
import org.hibernate.testing.orm.junit.SessionFactoryScope;
@ -48,6 +49,7 @@ import static org.assertj.core.api.Assertions.assertThat;
*/
@SkipForDialect(dialectClass = SybaseDialect.class, matchSubTypes = true, reason = "CURRENT_TIMESTAMP not supported as default value in Sybase")
@SkipForDialect(dialectClass = MySQLDialect.class, reason = "See HHH-10196")
@SkipForDialect(dialectClass = TiDBDialect.class, reason = "See HHH-10196")
@DomainModel( annotatedClasses = ComplexValueGenerationTests.AuditedEntity.class )
@SessionFactory
public class ComplexValueGenerationTests {

2
hibernate-core/src/test/java/org/hibernate/orm/test/mapping/generated/DefaultGeneratedValueTest.java
View File

@ -34,6 +34,7 @@ import org.hibernate.annotations.GeneratorType;
import org.hibernate.annotations.UpdateTimestamp;
import org.hibernate.dialect.MySQLDialect;
import org.hibernate.dialect.SybaseDialect;
import org.hibernate.dialect.TiDBDialect;
import org.hibernate.tuple.ValueGenerator;
@ -60,6 +61,7 @@ import static org.junit.Assert.assertTrue;
*/
@SkipForDialect( dialectClass = SybaseDialect.class, matchSubTypes = true, reason = "CURRENT_TIMESTAMP not supported as default value in Sybase" )
@SkipForDialect( dialectClass = MySQLDialect.class, reason = "See HHH-10196" )
@SkipForDialect( dialectClass = TiDBDialect.class, reason = "See HHH-10196" )
@DomainModel( annotatedClasses = DefaultGeneratedValueTest.TheEntity.class )
@SessionFactory
public class DefaultGeneratedValueTest {

7
hibernate-core/src/test/java/org/hibernate/orm/test/procedure/MySQLStoredProcedureTest.java
View File

@ -18,15 +18,16 @@ import java.util.concurrent.atomic.AtomicReference;
import java.util.regex.Pattern;
import org.hibernate.Session;
import org.hibernate.dialect.MariaDBDialect;
import org.hibernate.dialect.MySQLDialect;
import org.hibernate.dialect.TiDBDialect;
import org.hibernate.procedure.ProcedureCall;
import org.hibernate.query.procedure.ProcedureParameter;
import org.hibernate.result.Output;
import org.hibernate.result.ResultSetOutput;
import org.hibernate.testing.orm.junit.SkipForDialect;
import org.hibernate.type.StandardBasicTypes;
import org.hibernate.testing.SkipForDialect;
import org.hibernate.testing.TestForIssue;
import org.hibernate.testing.orm.junit.EntityManagerFactoryScope;
import org.hibernate.testing.orm.junit.Jpa;
@ -50,8 +51,8 @@ import static org.junit.jupiter.api.Assertions.fail;
/**
* @author Vlad Mihalcea
*/
@RequiresDialect(value = MySQLDialect.class, version = 500)
@SkipForDialect(value = TiDBDialect.class, comment = "TiDB does not support stored procedure")
@RequiresDialect(value = MySQLDialect.class, matchSubTypes = false, version = 500)
@RequiresDialect(value = MariaDBDialect.class, version = 500)
@Jpa(
annotatedClasses = {
Person.class,