Hibernate/hibernate-orm
1
0
Fork 0
mirror of https://github.com/hibernate/hibernate-orm synced 2025-02-17 00:24:57 +00:00
Code Issues Packages Projects Releases Wiki Activity

HHH-8939 Reduce contention on initialization of ColumnNameCache instances by loaders

Browse Source
This commit is contained in:
Sanne Grinovero 2014-02-18 13:05:46 +00:00 committed by Brett Meyer
parent 949adc92c2
commit af5804a49c
1 changed files with 10 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
hibernate-core/src/main/java/org/hibernate/loader/Loader.java
View File

@ -2104,15 +2104,17 @@ private ResultSet wrapResultSetIfEnabled(final ResultSet rs, final SessionImplem
} }
private ColumnNameCache retreiveColumnNameToIndexCache(final ResultSet rs) throws SQLException { private ColumnNameCache retreiveColumnNameToIndexCache(final ResultSet rs) throws SQLException {
if ( columnNameCache == null ) { final ColumnNameCache cache = columnNameCache;
synchronized ( this ) { if ( cache == null ) {
if ( columnNameCache == null ) { //there is no need for a synchronized second check, as in worst case
LOG.trace( "Building columnName -> columnIndex cache" ); //we'll have allocated an unnecessary ColumnNameCache
columnNameCache = new ColumnNameCache( rs.getMetaData().getColumnCount() ); LOG.trace( "Building columnName -> columnIndex cache" );
} columnNameCache = new ColumnNameCache( rs.getMetaData().getColumnCount() );
} return columnNameCache;
}
else {
return cache;
} }
return columnNameCache;
} }
/** /**