HHH-7919 : Miscellaneous bugfixes

hibernate-core/src/main/java/org/hibernate/internal/TypeLocatorImpl.java

@@ -45,16 +45,12 @@ public class TypeLocatorImpl implements TypeHelper, Serializable {
 		this.typeResolver = typeResolver;
 	}
 
-	/**
+	@Override
-	 * {@inheritDoc}
-	 */
 	public BasicType basic(String name) {
 		return typeResolver.basic( name );
 	}
 
-	/**
+	@Override
-	 * {@inheritDoc}
-	 */
 	public BasicType basic(Class javaType) {
 		BasicType type = typeResolver.basic( javaType.getName() );
 		if ( type == null ) {
@@ -134,39 +130,27 @@ public class TypeLocatorImpl implements TypeHelper, Serializable {
 		return null;
 	}
 
-	/**
+	@Override
-	 * {@inheritDoc}
-	 */
 	public Type heuristicType(String name) {
 		return typeResolver.heuristicType( name );
 	}
 
-	/**
+	@Override
-	 * {@inheritDoc}
-	 */
 	public Type entity(Class entityClass) {
 		return entity( entityClass.getName() );
 	}
 
-	/**
+	@Override
-	 * {@inheritDoc}
-	 */
 	public Type entity(String entityName) {
 		return typeResolver.getTypeFactory().manyToOne( entityName );
 	}
 
-	/**
+	@Override
-	 * {@inheritDoc}
-	 */
-	@SuppressWarnings({ "unchecked" })
 	public Type custom(Class userTypeClass) {
 		return custom( userTypeClass, null );
 	}
 
-	/**
+	@Override
-	 * {@inheritDoc}
-	 */
-	@SuppressWarnings({ "unchecked" })
 	public Type custom(Class userTypeClass, Properties parameters) {
 		if ( CompositeUserType.class.isAssignableFrom( userTypeClass ) ) {
 			return typeResolver.getTypeFactory().customComponent( userTypeClass, parameters );
@@ -176,9 +160,7 @@ public class TypeLocatorImpl implements TypeHelper, Serializable {
 		}
 	}
 
-	/**
+	@Override
-	 * {@inheritDoc}
-	 */
 	public Type any(Type metaType, Type identifierType) {
 		return typeResolver.getTypeFactory().any( metaType, identifierType );
 	}

hibernate-core/src/main/java/org/hibernate/type/BasicTypeRegistry.java

@@ -44,7 +44,7 @@ public class BasicTypeRegistry implements Serializable {
     private static final CoreMessageLogger LOG = Logger.getMessageLogger(CoreMessageLogger.class, BasicTypeRegistry.class.getName());
 
 	// TODO : analyze these sizing params; unfortunately this seems to be the only way to give a "concurrencyLevel"
-	private Map<String,BasicType> registry = new ConcurrentHashMap<String, BasicType>( 100, .75f, 1 );
+	private final Map<String,BasicType> registry = new ConcurrentHashMap<String, BasicType>( 100, .75f, 1 );
 	private boolean locked = false;
 
 	public BasicTypeRegistry() {

hibernate-core/src/main/java/org/hibernate/type/TypeFactory.java

@@ -40,11 +40,8 @@ import org.hibernate.usertype.UserType;
 import org.jboss.logging.Logger;
 
 /**
- * Used internally to build instances of {@link Type}, specifically it builds instances of
+ * Used internally to obtain instances of {@link Type}. Applications should use static methods
- *
+ * and constants on {@link StandardBasicTypes}.
- *
- * Used internally to obtain instances of <tt>Type</tt>. Applications should use static methods
- * and constants on <tt>org.hibernate.Hibernate</tt>.
  *
  * @author Gavin King
  * @author Steve Ebersole

hibernate-testing/src/main/java/org/hibernate/testing/junit4/BaseCoreFunctionalTestCase.java

@@ -142,9 +142,7 @@ public abstract class BaseCoreFunctionalTestCase extends BaseFunctionalTestCase
 	}
 
 	protected void rebuildSessionFactory() {
-		if ( sessionFactory == null ) {
+		releaseSessionFactory();
-			return;
-		}
 		buildSessionFactory();
 	}