Hibernate
/
hibernate-orm
mirror of https://github.com/hibernate/hibernate-orm
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

HHH-10203 - Overriden UniqueDelegate.getTableCreationUniqueConstraintsFragment not called anymore in SchemaExport 

(cherry picked from commit 57c5d06f0e)
This commit is contained in:
Steve Ebersole 2015-10-26 21:07:08 -05:00
parent 6a09dea2e4
commit b261f356d0
3 changed files with 159 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

136
hibernate-core/src/test/java/org/hibernate/test/hbm/uk/UniqueDelegateTest.java Normal file
View File

@ -0,0 +1,136 @@
/*
* Hibernate, Relational Persistence for Idiomatic Java
*
* License: GNU Lesser General Public License (LGPL), version 2.1 or later.
* See the lgpl.txt file in the root directory or <http://www.gnu.org/licenses/lgpl-2.1.html>.
*/
package org.hibernate.test.hbm.uk;
import java.util.Collections;
import org.hibernate.boot.Metadata;
import org.hibernate.boot.MetadataSources;
import org.hibernate.boot.registry.StandardServiceRegistry;
import org.hibernate.boot.registry.StandardServiceRegistryBuilder;
import org.hibernate.cfg.AvailableSettings;
import org.hibernate.dialect.Dialect;
import org.hibernate.dialect.H2Dialect;
import org.hibernate.dialect.unique.DefaultUniqueDelegate;
import org.hibernate.dialect.unique.UniqueDelegate;
import org.hibernate.mapping.Column;
import org.hibernate.mapping.Table;
import org.hibernate.mapping.UniqueKey;
import org.hibernate.tool.schema.spi.SchemaCreator;
import org.hibernate.tool.schema.spi.SchemaDropper;
import org.hibernate.tool.schema.spi.SchemaManagementTool;
import org.hibernate.testing.TestForIssue;
import org.hibernate.testing.junit4.BaseUnitTestCase;
import org.hibernate.test.hbm.index.JournalingSchemaToolingTarget;
import org.junit.After;
import org.junit.Before;
import org.junit.Test;
import static org.hamcrest.CoreMatchers.equalTo;
import static org.junit.Assert.assertThat;
/**
* @author Steve Ebersole
*/
public class UniqueDelegateTest extends BaseUnitTestCase {
private static int getColumnDefinitionUniquenessFragmentCallCount = 0;
private static int getTableCreationUniqueConstraintsFragmentCallCount = 0;
private static int getAlterTableToAddUniqueKeyCommandCallCount = 0;
private static int getAlterTableToDropUniqueKeyCommandCallCount = 0;
private StandardServiceRegistry ssr;
@Before
public void before() {
ssr = new StandardServiceRegistryBuilder()
.applySetting( AvailableSettings.DIALECT, MyDialect.class )
.build();
}
@After
public void after() {
if ( ssr != null ) {
StandardServiceRegistryBuilder.destroy( ssr );
}
}
@Test
@TestForIssue( jiraKey = "HHH-10203" )
public void testUniqueDelegateConsulted() {
final Metadata metadata = new MetadataSources( ssr )
.addResource( "org/hibernate/test/hbm/uk/person_unique.hbm.xml" )
.buildMetadata();
final JournalingSchemaToolingTarget target = new JournalingSchemaToolingTarget();
final SchemaCreator schemaCreator = ssr.getService( SchemaManagementTool.class ).getSchemaCreator( Collections.emptyMap() );
schemaCreator.doCreation( metadata, false, target );
assertThat( getAlterTableToAddUniqueKeyCommandCallCount, equalTo( 1 ) );
assertThat( getColumnDefinitionUniquenessFragmentCallCount, equalTo( 1 ) );
assertThat( getTableCreationUniqueConstraintsFragmentCallCount, equalTo( 0 ) );
final SchemaDropper schemaDropper = ssr.getService( SchemaManagementTool.class ).getSchemaDropper( Collections.emptyMap() );
schemaDropper.doDrop( metadata, false, target );
// unique keys are not dropped explicitly
assertThat( getAlterTableToAddUniqueKeyCommandCallCount, equalTo( 1 ) );
assertThat( getColumnDefinitionUniquenessFragmentCallCount, equalTo( 1 ) );
assertThat( getTableCreationUniqueConstraintsFragmentCallCount, equalTo( 0 ) );
}
public static class MyDialect extends H2Dialect {
private MyUniqueDelegate myUniqueDelegate;
public MyDialect() {
this.myUniqueDelegate = new MyUniqueDelegate( this );
}
@Override
public UniqueDelegate getUniqueDelegate() {
return myUniqueDelegate;
}
}
public static class MyUniqueDelegate extends DefaultUniqueDelegate {
/**
* Constructs DefaultUniqueDelegate
*
* @param dialect The dialect for which we are handling unique constraints
*/
public MyUniqueDelegate(Dialect dialect) {
super( dialect );
}
@Override
public String getColumnDefinitionUniquenessFragment(Column column) {
getColumnDefinitionUniquenessFragmentCallCount++;
return super.getColumnDefinitionUniquenessFragment( column );
}
@Override
public String getTableCreationUniqueConstraintsFragment(Table table) {
getTableCreationUniqueConstraintsFragmentCallCount++;
return super.getTableCreationUniqueConstraintsFragment( table );
}
@Override
public String getAlterTableToAddUniqueKeyCommand(
UniqueKey uniqueKey, Metadata metadata) {
getAlterTableToAddUniqueKeyCommandCallCount++;
return super.getAlterTableToAddUniqueKeyCommand( uniqueKey, metadata );
}
@Override
public String getAlterTableToDropUniqueKeyCommand(
UniqueKey uniqueKey, Metadata metadata) {
getAlterTableToDropUniqueKeyCommandCallCount++;
return super.getAlterTableToDropUniqueKeyCommand( uniqueKey, metadata );
}
}
}

2
hibernate-core/src/test/resources/org/hibernate/test/hbm/fk/person_set.hbm.xml
View File

@ -9,7 +9,7 @@
"-//Hibernate/Hibernate Mapping DTD 3.0//EN"
"http://www.hibernate.org/dtd/hibernate-mapping-3.0.dtd">
<hibernate-mapping package="org.hibernate.hibernate5.constraintname">
<hibernate-mapping package="org.hibernate.test.hbm.index">
<class name="PersonGroup">
<id name="id" type="long">

22
hibernate-core/src/test/resources/org/hibernate/test/hbm/uk/person_unique.hbm.xml Normal file
View File

@ -0,0 +1,22 @@
<?xml version="1.0"?>
<!--
~ Hibernate, Relational Persistence for Idiomatic Java
~
~ License: GNU Lesser General Public License (LGPL), version 2.1 or later.
~ See the lgpl.txt file in the root directory or <http://www.gnu.org/licenses/lgpl-2.1.html>.
-->
<!DOCTYPE hibernate-mapping PUBLIC
"-//Hibernate/Hibernate Mapping DTD 3.0//EN"
"http://www.hibernate.org/dtd/hibernate-mapping-3.0.dtd">
<hibernate-mapping package="org.hibernate.test.hbm.index">
<class name="Person">
<id name="id" type="long">
<generator class="native" />
</id>
<property name="name" type="string" not-null="true" unique="true" />
</class>
</hibernate-mapping>