From b5de4cda156707c112afee4cb37257a8997776db Mon Sep 17 00:00:00 2001 From: Brett Meyer Date: Wed, 13 Feb 2013 22:30:38 -0500 Subject: [PATCH] HHH-7999 Oracle test failures due to lack of support for identity columns --- .../hibernate/test/jpa/naturalid/MutableNaturalIdTest.java | 4 ++++ .../collection/DetachedMultipleCollectionChangeTest.java | 4 ++++ .../modifiedflags/HasChangedDetachedMultipleCollection.java | 4 ++++ 3 files changed, 12 insertions(+) diff --git a/hibernate-core/src/test/java/org/hibernate/test/jpa/naturalid/MutableNaturalIdTest.java b/hibernate-core/src/test/java/org/hibernate/test/jpa/naturalid/MutableNaturalIdTest.java index 6fb4a3480e..02eab2c484 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/jpa/naturalid/MutableNaturalIdTest.java +++ b/hibernate-core/src/test/java/org/hibernate/test/jpa/naturalid/MutableNaturalIdTest.java @@ -27,13 +27,17 @@ import static org.junit.Assert.assertNotNull; import static org.junit.Assert.assertTrue; import org.hibernate.Session; +import org.hibernate.dialect.Oracle8iDialect; import org.hibernate.test.jpa.AbstractJPATest; +import org.hibernate.testing.SkipForDialect; import org.hibernate.testing.TestForIssue; import org.junit.Test; /** * @author Steve Ebersole */ +@SkipForDialect(value = Oracle8iDialect.class, + comment = "Oracle does not support identity key generation") public class MutableNaturalIdTest extends AbstractJPATest { @Override protected Class[] getAnnotatedClasses() { diff --git a/hibernate-envers/src/test/java/org/hibernate/envers/test/integration/collection/DetachedMultipleCollectionChangeTest.java b/hibernate-envers/src/test/java/org/hibernate/envers/test/integration/collection/DetachedMultipleCollectionChangeTest.java index 2b7e1045d7..1c0e524d28 100644 --- a/hibernate-envers/src/test/java/org/hibernate/envers/test/integration/collection/DetachedMultipleCollectionChangeTest.java +++ b/hibernate-envers/src/test/java/org/hibernate/envers/test/integration/collection/DetachedMultipleCollectionChangeTest.java @@ -11,6 +11,7 @@ import javax.transaction.TransactionManager; import org.junit.Test; +import org.hibernate.dialect.Oracle8iDialect; import org.hibernate.envers.RevisionType; import org.hibernate.envers.enhanced.SequenceIdRevisionEntity; import org.hibernate.envers.test.BaseEnversJPAFunctionalTestCase; @@ -18,6 +19,7 @@ import org.hibernate.envers.test.Priority; import org.hibernate.envers.test.entities.collection.MultipleCollectionEntity; import org.hibernate.envers.test.entities.collection.MultipleCollectionRefEntity1; import org.hibernate.envers.test.entities.collection.MultipleCollectionRefEntity2; +import org.hibernate.testing.SkipForDialect; import org.hibernate.testing.TestForIssue; import org.hibernate.testing.jta.TestingJtaBootstrap; import org.hibernate.testing.jta.TestingJtaPlatformImpl; @@ -32,6 +34,8 @@ import static org.junit.Assert.assertNotNull; * @author Erik-Berndt Scheper */ @TestForIssue(jiraKey = "HHH-6349") +@SkipForDialect(value = Oracle8iDialect.class, + comment = "Oracle does not support identity key generation") public class DetachedMultipleCollectionChangeTest extends BaseEnversJPAFunctionalTestCase { private TransactionManager tm = null; diff --git a/hibernate-envers/src/test/java/org/hibernate/envers/test/integration/modifiedflags/HasChangedDetachedMultipleCollection.java b/hibernate-envers/src/test/java/org/hibernate/envers/test/integration/modifiedflags/HasChangedDetachedMultipleCollection.java index 7be51fe5d3..05602fba00 100644 --- a/hibernate-envers/src/test/java/org/hibernate/envers/test/integration/modifiedflags/HasChangedDetachedMultipleCollection.java +++ b/hibernate-envers/src/test/java/org/hibernate/envers/test/integration/modifiedflags/HasChangedDetachedMultipleCollection.java @@ -6,10 +6,12 @@ import javax.persistence.EntityManager; import org.junit.Test; +import org.hibernate.dialect.Oracle8iDialect; import org.hibernate.envers.test.Priority; import org.hibernate.envers.test.entities.collection.MultipleCollectionEntity; import org.hibernate.envers.test.entities.collection.MultipleCollectionRefEntity1; import org.hibernate.envers.test.entities.collection.MultipleCollectionRefEntity2; +import org.hibernate.testing.SkipForDialect; import org.hibernate.testing.TestForIssue; import static org.junit.Assert.assertEquals; @@ -20,6 +22,8 @@ import static org.hibernate.envers.test.tools.TestTools.makeList; * @author Lukasz Antoniak (lukasz dot antoniak at gmail dot com) */ @TestForIssue(jiraKey = "HHH-7437") +@SkipForDialect(value = Oracle8iDialect.class, + comment = "Oracle does not support identity key generation") public class HasChangedDetachedMultipleCollection extends AbstractModifiedFlagsEntityTest { private Long mce1Id = null; private Long mce2Id = null;