From b5e3b59136eb62cc06d31cb159e3fc7908e88a7b Mon Sep 17 00:00:00 2001
From: Vlad Mihalcea <mihalcea.vlad@gmail.com>
Date: Tue, 23 Jan 2018 08:56:05 +0200
Subject: [PATCH] HHH-12239 - @ManyToMany throws a ConstraintViolationException
 when removing entity from the mapped-by (inverse) side

Add replicating test case
---
 .../ManyToManyBidirectionalTest.java          | 147 ++++++++++++++++++
 1 file changed, 147 insertions(+)
 create mode 100644 hibernate-core/src/test/java/org/hibernate/test/manytomany/ManyToManyBidirectionalTest.java

diff --git a/hibernate-core/src/test/java/org/hibernate/test/manytomany/ManyToManyBidirectionalTest.java b/hibernate-core/src/test/java/org/hibernate/test/manytomany/ManyToManyBidirectionalTest.java
new file mode 100644
index 0000000000..91011f4955
--- /dev/null
+++ b/hibernate-core/src/test/java/org/hibernate/test/manytomany/ManyToManyBidirectionalTest.java
@@ -0,0 +1,147 @@
+/*
+ * Hibernate, Relational Persistence for Idiomatic Java
+ *
+ * License: GNU Lesser General Public License (LGPL), version 2.1 or later.
+ * See the lgpl.txt file in the root directory or <http://www.gnu.org/licenses/lgpl-2.1.html>.
+ */
+package org.hibernate.test.manytomany;
+
+import java.util.ArrayList;
+import java.util.List;
+import java.util.Objects;
+import javax.persistence.CascadeType;
+import javax.persistence.Column;
+import javax.persistence.Entity;
+import javax.persistence.GeneratedValue;
+import javax.persistence.Id;
+import javax.persistence.ManyToMany;
+
+import org.hibernate.annotations.NaturalId;
+import org.hibernate.jpa.test.BaseEntityManagerFunctionalTestCase;
+
+import org.hibernate.testing.FailureExpected;
+import org.junit.Test;
+
+import static org.hibernate.testing.transaction.TransactionUtil.doInJPA;
+
+/**
+ * @author Vlad Mihalcea
+ */
+public class ManyToManyBidirectionalTest extends BaseEntityManagerFunctionalTestCase {
+
+	@Override
+	protected Class<?>[] getAnnotatedClasses() {
+		return new Class<?>[] {
+				Person.class,
+				Address.class,
+		};
+	}
+
+	@Test
+	public void testRemoveOwnerSide() {
+		Person _person1 = doInJPA( this::entityManagerFactory, entityManager -> {
+			Person person1 = new Person( "ABC-123" );
+			Person person2 = new Person( "DEF-456" );
+
+			Address address1 = new Address( "12th Avenue", "12A", "4005A" );
+			Address address2 = new Address( "18th Avenue", "18B", "4007B" );
+
+			person1.addAddress( address1 );
+			person1.addAddress( address2 );
+
+			person2.addAddress( address1 );
+
+			entityManager.persist( person1 );
+			entityManager.persist( person2 );
+
+			return person1;
+		} );
+
+		doInJPA( this::entityManagerFactory, entityManager -> {
+			Person person1 = entityManager.find( Person.class, _person1.id );
+
+			entityManager.remove( person1 );
+		} );
+	}
+
+	@Test
+	@FailureExpected( jiraKey = "HHH-12239")
+	public void testRemoveMappedBySide() {
+		Address _address1 = doInJPA( this::entityManagerFactory, entityManager -> {
+			Person person1 = new Person( "ABC-123" );
+			Person person2 = new Person( "DEF-456" );
+
+			Address address1 = new Address( "12th Avenue", "12A", "4005A" );
+			Address address2 = new Address( "18th Avenue", "18B", "4007B" );
+
+			person1.addAddress( address1 );
+			person1.addAddress( address2 );
+
+			person2.addAddress( address1 );
+
+			entityManager.persist( person1 );
+			entityManager.persist( person2 );
+
+			return address1;
+		} );
+
+		doInJPA( this::entityManagerFactory, entityManager -> {
+			Address address1 = entityManager.find( Address.class, _address1.id );
+
+			entityManager.remove( address1 );
+		} );
+	}
+
+	@Entity(name = "Person")
+	public static class Person {
+
+		@Id
+		@GeneratedValue
+		private Long id;
+
+		@NaturalId
+		private String registrationNumber;
+
+		@ManyToMany(cascade = {CascadeType.PERSIST, CascadeType.MERGE})
+		private List<Address> addresses = new ArrayList<>();
+
+		public Person() {
+		}
+
+		public Person(String registrationNumber) {
+			this.registrationNumber = registrationNumber;
+		}
+
+		public void addAddress(Address address) {
+			addresses.add( address );
+			address.owners.add( this );
+		}
+	}
+
+	@Entity(name = "Address")
+	public static class Address {
+
+		@Id
+		@GeneratedValue
+		private Long id;
+
+		private String street;
+
+		@Column(name = "`number`")
+		private String number;
+
+		private String postalCode;
+
+		@ManyToMany(mappedBy = "addresses")
+		private List<Person> owners = new ArrayList<>();
+
+		public Address() {
+		}
+
+		public Address(String street, String number, String postalCode) {
+			this.street = street;
+			this.number = number;
+			this.postalCode = postalCode;
+		}
+	}
+}