Hibernate
/
hibernate-orm
mirror of https://github.com/hibernate/hibernate-orm
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

HHH-13020 - When proxying an entity having a private default constructor, the log message is not very clear about the problem 

Fix test failing with Javassist
This commit is contained in:
Vlad Mihalcea 2018-10-10 20:41:26 +03:00
parent ceb83264fc
commit b6b9468fd0
1 changed files with 24 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

28
hibernate-core/src/test/java/org/hibernate/jpa/test/callbacks/PrivateConstructorTest.java
View File

@ -17,10 +17,13 @@ import javax.persistence.GenerationType;
import javax.persistence.Id;
import javax.persistence.ManyToOne;
import org.hibernate.cfg.AvailableSettings;
import org.hibernate.cfg.Environment;
import org.hibernate.internal.CoreMessageLogger;
import org.hibernate.internal.SessionImpl;
import org.hibernate.jpa.test.BaseEntityManagerFunctionalTestCase;
import org.hibernate.proxy.ProxyFactory;
import org.hibernate.proxy.pojo.bytebuddy.ByteBuddyProxyFactory;
import org.hibernate.proxy.pojo.javassist.JavassistProxyFactory;
import org.hibernate.testing.TestForIssue;
import org.hibernate.testing.logger.LoggerInspectionRule;
@ -34,11 +37,15 @@ import org.jboss.logging.Logger;
import static org.junit.Assert.assertEquals;
import static org.junit.Assert.assertTrue;
@TestForIssue( jiraKey = "HHH-13020" )
@TestForIssue(jiraKey = "HHH-13020")
public class PrivateConstructorTest extends BaseEntityManagerFunctionalTestCase {
@Rule
public LoggerInspectionRule logInspection = new LoggerInspectionRule( Logger.getMessageLogger( CoreMessageLogger.class, ByteBuddyProxyFactory.class.getName() ) );
public LoggerInspectionRule logInspection = new LoggerInspectionRule( Logger.getMessageLogger(
CoreMessageLogger.class,
proxyFactoryClass()
.getName()
) );
@Override
protected Class<?>[] getAnnotatedClasses() {
@ -74,7 +81,7 @@ public class PrivateConstructorTest extends BaseEntityManagerFunctionalTestCase
catch (Exception expected) {
assertEquals( NoSuchMethodException.class, ExceptionUtil.rootCause( expected ).getClass() );
assertTrue( expected.getMessage().contains(
"Bytecode enhancement failed because no public, protected or package-private default constructor was found for entity"
"Bytecode enhancement failed because no public, protected or package-private default constructor was found for entity"
) );
}
assertTrue( triggerable.wasTriggered() );
@ -92,6 +99,19 @@ public class PrivateConstructorTest extends BaseEntityManagerFunctionalTestCase
}
}
private static Class<? extends ProxyFactory> proxyFactoryClass() {
String byteCodeProvider = Environment.getProperties().getProperty( AvailableSettings.BYTECODE_PROVIDER );
if ( byteCodeProvider == null || Environment.BYTECODE_PROVIDER_NAME_BYTEBUDDY.equals( byteCodeProvider ) ) {
return ByteBuddyProxyFactory.class;
}
else if ( Environment.BYTECODE_PROVIDER_NAME_JAVASSIST.equals( byteCodeProvider ) ) {
return JavassistProxyFactory.class;
}
else {
throw new UnsupportedOperationException( "Unknown bytecode provider:" + byteCodeProvider );
}
}
@Entity(name = "Parent")
public static class Parent {