HHH-16616 Apply discriminator by pruning table group

Also, only apply the discriminator for loads since in queries the pruning is already handled by the entity name usage logic.
This commit is contained in:
Marco Belladelli 2023-08-02 15:31:36 +02:00
parent 9029d76604
commit b7ba6e731e
5 changed files with 23 additions and 8 deletions

View File

@ -299,12 +299,16 @@ protected void applyWhereFragments(
SqlAstCreationState astCreationState) {
super.applyWhereFragments( predicateConsumer, alias, tableGroup, astCreationState );
getElementPersisterInternal().applyDiscriminator(
predicateConsumer,
alias,
tableGroup,
astCreationState
);
if ( !astCreationState.supportsEntityNameUsage() ) {
// We only need to apply discriminator for loads, since queries with joined
// inheritance subtypes are already filtered by the entity name usage logic
getElementPersisterInternal().applyDiscriminator(
predicateConsumer,
alias,
tableGroup,
astCreationState
);
}
}
@Override

View File

@ -14,6 +14,7 @@
import java.util.Arrays;
import java.util.BitSet;
import java.util.Collection;
import java.util.Collections;
import java.util.HashMap;
import java.util.HashSet;
import java.util.IdentityHashMap;
@ -3104,7 +3105,7 @@ public void applyDiscriminator(
TableGroup tableGroup,
SqlAstCreationState creationState) {
if ( needsDiscriminator() ) {
predicateConsumer.accept( createDiscriminatorPredicate( alias, tableGroup, creationState ) );
pruneForSubclasses( tableGroup, Collections.singletonMap( getEntityName(), EntityNameUse.TREAT ) );
}
}

View File

@ -3046,6 +3046,11 @@ private void registerPathAttributeEntityNameUsage(SqmPath<?> sqmPath, TableGroup
}
}
@Override
public boolean supportsEntityNameUsage() {
return true;
}
@Override
public void registerEntityNameUsage(
TableGroup tableGroup,

View File

@ -42,4 +42,9 @@ default void registerEntityNameUsage(
String hibernateEntityName) {
// No-op
}
@Internal
default boolean supportsEntityNameUsage() {
return false;
}
}

View File

@ -72,7 +72,7 @@ public List<String> getAffectedTableNames() {
@Override
public boolean containsAffectedTableName(String requestedName) {
return isEmpty( requestedName ) || getTableExpression().equals( requestedName );
return isEmpty( requestedName ) || getTableExpression().contains( requestedName );
}
@Override