From bbfacee64de39c712c4ee09e67c60545403aa372 Mon Sep 17 00:00:00 2001 From: Steve Ebersole Date: Mon, 18 May 2015 01:48:38 -0500 Subject: [PATCH] HHH-9803 - Checkstyle fix ups --- .../main/java/org/hibernate/Interceptor.java | 49 +- .../main/java/org/hibernate/Transaction.java | 24 +- .../org/hibernate/boot/SchemaAutoTooling.java | 23 +- .../scan/internal/ScanResultCollector.java | 1 - .../internal/MetadataBuildingProcess.java | 1 - .../boot/jaxb/hbm/spi/EntityInfo.java | 54 +- .../jaxb/hbm/spi/PluralAttributeInfo.java | 72 +- .../boot/jaxb/hbm/spi/SubEntityInfo.java | 2 +- .../hibernate/boot/model/TypeDefinition.java | 8 +- .../hbm/AbstractEntitySourceImpl.java | 4 +- .../hbm/ColumnAttributeSourceImpl.java | 10 +- .../source/internal/hbm/ColumnSourceImpl.java | 10 +- .../model/source/internal/hbm/Helper.java | 2 +- .../hbm/SubclassEntitySourceImpl.java | 2 +- .../source/spi/CompositeIdentifierSource.java | 4 +- .../source/spi/VersionAttributeSource.java | 4 +- .../dialect/AbstractHANADialect.java | 4 +- .../org/hibernate/dialect/CUBRIDDialect.java | 1 - .../hibernate/dialect/InformixDialect.java | 1 - .../org/hibernate/dialect/MySQLDialect.java | 1 - .../hibernate/dialect/Oracle12cDialect.java | 54 +- .../dialect/PostgreSQL81Dialect.java | 1 - .../org/hibernate/dialect/SAPDBDialect.java | 1 - .../dialect/SQLServer2005Dialect.java | 12 +- .../dialect/SQLServer2012Dialect.java | 31 +- .../hibernate/dialect/Teradata14Dialect.java | 37 +- .../hibernate/dialect/TeradataDialect.java | 2 +- .../hibernate/dialect/TimesTenDialect.java | 1 - .../jdbc/batch/internal/BatchingBatch.java | 2 +- .../DriverManagerConnectionProviderImpl.java | 2 + .../ExtractedDatabaseMetaDataImpl.java | 2 - .../jdbc/internal/ResultSetReturnImpl.java | 42 +- .../engine/jdbc/spi/SqlExceptionHelper.java | 24 +- .../query/spi/EntityGraphQueryHint.java | 3 +- .../engine/query/spi/QueryPlanCache.java | 3 +- .../org/hibernate/engine/spi/ActionQueue.java | 15 +- .../org/hibernate/engine/spi/EntityEntry.java | 1 - .../engine/spi/SessionImplementor.java | 2 - .../engine/transaction/spi/LocalStatus.java | 52 - .../AbstractFlushingEventListener.java | 4 +- .../event/internal/EvictVisitor.java | 2 - .../event/spi/EntityCopyObserver.java | 2 - .../hql/internal/HolderInstantiator.java | 10 +- .../QueryTranslatorFactoryInitiator.java | 4 - .../hql/internal/ast/tree/FromClause.java | 1 - .../hql/internal/ast/tree/FromElement.java | 29 +- .../hql/internal/ast/tree/IdentNode.java | 4 +- .../hql/internal/ast/tree/IntoClause.java | 30 +- .../internal/ast/tree/JavaConstantNode.java | 1 - .../hibernate/hql/internal/ast/tree/Node.java | 8 +- .../hql/internal/ast/tree/OrderByClause.java | 3 +- .../ast/tree/ResultVariableRefNode.java | 5 +- .../internal/ast/tree/UpdateStatement.java | 20 +- .../ClassicQueryTranslatorFactory.java | 24 +- .../hql/internal/classic/FromParser.java | 39 +- .../internal/classic/PreprocessingParser.java | 17 +- .../internal/classic/QueryTranslatorImpl.java | 246 ++--- .../hql/internal/classic/SelectParser.java | 4 +- .../hql/internal/classic/WhereParser.java | 6 +- .../hibernate/hql/spi/QueryTranslator.java | 12 +- .../AbstractMultiTableBulkIdStrategyImpl.java | 2 - .../hibernate/hql/spi/id/IdTableSupport.java | 10 +- .../java/org/hibernate/id/GUIDGenerator.java | 10 +- .../id/IdentifierGeneratorHelper.java | 60 +- .../org/hibernate/id/IdentityGenerator.java | 31 +- .../org/hibernate/id/IncrementGenerator.java | 17 +- .../id/MultipleHiLoPerTableGenerator.java | 76 +- .../id/PersistentIdentifierGenerator.java | 43 +- .../id/PostInsertIdentifierGenerator.java | 6 +- .../org/hibernate/id/SelectGenerator.java | 30 +- .../org/hibernate/id/SequenceGenerator.java | 2 +- .../id/SequenceIdentityGenerator.java | 20 +- .../java/org/hibernate/id/UUIDGenerator.java | 9 +- .../org/hibernate/id/UUIDHexGenerator.java | 9 +- .../DefaultIdentifierGeneratorFactory.java | 2 +- .../id/insert/AbstractReturningDelegate.java | 19 +- .../id/insert/AbstractSelectingDelegate.java | 32 +- .../hibernate/internal/AbstractQueryImpl.java | 275 +++--- .../internal/AbstractScrollableResults.java | 98 +- .../internal/AbstractSessionImpl.java | 5 +- .../org/hibernate/internal/CacheImpl.java | 44 +- .../internal/CollectionFilterImpl.java | 39 +- .../hibernate/internal/CoreMessageLogger.java | 323 ++++--- .../org/hibernate/internal/CriteriaImpl.java | 3 +- .../internal/DynamicFilterAliasGenerator.java | 13 +- .../FetchingScrollableResultsImpl.java | 44 +- .../internal/FilterConfiguration.java | 49 +- .../org/hibernate/internal/FilterHelper.java | 39 +- .../org/hibernate/internal/IteratorImpl.java | 61 +- .../org/hibernate/internal/QueryImpl.java | 45 +- .../org/hibernate/internal/SQLQueryImpl.java | 84 +- .../internal/ScrollableResultsImpl.java | 94 +- .../internal/SessionFactoryImpl.java | 14 +- .../internal/SessionFactoryRegistry.java | 18 +- .../org/hibernate/internal/SessionImpl.java | 335 ++++--- .../internal/StatelessSessionImpl.java | 123 +-- .../hibernate/internal/util/BytesHelper.java | 2 +- .../hibernate/internal/util/Cloneable.java | 72 +- .../hibernate/internal/util/ConfigHelper.java | 83 +- .../internal/util/EntityPrinter.java | 49 +- .../internal/util/LockModeConverter.java | 2 +- .../hibernate/internal/util/MarkerObject.java | 7 +- .../internal/util/SerializationHelper.java | 36 +- .../hibernate/internal/util/StringHelper.java | 145 +-- .../beans/BeanIntrospectionException.java | 3 +- .../util/collections/ArrayHelper.java | 142 +-- .../collections/BoundedConcurrentHashMap.java | 904 +++++++++--------- .../util/collections/CollectionHelper.java | 56 +- .../ConcurrentReferenceHashMap.java | 122 +-- .../util/collections/IdentityMap.java | 2 +- .../java/org/hibernate/jdbc/Expectations.java | 36 +- .../main/java/org/hibernate/jdbc/Work.java | 9 +- .../jmx/internal/JmxServiceImpl.java | 5 +- .../loader/AbstractEntityJoinWalker.java | 5 +- .../loader/GeneratedCollectionAliases.java | 41 +- .../java/org/hibernate/loader/JoinWalker.java | 334 +++---- .../java/org/hibernate/loader/Loader.java | 31 +- .../org/hibernate/loader/OuterJoinLoader.java | 9 +- .../loader/OuterJoinableAssociation.java | 61 +- .../collection/OneToManyJoinWalker.java | 87 +- .../loader/criteria/CriteriaInfoProvider.java | 12 +- .../loader/criteria/CriteriaJoinWalker.java | 59 +- .../loader/criteria/CriteriaLoader.java | 119 ++- .../criteria/CriteriaQueryTranslator.java | 111 ++- .../loader/custom/CollectionFetchReturn.java | 4 +- .../loader/custom/CollectionReturn.java | 6 +- .../custom/ColumnCollectionAliases.java | 36 +- .../hibernate/loader/custom/CustomLoader.java | 108 ++- .../loader/custom/sql/SQLQueryParser.java | 8 +- .../custom/sql/SQLQueryReturnProcessor.java | 2 +- .../loader/entity/AbstractEntityLoader.java | 13 +- .../entity/CascadeEntityJoinWalker.java | 25 +- .../entity/CollectionElementLoader.java | 49 +- .../hibernate/loader/entity/EntityLoader.java | 4 +- .../org/hibernate/loader/hql/QueryLoader.java | 100 +- ...AbstractEntityGraphVisitationStrategy.java | 5 +- ...BuildingAssociationVisitationStrategy.java | 5 +- .../plan/build/internal/LoadPlanImpl.java | 12 +- .../internal/spaces/QuerySpaceHelper.java | 29 +- .../internal/spaces/QuerySpacesImpl.java | 1 - .../spi/ExpandingCollectionQuerySpace.java | 14 +- .../plan/build/spi/ExpandingQuerySpaces.java | 36 +- .../internal/AbstractLoadQueryDetails.java | 13 +- .../ThreadLocalCurrentSessionTest.java | 1 - .../config/checkstyle/checkstyle-eventual.xml | 257 ----- shared/config/checkstyle/checkstyle.xml | 8 + shared/config/checkstyle/todo-checks.xml | 15 - 147 files changed, 3216 insertions(+), 3198 deletions(-) delete mode 100644 hibernate-core/src/main/java/org/hibernate/engine/transaction/spi/LocalStatus.java delete mode 100644 shared/config/checkstyle/checkstyle-eventual.xml delete mode 100644 shared/config/checkstyle/todo-checks.xml diff --git a/hibernate-core/src/main/java/org/hibernate/Interceptor.java b/hibernate-core/src/main/java/org/hibernate/Interceptor.java index 864fb91e5c..8a227bd2ed 100644 --- a/hibernate-core/src/main/java/org/hibernate/Interceptor.java +++ b/hibernate-core/src/main/java/org/hibernate/Interceptor.java @@ -26,7 +26,6 @@ package org.hibernate; import java.io.Serializable; import java.util.Iterator; -import org.hibernate.resource.jdbc.spi.StatementInspector; import org.hibernate.type.Type; /** @@ -71,7 +70,7 @@ public interface Interceptor { * * @throws CallbackException Thrown if the interceptor encounters any problems handling the callback. */ - public boolean onLoad(Object entity, Serializable id, Object[] state, String[] propertyNames, Type[] types) throws CallbackException; + boolean onLoad(Object entity, Serializable id, Object[] state, String[] propertyNames, Type[] types) throws CallbackException; /** * Called when an object is detected to be dirty, during a flush. The interceptor may modify the detected @@ -94,7 +93,13 @@ public interface Interceptor { * * @throws CallbackException Thrown if the interceptor encounters any problems handling the callback. */ - public boolean onFlushDirty(Object entity, Serializable id, Object[] currentState, Object[] previousState, String[] propertyNames, Type[] types) throws CallbackException; + boolean onFlushDirty( + Object entity, + Serializable id, + Object[] currentState, + Object[] previousState, + String[] propertyNames, + Type[] types) throws CallbackException; /** * Called before an object is saved. The interceptor may modify the state, which will be used for @@ -110,7 +115,7 @@ public interface Interceptor { * * @throws CallbackException Thrown if the interceptor encounters any problems handling the callback. */ - public boolean onSave(Object entity, Serializable id, Object[] state, String[] propertyNames, Type[] types) throws CallbackException; + boolean onSave(Object entity, Serializable id, Object[] state, String[] propertyNames, Type[] types) throws CallbackException; /** * Called before an object is deleted. It is not recommended that the interceptor modify the state. @@ -123,7 +128,7 @@ public interface Interceptor { * * @throws CallbackException Thrown if the interceptor encounters any problems handling the callback. */ - public void onDelete(Object entity, Serializable id, Object[] state, String[] propertyNames, Type[] types) throws CallbackException; + void onDelete(Object entity, Serializable id, Object[] state, String[] propertyNames, Type[] types) throws CallbackException; /** * Called before a collection is (re)created. @@ -133,7 +138,7 @@ public interface Interceptor { * * @throws CallbackException Thrown if the interceptor encounters any problems handling the callback. */ - public void onCollectionRecreate(Object collection, Serializable key) throws CallbackException; + void onCollectionRecreate(Object collection, Serializable key) throws CallbackException; /** * Called before a collection is deleted. @@ -143,7 +148,7 @@ public interface Interceptor { * * @throws CallbackException Thrown if the interceptor encounters any problems handling the callback. */ - public void onCollectionRemove(Object collection, Serializable key) throws CallbackException; + void onCollectionRemove(Object collection, Serializable key) throws CallbackException; /** * Called before a collection is updated. @@ -153,7 +158,7 @@ public interface Interceptor { * * @throws CallbackException Thrown if the interceptor encounters any problems handling the callback. */ - public void onCollectionUpdate(Object collection, Serializable key) throws CallbackException; + void onCollectionUpdate(Object collection, Serializable key) throws CallbackException; /** * Called before a flush. @@ -162,7 +167,7 @@ public interface Interceptor { * * @throws CallbackException Thrown if the interceptor encounters any problems handling the callback. */ - public void preFlush(Iterator entities) throws CallbackException; + void preFlush(Iterator entities) throws CallbackException; /** * Called after a flush that actually ends in execution of the SQL statements required to synchronize @@ -172,7 +177,7 @@ public interface Interceptor { * * @throws CallbackException Thrown if the interceptor encounters any problems handling the callback. */ - public void postFlush(Iterator entities) throws CallbackException; + void postFlush(Iterator entities) throws CallbackException; /** * Called to distinguish between transient and detached entities. The return value determines the @@ -186,7 +191,7 @@ public interface Interceptor { * @param entity a transient or detached entity * @return Boolean or null to choose default behaviour */ - public Boolean isTransient(Object entity); + Boolean isTransient(Object entity); /** * Called from flush(). The return value determines whether the entity is updated @@ -207,7 +212,13 @@ public interface Interceptor { * * @throws CallbackException Thrown if the interceptor encounters any problems handling the callback. */ - public int[] findDirty(Object entity, Serializable id, Object[] currentState, Object[] previousState, String[] propertyNames, Type[] types); + int[] findDirty( + Object entity, + Serializable id, + Object[] currentState, + Object[] previousState, + String[] propertyNames, + Type[] types); /** * Instantiate the entity class. Return null to indicate that Hibernate should use * the default constructor of the class. The identifier property of the returned instance @@ -221,7 +232,7 @@ public interface Interceptor { * * @throws CallbackException Thrown if the interceptor encounters any problems handling the callback. */ - public Object instantiate(String entityName, EntityMode entityMode, Serializable id) throws CallbackException; + Object instantiate(String entityName, EntityMode entityMode, Serializable id) throws CallbackException; /** * Get the entity name for a persistent or transient instance. @@ -232,7 +243,7 @@ public interface Interceptor { * * @throws CallbackException Thrown if the interceptor encounters any problems handling the callback. */ - public String getEntityName(Object object) throws CallbackException; + String getEntityName(Object object) throws CallbackException; /** * Get a fully loaded entity instance that is cached externally. @@ -244,7 +255,7 @@ public interface Interceptor { * * @throws CallbackException Thrown if the interceptor encounters any problems handling the callback. */ - public Object getEntity(String entityName, Serializable id) throws CallbackException; + Object getEntity(String entityName, Serializable id) throws CallbackException; /** * Called when a Hibernate transaction is begun via the Hibernate Transaction @@ -253,21 +264,21 @@ public interface Interceptor { * * @param tx The Hibernate transaction facade object */ - public void afterTransactionBegin(Transaction tx); + void afterTransactionBegin(Transaction tx); /** * Called before a transaction is committed (but not before rollback). * * @param tx The Hibernate transaction facade object */ - public void beforeTransactionCompletion(Transaction tx); + void beforeTransactionCompletion(Transaction tx); /** * Called after a transaction is committed or rolled back. * * @param tx The Hibernate transaction facade object */ - public void afterTransactionCompletion(Transaction tx); + void afterTransactionCompletion(Transaction tx); /** * Called when sql string is being prepared. @@ -278,5 +289,5 @@ public interface Interceptor { * to inspect and alter SQL statements. */ @Deprecated - public String onPrepareStatement(String sql); + String onPrepareStatement(String sql); } diff --git a/hibernate-core/src/main/java/org/hibernate/Transaction.java b/hibernate-core/src/main/java/org/hibernate/Transaction.java index c01a80b9b4..a072189682 100644 --- a/hibernate-core/src/main/java/org/hibernate/Transaction.java +++ b/hibernate-core/src/main/java/org/hibernate/Transaction.java @@ -25,8 +25,6 @@ package org.hibernate; import javax.transaction.Synchronization; -import org.hibernate.engine.transaction.spi.IsolationDelegate; -import org.hibernate.engine.transaction.spi.LocalStatus; import org.hibernate.resource.transaction.spi.TransactionStatus; /** @@ -53,16 +51,16 @@ public interface Transaction { * * @throws HibernateException Indicates a problem beginning the transaction. */ - public void begin(); + void begin(); /** * Commit this transaction. This might entail a number of things depending on the context: