Hibernate
/
hibernate-orm
mirror of https://github.com/hibernate/hibernate-orm
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

HHH-13599 Avoid ArrayList allocation in JtaTransactionCoordinatorImp in common scenario

This commit is contained in:
Sanne Grinovero 2019-08-27 18:11:13 +01:00
parent 5c95096e7c
commit bcbfea7724
1 changed files with 15 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
hibernate-core/src/main/java/org/hibernate/resource/transaction/backend/jta/internal/JtaTransactionCoordinatorImpl.java
View File

@ -62,7 +62,7 @@ public class JtaTransactionCoordinatorImpl implements TransactionCoordinator, Sy
private int timeOut = -1; private int timeOut = -1;
private final transient List<TransactionObserver> observers; private transient List<TransactionObserver> observers = null;
/** /**
* Construct a JtaTransactionCoordinatorImpl instance. package-protected to ensure access goes through * Construct a JtaTransactionCoordinatorImpl instance. package-protected to ensure access goes through
@ -79,8 +79,6 @@ public class JtaTransactionCoordinatorImpl implements TransactionCoordinator, Sy
this.transactionCoordinatorOwner = owner; this.transactionCoordinatorOwner = owner;
this.autoJoinTransactions = autoJoinTransactions; this.autoJoinTransactions = autoJoinTransactions;
this.observers = new ArrayList<>();
final JdbcSessionContext jdbcSessionContext = owner.getJdbcSessionOwner().getJdbcSessionContext(); final JdbcSessionContext jdbcSessionContext = owner.getJdbcSessionOwner().getJdbcSessionContext();
this.jtaPlatform = jdbcSessionContext.getServiceRegistry().getService( JtaPlatform.class ); this.jtaPlatform = jdbcSessionContext.getServiceRegistry().getService( JtaPlatform.class );
@ -109,9 +107,8 @@ public class JtaTransactionCoordinatorImpl implements TransactionCoordinator, Sy
this.preferUserTransactions = preferUserTransactions; this.preferUserTransactions = preferUserTransactions;
this.performJtaThreadTracking = performJtaThreadTracking; this.performJtaThreadTracking = performJtaThreadTracking;
this.observers = new ArrayList<>();
if ( observers != null ) { if ( observers != null ) {
this.observers = new ArrayList<>( observers.length );
Collections.addAll( this.observers, observers ); Collections.addAll( this.observers, observers );
} }
@ -123,11 +120,17 @@ public class JtaTransactionCoordinatorImpl implements TransactionCoordinator, Sy
/** /**
* Needed because while iterating the observers list and executing the before/update callbacks, * Needed because while iterating the observers list and executing the before/update callbacks,
* some observers might get removed from the list. * some observers might get removed from the list.
* Yet try to not allocate anything for when the list is empty, as this is a common case.
* *
* @return TransactionObserver * @return TransactionObserver
*/ */
private Iterable<TransactionObserver> observers() { private Iterable<TransactionObserver> observers() {
return new ArrayList<>( observers ); if ( this.observers == null ) {
return Collections.EMPTY_LIST;
}
else {
return new ArrayList<>( this.observers );
}
} }
public SynchronizationCallbackCoordinator getSynchronizationCallbackCoordinator() { public SynchronizationCallbackCoordinator getSynchronizationCallbackCoordinator() {
@ -388,12 +391,17 @@ public class JtaTransactionCoordinatorImpl implements TransactionCoordinator, Sy
} }
public void addObserver(TransactionObserver observer) { public void addObserver(TransactionObserver observer) {
if ( this.observers == null ) {
this.observers = new ArrayList<>( 3 ); //These lists are typically very small.
}
observers.add( observer ); observers.add( observer );
} }
@Override @Override
public void removeObserver(TransactionObserver observer) { public void removeObserver(TransactionObserver observer) {
observers.remove( observer ); if ( observers != null ) {
observers.remove( observer );
}
} }
/** /**