HHH-16699 promote repeat() function

emulate it on Oracle using rpad()

unsupported on Derby

hibernate-core/src/main/java/org/hibernate/dialect/OracleDialect.java

@@ -265,6 +265,7 @@ public class OracleDialect extends Dialect {
 		functionFactory.addMonths();
 		functionFactory.monthsBetween();
 		functionFactory.everyAny_minMaxCase();
+		functionFactory.repeat_rpad();
 
 		functionFactory.radians_acos();
 		functionFactory.degrees_acos();

hibernate-core/src/main/java/org/hibernate/dialect/function/CommonFunctionFactory.java

@@ -710,6 +710,15 @@ public class CommonFunctionFactory {
 				.register();
 	}
 
+	public void repeat_rpad() {
+		functionRegistry.patternDescriptorBuilder( "repeat", "rpad(?1,?2*length(?1),?1)" )
+				.setInvariantType(stringType)
+				.setExactArgumentCount( 2 )
+				.setParameterTypes(STRING, INTEGER)
+				.setArgumentListSignature( "(STRING string, INTEGER times)" )
+				.register();
+	}
+
 	public void leftRight() {
 		functionRegistry.namedDescriptorBuilder( "left" )
 				.setInvariantType(stringType)

hibernate-core/src/test/java/org/hibernate/orm/test/query/hql/FunctionTests.java

@@ -709,6 +709,27 @@ public class FunctionTests {
 		);
 	}
 
+	@Test
+	@RequiresDialectFeature(feature = DialectFeatureChecks.SupportsRepeat.class)
+	public void testRepeatFunction(SessionFactoryScope scope) {
+		scope.inTransaction(
+				session -> {
+					assertThat( session.createQuery("select repeat('hello', 3)", String.class).getSingleResult(),
+							is("hellohellohello") );
+					assertThat( session.createQuery("select repeat(?1, 3)", String.class)
+									.setParameter(1, "hello")
+									.getSingleResult(),
+							is("hellohellohello") );
+					//HSQLDB doesn't like the second parameter
+//					assertThat( session.createQuery("select repeat(?1, ?2)", String.class)
+//									.setParameter(1, "hello")
+//									.setParameter(2, 3)
+//									.getSingleResult(),
+//							is("hellohellohello") );
+				}
+		);
+	}
+
 	@Test
 	@RequiresDialectFeature(feature = DialectFeatureChecks.SupportsReplace.class)
 	public void testReplaceFunction(SessionFactoryScope scope) {
@@ -716,8 +737,10 @@ public class FunctionTests {
 				session -> {
 					session.createQuery("select replace(e.theString, 'hello', 'goodbye') from EntityOfBasics e", String.class)
 							.list();
-					assertThat( session.createQuery("select replace('hello world', 'hello', 'goodbye')", String.class).getSingleResult(), is("goodbye world") );
+					assertThat( session.createQuery("select replace('hello world', 'hello', 'goodbye')", String.class).getSingleResult(),
-					assertThat( session.createQuery("select replace('hello world', 'o', 'ooo')", String.class).getSingleResult(), is("hellooo wooorld") );
+							is("goodbye world") );
+					assertThat( session.createQuery("select replace('hello world', 'o', 'ooo')", String.class).getSingleResult(),
+							is("hellooo wooorld") );
 				}
 		);
 

hibernate-testing/src/main/java/org/hibernate/testing/orm/junit/DialectFeatureChecks.java

@@ -318,6 +318,14 @@ abstract public class DialectFeatureChecks {
 		}
 	}
 
+	public static class SupportsRepeat implements DialectFeatureCheck {
+		public boolean apply(Dialect dialect) {
+			dialect = DialectDelegateWrapper.extractRealDialect( dialect );
+			// Derby doesn't support the `REPLACE` function
+			return !( dialect instanceof DerbyDialect );
+		}
+	}
+
 	public static class SupportsTemporaryTable implements DialectFeatureCheck {
 		public boolean apply(Dialect dialect) {
 			return dialect.supportsTemporaryTables();