From c624048635184e5979e753062e849b1d5647a652 Mon Sep 17 00:00:00 2001 From: Christian Beikov Date: Tue, 9 Apr 2024 12:31:56 +0200 Subject: [PATCH] HHH-17947 Add additional test for unique key loading --- .../test/flush/AutoFlushBeforeLoadTest.java | 228 ++++++++++++++++++ .../orm/test/flush/HHH10445Test.java | 141 ----------- 2 files changed, 228 insertions(+), 141 deletions(-) create mode 100644 hibernate-core/src/test/java/org/hibernate/orm/test/flush/AutoFlushBeforeLoadTest.java delete mode 100644 hibernate-core/src/test/java/org/hibernate/orm/test/flush/HHH10445Test.java diff --git a/hibernate-core/src/test/java/org/hibernate/orm/test/flush/AutoFlushBeforeLoadTest.java b/hibernate-core/src/test/java/org/hibernate/orm/test/flush/AutoFlushBeforeLoadTest.java new file mode 100644 index 0000000000..9ea0ee51d5 --- /dev/null +++ b/hibernate-core/src/test/java/org/hibernate/orm/test/flush/AutoFlushBeforeLoadTest.java @@ -0,0 +1,228 @@ +/* + * Hibernate, Relational Persistence for Idiomatic Java + * + * License: GNU Lesser General Public License (LGPL), version 2.1 or later + * See the lgpl.txt file in the root directory or http://www.gnu.org/licenses/lgpl-2.1.html + */ +package org.hibernate.orm.test.flush; + +import java.util.ArrayList; +import java.util.List; + +import org.hibernate.annotations.NaturalId; + +import org.hibernate.testing.bytecode.enhancement.BytecodeEnhancerRunner; +import org.hibernate.testing.bytecode.enhancement.EnhancementOptions; +import org.hibernate.testing.junit4.BaseCoreFunctionalTestCase; +import org.hibernate.testing.orm.junit.JiraKey; + +import org.junit.After; +import org.junit.Before; +import org.junit.Test; +import org.junit.runner.RunWith; + +import jakarta.persistence.CascadeType; +import jakarta.persistence.Column; +import jakarta.persistence.Entity; +import jakarta.persistence.FetchType; +import jakarta.persistence.GeneratedValue; +import jakarta.persistence.Id; +import jakarta.persistence.JoinColumn; +import jakarta.persistence.ManyToOne; +import jakarta.persistence.OneToMany; +import jakarta.persistence.OneToOne; + +import static org.junit.jupiter.api.Assertions.assertEquals; + +/** + * @author Jan Schatteman + */ +@RunWith(BytecodeEnhancerRunner.class) +@EnhancementOptions(biDirectionalAssociationManagement = true) +@JiraKey(value = "HHH-17947") +public class AutoFlushBeforeLoadTest extends BaseCoreFunctionalTestCase { + + @Override + protected Class[] getAnnotatedClasses() { + return new Class[] { + Person.class, + Phone.class, + DriversLicense.class + }; + } + + @Before + public void setupData() { + inTransaction( + session -> { + Person p = new Person( 1L, "John Doe" ); + session.persist( p ); + } + ); + } + + @After + public void tearDown() { + inTransaction( + session -> { + session.createMutationQuery( "delete from DriversLicense" ).executeUpdate(); + session.createMutationQuery( "delete from Phone" ).executeUpdate(); + session.createMutationQuery( "delete from Person" ).executeUpdate(); + } + ); + } + + @Test + public void testCollectionInitialization() { + inTransaction( + session -> { + Phone phone = new Phone( session.getReference( Person.class, 1L ), "1234567890" ); + session.persist( phone ); + Person person = session.createQuery( "select p from Person p", Person.class ).getSingleResult(); + assertEquals( 1, person.getPhones().size() ); + } + ); + } + + @Test + public void testOneToOneInitialization() { + inTransaction( + session -> { + DriversLicense driversLicense = new DriversLicense( 1L, session.getReference( Person.class, 1L ), "999" ); + session.persist( driversLicense ); + Person person = session.createQuery( "select p from Person p", Person.class ).getSingleResult(); + assertEquals( driversLicense, person.getDriversLicense() ); + session.clear(); + } + ); + } + + @Entity(name = "Person") + public static class Person { + + @Id + private Long id; + + @NaturalId + private String name; + + @OneToOne(mappedBy = "owner", fetch = FetchType.LAZY) + private DriversLicense driversLicense; + + @OneToMany(mappedBy = "person", cascade = CascadeType.ALL) + private List phones = new ArrayList<>(); + + public Person() { + } + + public Person(Long id, String name) { + this.id = id; + this.name = name; + } + + public Long getId() { + return id; + } + + public String getName() { + return name; + } + + public List getPhones() { + return phones; + } + + public DriversLicense getDriversLicense() { + return driversLicense; + } + + public void setDriversLicense(DriversLicense driversLicense) { + this.driversLicense = driversLicense; + } + } + + @Entity(name = "Phone") + public static class Phone { + + @Id + @GeneratedValue + private Long id; + + @ManyToOne + private Person person; + + private String phoneNumber; + + public Phone() { + } + + public Phone(Person person, String phoneNumber) { + this.person = person; + this.phoneNumber = phoneNumber; + } + + public Long getId() { + return id; + } + + public String getPhoneNumber() { + return phoneNumber; + } + + public Person getPerson() { + return person; + } + + public void setPerson(Person person) { + this.person = person; + } + } + + + @Entity(name = "DriversLicense") + public static class DriversLicense { + + @Id + private Long id; + @OneToOne + @JoinColumn(name = "owner_name", referencedColumnName = "name") + private Person owner; + @NaturalId + @Column(name = "license_number") + private String number; + + public DriversLicense() { + } + + public DriversLicense(Long id, Person owner, String number) { + this.id = id; + this.owner = owner; + this.number = number; + } + + public Long getId() { + return id; + } + + public void setId(Long id) { + this.id = id; + } + + public Person getOwner() { + return owner; + } + + public void setOwner(Person owner) { + this.owner = owner; + } + + public String getNumber() { + return number; + } + + public void setNumber(String number) { + this.number = number; + } + } + +} diff --git a/hibernate-core/src/test/java/org/hibernate/orm/test/flush/HHH10445Test.java b/hibernate-core/src/test/java/org/hibernate/orm/test/flush/HHH10445Test.java deleted file mode 100644 index 5a4915f9a8..0000000000 --- a/hibernate-core/src/test/java/org/hibernate/orm/test/flush/HHH10445Test.java +++ /dev/null @@ -1,141 +0,0 @@ -/* - * Hibernate, Relational Persistence for Idiomatic Java - * - * License: GNU Lesser General Public License (LGPL), version 2.1 or later - * See the lgpl.txt file in the root directory or http://www.gnu.org/licenses/lgpl-2.1.html - */ -package org.hibernate.orm.test.flush; - -import java.util.ArrayList; -import java.util.List; - -import org.hibernate.testing.orm.junit.DomainModel; -import org.hibernate.testing.orm.junit.FailureExpected; -import org.hibernate.testing.orm.junit.JiraKey; -import org.hibernate.testing.orm.junit.SessionFactory; -import org.hibernate.testing.orm.junit.SessionFactoryScope; - -import org.junit.jupiter.api.AfterAll; -import org.junit.jupiter.api.Test; - -import jakarta.persistence.CascadeType; -import jakarta.persistence.Entity; -import jakarta.persistence.GeneratedValue; -import jakarta.persistence.Id; -import jakarta.persistence.ManyToOne; -import jakarta.persistence.OneToMany; - -import static org.junit.jupiter.api.Assertions.assertEquals; - -/** - * @author Jan Schatteman - */ -@DomainModel( - annotatedClasses = { HHH10445Test.Person.class, HHH10445Test.Phone.class } -) -@SessionFactory -@JiraKey( value = "HHH-10445") -public class HHH10445Test { - - @AfterAll - public void tearDown(SessionFactoryScope scope) { - scope.inTransaction( - session -> session.createMutationQuery( "delete from Person" ).executeUpdate() - ); - } - - @Test - @FailureExpected(jiraKey = "HHH-10445") - public void doTest(SessionFactoryScope scope) { - Person thePerson = scope.fromTransaction( - session -> { - Person p = new Person("John Doe"); - session.persist( p ); - return p; - } - ); - - scope.inTransaction( - session -> { - Phone phone = new Phone( "1234567890" ); - thePerson.addPhone( phone ); - session.persist( phone ); - Person person = session.createQuery( "select p from Person p", Person.class).getSingleResult(); - assertEquals(1, person.getPhones().size()); - } - ); - } - - @Entity(name = "Person") - public static class Person { - - @Id - @GeneratedValue - private Long id; - - private String name; - - @OneToMany(mappedBy = "person", cascade = CascadeType.ALL) - private List phones = new ArrayList<>( ); - - public Person() {} - - public Person(String name) { - this.name = name; - } - - public Long getId() { - return id; - } - - public String getName() { - return name; - } - - public List getPhones() { - return phones; - } - - public void addPhone(Phone phone) { - phones.add( phone ); - phone.setPerson( this ); - } - } - - @Entity(name = "Phone") - public static class Phone { - - @Id - @GeneratedValue - private Long id; - - @ManyToOne - private Person person; - - private String number; - - public Phone() { - } - - public Phone(String number) { - this.number = number; - } - - public Long getId() { - return id; - } - - public String getNumber() { - return number; - } - - public Person getPerson() { - return person; - } - - public void setPerson(Person person) { - this.person = person; - } - } - -}