Hibernate
/
hibernate-orm
mirror of https://github.com/hibernate/hibernate-orm
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

HHH-13600 Extracting some more constants from loops

This commit is contained in:
Sanne Grinovero 2019-08-28 11:26:18 +01:00
parent 9f71bd890d
commit c8a36cd961
1 changed files with 8 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
hibernate-core/src/main/java/org/hibernate/hql/internal/ast/exec/DeleteExecutor.java
View File

@ -17,6 +17,7 @@ import org.hibernate.engine.spi.SharedSessionContractImplementor;
import org.hibernate.hql.internal.ast.HqlSqlWalker; import org.hibernate.hql.internal.ast.HqlSqlWalker;
import org.hibernate.hql.internal.ast.SqlGenerator; import org.hibernate.hql.internal.ast.SqlGenerator;
import org.hibernate.hql.internal.ast.tree.DeleteStatement; import org.hibernate.hql.internal.ast.tree.DeleteStatement;
import org.hibernate.metamodel.spi.MetamodelImplementor;
import org.hibernate.param.ParameterSpecification; import org.hibernate.param.ParameterSpecification;
import org.hibernate.persister.collection.AbstractCollectionPersister; import org.hibernate.persister.collection.AbstractCollectionPersister;
import org.hibernate.persister.entity.Queryable; import org.hibernate.persister.entity.Queryable;
@ -64,14 +65,17 @@ public class DeleteExecutor extends BasicExecutor {
idSubselectWhere = ""; idSubselectWhere = "";
} }
final boolean commentsEnabled = factory.getSessionFactoryOptions().isCommentsEnabled();
final MetamodelImplementor metamodel = factory.getMetamodel();
final boolean notSupportingTuplesInSubqueries = !dialect.supportsTuplesInSubqueries();
// If many-to-many, delete the FK row in the collection table. // If many-to-many, delete the FK row in the collection table.
for ( Type type : persister.getPropertyTypes() ) { for ( Type type : persister.getPropertyTypes() ) {
if ( type.isCollectionType() ) { if ( type.isCollectionType() ) {
final CollectionType cType = (CollectionType) type; final CollectionType cType = (CollectionType) type;
final AbstractCollectionPersister cPersister = (AbstractCollectionPersister) factory.getMetamodel().collectionPersister( cType.getRole() ); final AbstractCollectionPersister cPersister = (AbstractCollectionPersister) metamodel.collectionPersister( cType.getRole() );
if ( cPersister.isManyToMany() ) { if ( cPersister.isManyToMany() ) {
if ( persister.getIdentifierColumnNames().length > 1 if ( persister.getIdentifierColumnNames().length > 1
&& !dialect.supportsTuplesInSubqueries() ) { && notSupportingTuplesInSubqueries ) {
LOG.warn( LOG.warn(
"This dialect is unable to cascade the delete into the many-to-many join table" + "This dialect is unable to cascade the delete into the many-to-many join table" +
" when the entity has multiple primary keys. Either properly setup cascading on" + " when the entity has multiple primary keys. Either properly setup cascading on" +
@ -85,7 +89,7 @@ public class DeleteExecutor extends BasicExecutor {
final String where = "(" + String.join( ", ", cPersister.getKeyColumnNames() ) final String where = "(" + String.join( ", ", cPersister.getKeyColumnNames() )
+ ") in " + idSubselect; + ") in " + idSubselect;
final Delete delete = new Delete().setTableName( cPersister.getTableName() ).setWhere( where ); final Delete delete = new Delete().setTableName( cPersister.getTableName() ).setWhere( where );
if ( factory.getSessionFactoryOptions().isCommentsEnabled() ) { if ( commentsEnabled ) {
delete.setComment( "delete FKs in join table" ); delete.setComment( "delete FKs in join table" );
} }
deletes.add( delete.toStatementString() ); deletes.add( delete.toStatementString() );