HHH-1283 : Added tests that reproduce the issue
This commit is contained in:
Gail Badner
parent
7b486fc4a4
commit
cb1069a3d3
|
|
@ -0,0 +1,25 @@
|
|||
package org.hibernate.test.hqlfetchscroll;
|
||||
|
||||
public class Child {
|
||||
|
||||
private String name;
|
||||
|
||||
Child() {
|
||||
}
|
||||
|
||||
public Child(String name) {
|
||||
this.name = name;
|
||||
}
|
||||
|
||||
public String getName() {
|
||||
return name;
|
||||
}
|
||||
|
||||
private void setName(String name) {
|
||||
this.name = name;
|
||||
}
|
||||
|
||||
public String toString() {
|
||||
return name;
|
||||
}
|
||||
}
|
||||
|
|
@ -0,0 +1,462 @@
|
|||
package org.hibernate.test.hqlfetchscroll;
|
||||
|
||||
import java.util.ArrayList;
|
||||
import java.util.HashSet;
|
||||
import java.util.Iterator;
|
||||
import java.util.List;
|
||||
import java.util.Map;
|
||||
import java.util.Set;
|
||||
|
||||
import org.junit.Test;
|
||||
|
||||
import org.hibernate.Hibernate;
|
||||
import org.hibernate.ScrollableResults;
|
||||
import org.hibernate.Session;
|
||||
import org.hibernate.Transaction;
|
||||
import org.hibernate.dialect.H2Dialect;
|
||||
import org.hibernate.dialect.Oracle8iDialect;
|
||||
import org.hibernate.dialect.SQLServerDialect;
|
||||
import org.hibernate.engine.spi.SessionImplementor;
|
||||
import org.hibernate.testing.FailureExpected;
|
||||
import org.hibernate.testing.SkipForDialect;
|
||||
import org.hibernate.testing.TestForIssue;
|
||||
import org.hibernate.testing.junit4.BaseCoreFunctionalTestCase;
|
||||
import org.hibernate.transform.DistinctRootEntityResultTransformer;
|
||||
|
||||
import static org.junit.Assert.assertEquals;
|
||||
import static org.junit.Assert.assertNotNull;
|
||||
import static org.junit.Assert.assertSame;
|
||||
import static org.junit.Assert.assertTrue;
|
||||
import static org.junit.Assert.fail;
|
||||
|
||||
|
||||
public class HQLScrollFetchTest extends BaseCoreFunctionalTestCase {
|
||||
private static final String QUERY = "select p from Parent p join fetch p.children c";
|
||||
|
||||
@Test
|
||||
public void testNoScroll() {
|
||||
try {
|
||||
insertTestData();
|
||||
Session s = openSession();
|
||||
List list = s.createQuery( QUERY ).setResultTransformer( DistinctRootEntityResultTransformer.INSTANCE ).list();
|
||||
assertResultFromAllUsers( list );
|
||||
s.close();
|
||||
}
|
||||
finally {
|
||||
deleteAll();
|
||||
}
|
||||
}
|
||||
|
||||
@Test
|
||||
@SkipForDialect( { SQLServerDialect.class, Oracle8iDialect.class, H2Dialect.class } )
|
||||
public void testScroll() {
|
||||
//"SQL Server, Oracle, and H2 do not sort the result set automatically, so failure as expected","HQLScrollFetchTest" );
|
||||
try {
|
||||
insertTestData();
|
||||
Session s = openSession();
|
||||
ScrollableResults results = s.createQuery( QUERY ).scroll();
|
||||
List list = new ArrayList();
|
||||
while ( results.next() ) {
|
||||
list.add( results.get( 0 ) );
|
||||
}
|
||||
assertResultFromAllUsers( list );
|
||||
s.close();
|
||||
}
|
||||
finally {
|
||||
deleteAll();
|
||||
}
|
||||
}
|
||||
|
||||
@Test
|
||||
public void testIncompleteScrollFirstResult() {
|
||||
try {
|
||||
insertTestData();
|
||||
Session s = openSession();
|
||||
ScrollableResults results = s.createQuery( QUERY + " order by p.name asc" ).scroll();
|
||||
results.next();
|
||||
Parent p = (Parent) results.get( 0 );
|
||||
assertResultFromOneUser( p );
|
||||
s.close();
|
||||
}
|
||||
finally {
|
||||
deleteAll();
|
||||
}
|
||||
}
|
||||
|
||||
@Test
|
||||
@FailureExpected( jiraKey = "HHH-1283" )
|
||||
public void testIncompleteScrollSecondResult() {
|
||||
try {
|
||||
insertTestData();
|
||||
Session s = openSession();
|
||||
ScrollableResults results = s.createQuery( QUERY + " order by p.name asc" ).scroll();
|
||||
results.next();
|
||||
Parent p = (Parent) results.get( 0 );
|
||||
assertResultFromOneUser( p );
|
||||
results.next();
|
||||
p = (Parent) results.get( 0 );
|
||||
assertResultFromOneUser( p );
|
||||
s.close();
|
||||
}
|
||||
finally {
|
||||
deleteAll();
|
||||
}
|
||||
}
|
||||
|
||||
@Test
|
||||
public void testIncompleteScrollFirstResultInTransaction() {
|
||||
try {
|
||||
insertTestData();
|
||||
Session s = openSession();
|
||||
Transaction tx = s.beginTransaction();
|
||||
ScrollableResults results = s.createQuery( QUERY + " order by p.name asc" ).scroll();
|
||||
results.next();
|
||||
Parent p = (Parent) results.get( 0 );
|
||||
assertResultFromOneUser( p );
|
||||
tx.commit();
|
||||
s.close();
|
||||
}
|
||||
finally {
|
||||
deleteAll();
|
||||
}
|
||||
}
|
||||
|
||||
@Test
|
||||
@FailureExpected( jiraKey = "HHH-1283" )
|
||||
public void testIncompleteScrollSecondResultInTransaction() {
|
||||
try {
|
||||
insertTestData();
|
||||
Session s = openSession();
|
||||
Transaction tx = s.beginTransaction();
|
||||
ScrollableResults results = s.createQuery( QUERY + " order by p.name asc" ).scroll();
|
||||
results.next();
|
||||
Parent p = (Parent) results.get( 0 );
|
||||
assertResultFromOneUser( p );
|
||||
results.next();
|
||||
p = (Parent) results.get( 0 );
|
||||
assertResultFromOneUser( p );
|
||||
tx.commit();
|
||||
s.close();
|
||||
}
|
||||
finally {
|
||||
deleteAll();
|
||||
}
|
||||
}
|
||||
|
||||
@Test
|
||||
@FailureExpected( jiraKey = "HHH-1283")
|
||||
public void testIncompleteScroll() {
|
||||
try {
|
||||
insertTestData();
|
||||
Session s = openSession();
|
||||
ScrollableResults results = s.createQuery( QUERY + " order by p.name asc" ).scroll();
|
||||
results.next();
|
||||
Parent p = (Parent) results.get( 0 );
|
||||
assertResultFromOneUser( p );
|
||||
// get the other parent entity from the persistence context along with its first child
|
||||
// retrieved from the resultset.
|
||||
Parent pOther = null;
|
||||
Child cOther = null;
|
||||
for ( Object entity : ( (SessionImplementor) s ).getPersistenceContext().getEntitiesByKey().values() ) {
|
||||
if ( Parent.class.isInstance( entity ) ) {
|
||||
if ( entity != p ) {
|
||||
if ( pOther != null ) {
|
||||
fail( "unexpected parent found." );
|
||||
}
|
||||
pOther = (Parent) entity;
|
||||
}
|
||||
}
|
||||
else if ( Child.class.isInstance( entity ) ) {
|
||||
if ( ! p.getChildren().contains( entity ) ) {
|
||||
if ( cOther != null ) {
|
||||
fail( "unexpected child entity found" );
|
||||
}
|
||||
cOther = (Child) entity;
|
||||
}
|
||||
}
|
||||
else {
|
||||
fail( "unexpected type of entity." );
|
||||
}
|
||||
}
|
||||
// check that the same second parent is obtained by calling Session.get()
|
||||
assertSame( pOther, s.get( Parent.class, "parent2" ) );
|
||||
assertNotNull( pOther );
|
||||
assertNotNull( cOther );
|
||||
// pOther's collection non-lazy, but only 1 element has been loaded so far;
|
||||
// Should pOther's collection really be initialized???
|
||||
assertTrue( Hibernate.isInitialized( pOther.getChildren() ) );
|
||||
assertTrue( pOther.getChildren().contains( cOther ) );
|
||||
// The following fails because pOther only has 1 element.
|
||||
assertResultFromOneUser( pOther );
|
||||
s.close();
|
||||
}
|
||||
finally {
|
||||
deleteAll();
|
||||
}
|
||||
}
|
||||
|
||||
@Test
|
||||
@FailureExpected( jiraKey = "HHH-1283" )
|
||||
public void testIncompleteScrollLast() {
|
||||
try {
|
||||
insertTestData();
|
||||
Session s = openSession();
|
||||
ScrollableResults results = s.createQuery( QUERY + " order by p.name asc" ).scroll();
|
||||
results.next();
|
||||
Parent p = (Parent) results.get( 0 );
|
||||
assertResultFromOneUser( p );
|
||||
results.last();
|
||||
// get the other parent entity from the persistence context.
|
||||
// since the result set was scrolled to the end, the other parent entity's collection has been
|
||||
// properly initialized.
|
||||
Parent pOther = null;
|
||||
Set childrenOther = new HashSet();
|
||||
for ( Object entity : ( ( SessionImplementor) s ).getPersistenceContext().getEntitiesByKey().values() ) {
|
||||
if ( Parent.class.isInstance( entity ) ) {
|
||||
if ( entity != p ) {
|
||||
if ( pOther != null ) {
|
||||
fail( "unexpected parent found." );
|
||||
}
|
||||
pOther = (Parent) entity;
|
||||
}
|
||||
}
|
||||
else if ( Child.class.isInstance( entity ) ) {
|
||||
if ( ! p.getChildren().contains( entity ) ) {
|
||||
childrenOther.add( entity );
|
||||
}
|
||||
}
|
||||
else {
|
||||
fail( "unexpected type of entity." );
|
||||
}
|
||||
}
|
||||
// check that the same second parent is obtained by calling Session.get()
|
||||
assertSame( pOther, s.get( Parent.class, "parent2" ) );
|
||||
assertNotNull( pOther );
|
||||
// access pOther's collection; should be completely loaded
|
||||
assertTrue( Hibernate.isInitialized( pOther.getChildren() ) );
|
||||
assertEquals( childrenOther, pOther.getChildren() );
|
||||
assertResultFromOneUser( pOther );
|
||||
s.close();
|
||||
}
|
||||
finally {
|
||||
deleteAll();
|
||||
}
|
||||
}
|
||||
|
||||
@Test
|
||||
@FailureExpected( jiraKey = "HHH-1283" )
|
||||
public void testScrollOrderParentAsc() {
|
||||
try {
|
||||
insertTestData();
|
||||
Session s = openSession();
|
||||
ScrollableResults results = s.createQuery( QUERY + " order by p.name asc" ).scroll();
|
||||
List list = new ArrayList();
|
||||
while ( results.next() ) {
|
||||
list.add( results.get( 0 ) );
|
||||
}
|
||||
assertResultFromAllUsers( list );
|
||||
s.close();
|
||||
}
|
||||
finally {
|
||||
deleteAll();
|
||||
}
|
||||
}
|
||||
|
||||
@Test
|
||||
@FailureExpected( jiraKey = "HHH-1283" )
|
||||
public void testScrollOrderParentDesc() {
|
||||
try {
|
||||
insertTestData();
|
||||
Session s = openSession();
|
||||
ScrollableResults results = s.createQuery( QUERY + " order by p.name desc" ).scroll();
|
||||
List list = new ArrayList();
|
||||
while ( results.next() ) {
|
||||
list.add( results.get( 0 ) );
|
||||
}
|
||||
assertResultFromAllUsers( list );
|
||||
s.close();
|
||||
}
|
||||
finally {
|
||||
deleteAll();
|
||||
}
|
||||
}
|
||||
|
||||
@Test
|
||||
@FailureExpected( jiraKey = "HHH-1283" )
|
||||
public void testScrollOrderParentAscChildrenAsc() {
|
||||
try {
|
||||
insertTestData();
|
||||
Session s = openSession();
|
||||
ScrollableResults results = s.createQuery( QUERY + " order by p.name asc, c.name asc" ).scroll();
|
||||
List list = new ArrayList();
|
||||
while ( results.next() ) {
|
||||
list.add( results.get( 0 ) );
|
||||
}
|
||||
assertResultFromAllUsers( list );
|
||||
s.close();
|
||||
}
|
||||
finally {
|
||||
deleteAll();
|
||||
}
|
||||
}
|
||||
|
||||
@Test
|
||||
@FailureExpected( jiraKey = "HHH-1283" )
|
||||
public void testScrollOrderParentAscChildrenDesc() {
|
||||
try {
|
||||
insertTestData();
|
||||
Session s = openSession();
|
||||
ScrollableResults results = s.createQuery( QUERY + " order by p.name asc, c.name desc" ).scroll();
|
||||
List list = new ArrayList();
|
||||
while ( results.next() ) {
|
||||
list.add( results.get( 0 ) );
|
||||
}
|
||||
assertResultFromAllUsers( list );
|
||||
s.close();
|
||||
}
|
||||
finally {
|
||||
deleteAll();
|
||||
}
|
||||
}
|
||||
|
||||
@Test
|
||||
public void testScrollOrderChildrenDesc() {
|
||||
try {
|
||||
insertTestData();
|
||||
Session s = openSession();
|
||||
Transaction t = s.beginTransaction();
|
||||
Parent p0 = new Parent( "parent0" );
|
||||
s.save( p0 );
|
||||
t.commit();
|
||||
s.close();
|
||||
s = openSession();
|
||||
ScrollableResults results = s.createQuery( QUERY + " order by c.name desc" ).scroll();
|
||||
List list = new ArrayList();
|
||||
while ( results.next() ) {
|
||||
list.add( results.get( 0 ) );
|
||||
}
|
||||
try {
|
||||
assertResultFromAllUsers( list );
|
||||
fail( "should have failed because data is ordered incorrectly." );
|
||||
}
|
||||
catch ( AssertionError ex ) {
|
||||
// expected
|
||||
}
|
||||
finally {
|
||||
s.close();
|
||||
}
|
||||
}
|
||||
finally {
|
||||
deleteAll();
|
||||
}
|
||||
}
|
||||
|
||||
@Test
|
||||
public void testListOrderChildrenDesc() {
|
||||
try {
|
||||
insertTestData();
|
||||
Session s = openSession();
|
||||
Transaction t = s.beginTransaction();
|
||||
Parent p0 = new Parent( "parent0" );
|
||||
s.save( p0 );
|
||||
t.commit();
|
||||
s.close();
|
||||
s = openSession();
|
||||
List results = s.createQuery( QUERY + " order by c.name desc" ).list();
|
||||
try {
|
||||
assertResultFromAllUsers( results );
|
||||
fail( "should have failed because data is ordered incorrectly." );
|
||||
}
|
||||
catch ( AssertionError ex ) {
|
||||
// expected
|
||||
}
|
||||
finally {
|
||||
s.close();
|
||||
}
|
||||
}
|
||||
finally {
|
||||
deleteAll();
|
||||
}
|
||||
}
|
||||
|
||||
private void assertResultFromOneUser(Parent parent) {
|
||||
assertEquals(
|
||||
"parent " + parent + " has incorrect collection(" + parent.getChildren() + ").",
|
||||
3,
|
||||
parent.getChildren().size()
|
||||
);
|
||||
}
|
||||
|
||||
private void assertResultFromAllUsers(List list) {
|
||||
assertEquals( "list is not correct size: ", 2, list.size() );
|
||||
for ( Object aList : list ) {
|
||||
assertResultFromOneUser( (Parent) aList );
|
||||
}
|
||||
}
|
||||
|
||||
private void deleteAll() {
|
||||
Session s = openSession();
|
||||
Transaction t = s.beginTransaction();
|
||||
List list = s.createQuery( "from Parent" ).list();
|
||||
for ( Iterator i = list.iterator(); i.hasNext(); ) {
|
||||
s.delete( (Parent) i.next() );
|
||||
}
|
||||
t.commit();
|
||||
s.close();
|
||||
}
|
||||
private void insertTestData() {
|
||||
Session s = openSession();
|
||||
Transaction t = s.beginTransaction();
|
||||
Child child_1_1 = new Child( "achild1-1");
|
||||
Child child_1_2 = new Child( "ychild1-2");
|
||||
Child child_1_3 = new Child( "dchild1-3");
|
||||
Child child_2_1 = new Child( "bchild2-1");
|
||||
Child child_2_2 = new Child( "cchild2-2");
|
||||
Child child_2_3 = new Child( "zchild2-3");
|
||||
|
||||
s.save( child_1_1 );
|
||||
s.save( child_2_1 );
|
||||
s.save( child_1_2 );
|
||||
s.save( child_2_2 );
|
||||
s.save( child_1_3 );
|
||||
s.save( child_2_3 );
|
||||
|
||||
s.flush();
|
||||
|
||||
Parent p1 = new Parent( "parent1" );
|
||||
p1.addChild( child_1_1 );
|
||||
p1.addChild( child_1_2 );
|
||||
p1.addChild( child_1_3 );
|
||||
s.save( p1 );
|
||||
|
||||
Parent p2 = new Parent( "parent2" );
|
||||
p2.addChild( child_2_1 );
|
||||
p2.addChild( child_2_2 );
|
||||
p2.addChild( child_2_3 );
|
||||
s.save( p2 );
|
||||
|
||||
t.commit();
|
||||
s.close();
|
||||
}
|
||||
|
||||
// private void insertTestData() {
|
||||
// Session s = openSession();
|
||||
// Transaction t = s.beginTransaction();
|
||||
// s.save( makeParent( "parent1", "child1-1", "child1-2", "child1-3" ) );
|
||||
// s.save( makeParent( "parent2", "child2-1", "child2-2", "child2-3" ) );
|
||||
// t.commit();
|
||||
// s.close();
|
||||
// }
|
||||
|
||||
public String[] getMappings() {
|
||||
return new String[] { "hqlfetchscroll/ParentChild.hbm.xml" };
|
||||
}
|
||||
|
||||
// protected Object makeParent(String name, String child1, String child2, String child3) {
|
||||
// Parent parent = new Parent( name );
|
||||
// parent.addChild( new Child( child1 ) );
|
||||
// parent.addChild( new Child( child2 ) );
|
||||
// parent.addChild( new Child( child3 ) );
|
||||
// return parent;
|
||||
// }
|
||||
}
|
||||
|
|
@ -0,0 +1,41 @@
|
|||
package org.hibernate.test.hqlfetchscroll;
|
||||
|
||||
import java.util.HashSet;
|
||||
import java.util.Set;
|
||||
|
||||
public class Parent {
|
||||
private String name;
|
||||
private Set children = new HashSet();
|
||||
|
||||
Parent() {
|
||||
}
|
||||
|
||||
public Parent(String name) {
|
||||
this.name = name;
|
||||
}
|
||||
|
||||
public String getName() {
|
||||
return name;
|
||||
}
|
||||
|
||||
|
||||
void setName(String name) {
|
||||
this.name = name;
|
||||
}
|
||||
|
||||
public Set getChildren() {
|
||||
return children;
|
||||
}
|
||||
|
||||
private void setChildren(Set children) {
|
||||
this.children = children;
|
||||
}
|
||||
|
||||
public void addChild(Child child) {
|
||||
children.add( child );
|
||||
}
|
||||
|
||||
public String toString() {
|
||||
return name;
|
||||
}
|
||||
}
|
||||
|
|
@ -0,0 +1,23 @@
|
|||
<?xml version="1.0"?>
|
||||
<!DOCTYPE hibernate-mapping PUBLIC
|
||||
"-//Hibernate/Hibernate Mapping DTD 3.0//EN"
|
||||
"http://hibernate.sourceforge.net/hibernate-mapping-3.0.dtd">
|
||||
|
||||
<hibernate-mapping package="org.hibernate.test.hqlfetchscroll">
|
||||
|
||||
<class name="Parent" table="Parents">
|
||||
<id name="name"/>
|
||||
|
||||
<set name="children" cascade="all-delete-orphan" lazy="false">
|
||||
<key column="parent_id"/>
|
||||
<one-to-many class="Child"/>
|
||||
</set>
|
||||
|
||||
</class>
|
||||
|
||||
<class name="Child" table="chlidren">
|
||||
<id name="name"/>
|
||||
</class>
|
||||
|
||||
|
||||
</hibernate-mapping>
|
||||
Loading…
Reference in New Issue