Hibernate
/
hibernate-orm
mirror of https://github.com/hibernate/hibernate-orm
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

fix 'is distinct from' predicate on HSQL 

the semantics of the built-in operator are different to our semantics
This commit is contained in:
Gavin King 2023-06-25 22:00:03 +02:00
parent 1807e1cc43
commit cb7b364b46
2 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
hibernate-core/src/main/java/org/hibernate/dialect/HSQLSqlAstTranslator.java
View File

@ -242,12 +242,11 @@ public class HSQLSqlAstTranslator<T extends JdbcOperation> extends AbstractSqlAs
} }
else { else {
// HSQL does not like parameters in the distinct from predicate // HSQL does not like parameters in the distinct from predicate
render( lhs, SqlAstNodeRenderingMode.NO_PLAIN_PARAMETER ); renderComparisonEmulateIntersect( lhs, operator, rhs );
appendSql( operator.sqlText() );
render( rhs, SqlAstNodeRenderingMode.NO_PLAIN_PARAMETER );
} }
break; break;
default: default:
// HSQL has a broken 'is distinct from' operator
renderComparisonStandard( lhs, operator, rhs ); renderComparisonStandard( lhs, operator, rhs );
break; break;
} }
@ -317,4 +316,5 @@ public class HSQLSqlAstTranslator<T extends JdbcOperation> extends AbstractSqlAs
appendSql( CLOSE_PARENTHESIS ); appendSql( CLOSE_PARENTHESIS );
} }
} }
} }

2
hibernate-core/src/test/java/org/hibernate/orm/test/query/hql/DistinctFromTest.java
View File

@ -121,12 +121,14 @@ public class DistinctFromTest {
scope.inSession(session -> { scope.inSession(session -> {
assertEquals(1, session.createSelectionQuery("select 1 where 1 is distinct from 0").getResultList().size()); assertEquals(1, session.createSelectionQuery("select 1 where 1 is distinct from 0").getResultList().size());
assertEquals(0, session.createSelectionQuery("select 1 where 1 is distinct from 1").getResultList().size()); assertEquals(0, session.createSelectionQuery("select 1 where 1 is distinct from 1").getResultList().size());
assertEquals(1, session.createSelectionQuery("select 1 where 1 is distinct from null").getResultList().size());
assertEquals(1, session.createSelectionQuery("select 1 where null is distinct from 1").getResultList().size()); assertEquals(1, session.createSelectionQuery("select 1 where null is distinct from 1").getResultList().size());
assertEquals(1, session.createSelectionQuery("select 1 where null is distinct from 0").getResultList().size()); assertEquals(1, session.createSelectionQuery("select 1 where null is distinct from 0").getResultList().size());
assertEquals(0, session.createSelectionQuery("select 1 where null is distinct from null").getResultList().size()); assertEquals(0, session.createSelectionQuery("select 1 where null is distinct from null").getResultList().size());
assertEquals(0, session.createSelectionQuery("select 1 where 1 is not distinct from 0").getResultList().size()); assertEquals(0, session.createSelectionQuery("select 1 where 1 is not distinct from 0").getResultList().size());
assertEquals(1, session.createSelectionQuery("select 1 where 1 is not distinct from 1").getResultList().size()); assertEquals(1, session.createSelectionQuery("select 1 where 1 is not distinct from 1").getResultList().size());
assertEquals(0, session.createSelectionQuery("select 1 where 1 is not distinct from null").getResultList().size());
assertEquals(0, session.createSelectionQuery("select 1 where null is not distinct from 1").getResultList().size()); assertEquals(0, session.createSelectionQuery("select 1 where null is not distinct from 1").getResultList().size());
assertEquals(0, session.createSelectionQuery("select 1 where null is not distinct from 0").getResultList().size()); assertEquals(0, session.createSelectionQuery("select 1 where null is not distinct from 0").getResultList().size());
assertEquals(1, session.createSelectionQuery("select 1 where null is not distinct from null").getResultList().size()); assertEquals(1, session.createSelectionQuery("select 1 where null is not distinct from null").getResultList().size());