HHH-16385 Add test for issue

This commit is contained in:
clement 2023-04-01 13:33:35 +02:00 committed by Marco Belladelli
parent 395050933f
commit cdfa7a9bdc
No known key found for this signature in database
GPG Key ID: D1D0C3030AE3AA35
2 changed files with 283 additions and 0 deletions

View File

@ -0,0 +1,148 @@
package org.hibernate.orm.test.cache;
import java.util.List;
import org.hibernate.annotations.Filter;
import org.hibernate.annotations.FilterDef;
import org.hibernate.annotations.ParamDef;
import org.hibernate.cache.spi.RegionFactory;
import org.hibernate.cfg.AvailableSettings;
import org.hibernate.engine.spi.SessionImplementor;
import org.hibernate.query.Query;
import org.hibernate.stat.CacheRegionStatistics;
import org.hibernate.stat.spi.StatisticsImplementor;
import org.hibernate.testing.orm.junit.DomainModel;
import org.hibernate.testing.orm.junit.ServiceRegistry;
import org.hibernate.testing.orm.junit.SessionFactory;
import org.hibernate.testing.orm.junit.SessionFactoryScope;
import org.hibernate.testing.orm.junit.Setting;
import org.junit.jupiter.api.BeforeEach;
import org.junit.jupiter.api.Test;
import jakarta.persistence.Entity;
import jakarta.persistence.GeneratedValue;
import jakarta.persistence.GenerationType;
import jakarta.persistence.Id;
import static org.assertj.core.api.Assertions.assertThat;
@DomainModel(annotatedClasses = {
QueryCacheWithFilterTest.Person.class,
})
@SessionFactory(generateStatistics = true)
@ServiceRegistry(
settings = {
@Setting(name = AvailableSettings.USE_QUERY_CACHE, value = "true"),
@Setting(name = AvailableSettings.USE_SECOND_LEVEL_CACHE, value = "true")
}
)
public class QueryCacheWithFilterTest {
@BeforeEach
public void setUp(SessionFactoryScope scope) {
scope.inTransaction(
session -> {
Person p = new Person();
p.setName( "John" );
session.persist( p );
}
);
}
@Test
public void testQueryKeyIsImmutable(SessionFactoryScope scope) {
scope.inTransaction(
session -> {
session.enableFilter( "personName" )
.setParameter( "name", "John" );
Query<Person> query = session.createQuery(
"from Person p",
Person.class
);
query.setCacheable( true );
List<Person> resultList = query.getResultList();
assertThat( resultList ).hasSize( 1 );
//cache query should not be affected by the additional filter
session.enableFilter( "personName2" )
.setParameter( "name", "John" );
}
);
scope.inTransaction(
session -> {
session.enableFilter( "personName" )
.setParameter( "name", "John" );
Query<Person> query = session.createQuery(
"from Person p",
Person.class
);
query.setCacheable( true );
List<Person> resultList = query.getResultList();
assertThat( resultList ).hasSize( 1 );
assertThat( getQueryCacheRegionStatistics( session ).getHitCount() ).isEqualTo( 1 );
}
);
}
private static CacheRegionStatistics getQueryCacheRegionStatistics(SessionImplementor session) {
StatisticsImplementor statistics = session.getSessionFactory().getStatistics();
return statistics.getQueryRegionStatistics( RegionFactory.DEFAULT_QUERY_RESULTS_REGION_UNQUALIFIED_NAME );
}
@Entity(name = "Person")
@FilterDef(
name = "personName",
parameters = @ParamDef(
name = "name",
type = String.class
)
)
@Filter(
name = "personName",
condition = "name = :name"
)
@FilterDef(
name = "personName2",
parameters = @ParamDef(
name = "name",
type = String.class
)
)
@Filter(
name = "personName2",
condition = "name = :name"
)
public static class Person {
@Id
@GeneratedValue(strategy = GenerationType.AUTO)
private Long id;
private String name;
public Person() {
}
public Person(String name) {
this.name = name;
}
public Long getId() {
return id;
}
public String getName() {
return name;
}
public void setName(String name) {
this.name = name;
}
}
}

View File

@ -0,0 +1,135 @@
package org.hibernate.orm.test.jcache;
import java.util.List;
import org.hibernate.annotations.Filter;
import org.hibernate.annotations.FilterDef;
import org.hibernate.annotations.ParamDef;
import org.hibernate.cache.spi.RegionFactory;
import org.hibernate.cfg.AvailableSettings;
import org.hibernate.engine.spi.SessionImplementor;
import org.hibernate.query.Query;
import org.hibernate.stat.CacheRegionStatistics;
import org.hibernate.stat.spi.StatisticsImplementor;
import org.hibernate.testing.orm.junit.DomainModel;
import org.hibernate.testing.orm.junit.ServiceRegistry;
import org.hibernate.testing.orm.junit.SessionFactory;
import org.hibernate.testing.orm.junit.SessionFactoryScope;
import org.hibernate.testing.orm.junit.Setting;
import org.junit.jupiter.api.BeforeEach;
import org.junit.jupiter.api.Test;
import jakarta.persistence.Entity;
import jakarta.persistence.GeneratedValue;
import jakarta.persistence.GenerationType;
import jakarta.persistence.Id;
import static org.assertj.core.api.Assertions.assertThat;
@DomainModel(annotatedClasses = {
QueryCacheWithFilterTest.Person.class,
})
@SessionFactory(generateStatistics = true)
@ServiceRegistry(
settings = {
@Setting(name = AvailableSettings.USE_QUERY_CACHE, value = "true"),
@Setting(name = AvailableSettings.USE_SECOND_LEVEL_CACHE, value = "true"),
@Setting(name = AvailableSettings.CACHE_REGION_FACTORY, value = "jcache")
}
)
public class QueryCacheWithFilterTest {
@BeforeEach
public void setUp(SessionFactoryScope scope) {
scope.inTransaction(
session -> {
Person p = new Person();
p.setName( "John" );
session.persist( p );
}
);
}
@Test
public void testQueryKeyIsSerializable(SessionFactoryScope scope) {
scope.inTransaction(
session -> {
session.enableFilter( "personName" )
.setParameter( "name", "John" );
Query<Person> query = session.createQuery(
"from Person p",
Person.class
);
query.setCacheable( true );
List<Person> resultList1 = query.getResultList();
assertThat( resultList1 ).hasSize( 1 );
//if QueryKey is not serializable, EHCache will silently fail the cache store operation
}
);
scope.inTransaction(
session -> {
session.enableFilter( "personName" )
.setParameter( "name", "John" );
Query<Person> query = session.createQuery(
"from Person p",
Person.class
);
query.setCacheable( true );
List<Person> resultList = query.getResultList();
assertThat( resultList ).hasSize( 1 );
assertThat( getQueryCacheRegionStatistics( session ).getHitCount() ).isEqualTo( 1 );
}
);
}
private static CacheRegionStatistics getQueryCacheRegionStatistics(SessionImplementor session) {
StatisticsImplementor statistics = session.getSessionFactory().getStatistics();
return statistics.getQueryRegionStatistics( RegionFactory.DEFAULT_QUERY_RESULTS_REGION_UNQUALIFIED_NAME );
}
@Entity(name = "Person")
@FilterDef(
name = "personName",
parameters = @ParamDef(
name = "name",
type = String.class
)
)
@Filter(
name = "personName",
condition = "name = :name"
)
public static class Person {
@Id
@GeneratedValue(strategy = GenerationType.AUTO)
private Long id;
private String name;
public Person() {
}
public Person(String name) {
this.name = name;
}
public Long getId() {
return id;
}
public String getName() {
return name;
}
public void setName(String name) {
this.name = name;
}
}
}