Hibernate
/
hibernate-orm
mirror of https://github.com/hibernate/hibernate-orm
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

HHH-6863 make serviceBindingMap threadsafe

This commit is contained in:
Sanne Grinovero 2011-11-11 21:07:38 +00:00 committed by Strong Liu
parent 7781cb0aa9
commit d158047287
1 changed files with 4 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
hibernate-core/src/main/java/org/hibernate/service/internal/AbstractServiceRegistryImpl.java
View File

@ -24,7 +24,6 @@
package org.hibernate.service.internal;
import java.lang.reflect.Method;
import java.util.ArrayList;
import java.util.List;
import java.util.ListIterator;
import java.util.concurrent.ConcurrentHashMap;
@ -61,10 +60,12 @@ public abstract class AbstractServiceRegistryImpl
private final ServiceRegistryImplementor parent;
private ConcurrentHashMap<Class,ServiceBinding> serviceBindingMap;
private final ConcurrentHashMap<Class,ServiceBinding> serviceBindingMap = CollectionHelper.concurrentMap( 20 );
// IMPL NOTE : the list used for ordered destruction. Cannot used map above because we need to
// iterate it in reverse order which is only available through ListIterator
private List<ServiceBinding> serviceBindingList = new ArrayList<ServiceBinding>();
// assume 20 services for initial sizing
private final List<ServiceBinding> serviceBindingList = CollectionHelper.arrayList( 20 );
@SuppressWarnings( {"UnusedDeclaration"})
protected AbstractServiceRegistryImpl() {
@ -73,14 +74,6 @@ public abstract class AbstractServiceRegistryImpl
protected AbstractServiceRegistryImpl(ServiceRegistryImplementor parent) {
this.parent = parent;
prepare();
}
private void prepare() {
// assume 20 services for initial sizing
this.serviceBindingMap = CollectionHelper.concurrentMap( 20 );
this.serviceBindingList = CollectionHelper.arrayList( 20 );
}
public AbstractServiceRegistryImpl(BootstrapServiceRegistry bootstrapServiceRegistry) {
@ -88,7 +81,6 @@ public abstract class AbstractServiceRegistryImpl
throw new IllegalArgumentException( "Boot-strap registry was not " );
}
this.parent = (ServiceRegistryImplementor) bootstrapServiceRegistry;
prepare();
}
@SuppressWarnings({ "unchecked" })
@ -278,9 +270,7 @@ public abstract class AbstractServiceRegistryImpl
serviceBinding.getLifecycleOwner().stopService( serviceBinding );
}
serviceBindingList.clear();
serviceBindingList = null;
serviceBindingMap.clear();
serviceBindingMap = null;
}
@Override