HHH-16794 Add test for issue

This commit is contained in:
Andrea Boriero 2023-06-14 13:15:25 +02:00 committed by Andrea Boriero
parent 46bfc59cd1
commit d71a0f77e1
2 changed files with 322 additions and 0 deletions

View File

@ -0,0 +1,172 @@
package org.hibernate.orm.test.bytecode.enhancement.lazy;
import org.hibernate.annotations.Proxy;
import org.hibernate.cfg.Configuration;
import org.hibernate.testing.bytecode.enhancement.BytecodeEnhancerRunner;
import org.hibernate.testing.jdbc.SQLStatementInspector;
import org.hibernate.testing.junit4.BaseCoreFunctionalTestCase;
import org.hibernate.testing.orm.junit.JiraKey;
import org.junit.Before;
import org.junit.Test;
import org.junit.runner.RunWith;
import jakarta.persistence.DiscriminatorColumn;
import jakarta.persistence.DiscriminatorValue;
import jakarta.persistence.Entity;
import jakarta.persistence.FetchType;
import jakarta.persistence.Id;
import jakarta.persistence.Inheritance;
import jakarta.persistence.InheritanceType;
import jakarta.persistence.JoinColumn;
import jakarta.persistence.ManyToOne;
import static org.assertj.core.api.AssertionsForClassTypes.assertThat;
@RunWith(BytecodeEnhancerRunner.class)
@JiraKey("HHH-16794")
public class LazyAbstractManyToOneNoProxyTest extends BaseCoreFunctionalTestCase {
private static final String USER_1_NAME = "Andrea";
private static final String USER_2_NAME = "Fab";
private static final String USER_GROUP_1_NAME = "group1";
private static final String USER_GROUP_2_NAME = "group2";
@Override
protected Class<?>[] getAnnotatedClasses() {
return new Class[] {
User.class,
UserGroup.class,
};
}
@Override
protected void afterConfigurationBuilt(Configuration configuration) {
super.afterConfigurationBuilt( configuration );
configuration.setStatementInspector( new SQLStatementInspector() );
}
SQLStatementInspector statementInspector() {
return (SQLStatementInspector) sessionFactory().getSessionFactoryOptions().getStatementInspector();
}
@Before
public void setUp() {
inTransaction(
session -> {
UserGroup group1 = new UserGroup( 1l, USER_GROUP_1_NAME );
UserGroup group2 = new UserGroup( 2l, USER_GROUP_2_NAME );
User user1 = new User( 1l, USER_1_NAME, group1 );
User user2 = new User( 2l, USER_2_NAME, group2 );
session.persist( user1 );
session.persist( user2 );
session.persist( group1 );
session.persist( group2 );
}
);
}
@Test
public void testSelect() {
inTransaction(
session -> {
SQLStatementInspector statementInspector = statementInspector();
statementInspector.clear();
User user = session.getReference( User.class, 1 );
assertThat( user ).isNotNull();
assertThat( user.getName() ).isEqualTo( USER_1_NAME );
// The User#team type has subclasses so even if it is lazy we need to initialize it because we do not know
// the real type and Proxy creation is disabled
assertThat( statementInspector.getSqlQueries().size() ).isEqualTo( 2 );
statementInspector.clear();
ActorGroup team = user.getTeam();
assertThat( team ).isInstanceOf( UserGroup.class );
UserGroup userGroup = (UserGroup) team;
assertThat( userGroup.getName() ).isEqualTo( USER_GROUP_1_NAME );
assertThat( statementInspector.getSqlQueries().size() ).isEqualTo( 0 );
}
);
}
@Entity
@Proxy(lazy = false)
public static class User {
@Id
Long id;
String name;
@ManyToOne(fetch = FetchType.LAZY)
@JoinColumn(name = "team_id")
ActorGroup team;
public User() {
}
public User(Long id, String name, UserGroup team) {
this.id = id;
this.name = name;
this.team = team;
}
public Long getId() {
return id;
}
public String getName() {
return name;
}
public ActorGroup getTeam() {
return team;
}
}
@Entity
@Inheritance(strategy = InheritanceType.SINGLE_TABLE)
@DiscriminatorColumn(name = "TYPE")
@Proxy(lazy = false)
public abstract static class ActorGroup {
@Id
Long id;
public ActorGroup() {
}
public ActorGroup(Long id) {
this.id = id;
}
}
@Entity
@Proxy(lazy = false)
@DiscriminatorValue("USERS")
public static class UserGroup extends ActorGroup {
String name;
public UserGroup() {
}
public UserGroup(Long id, String name) {
super( id );
this.name = name;
}
public Long getId() {
return id;
}
public String getName() {
return name;
}
}
}

View File

@ -0,0 +1,150 @@
package org.hibernate.orm.test.bytecode.enhancement.lazy;
import org.hibernate.annotations.Proxy;
import org.hibernate.cfg.Configuration;
import org.hibernate.testing.bytecode.enhancement.BytecodeEnhancerRunner;
import org.hibernate.testing.jdbc.SQLStatementInspector;
import org.hibernate.testing.junit4.BaseCoreFunctionalTestCase;
import org.hibernate.testing.orm.junit.JiraKey;
import org.junit.Before;
import org.junit.Test;
import org.junit.runner.RunWith;
import jakarta.persistence.Entity;
import jakarta.persistence.FetchType;
import jakarta.persistence.Id;
import jakarta.persistence.JoinColumn;
import jakarta.persistence.ManyToOne;
import static org.assertj.core.api.AssertionsForClassTypes.assertThat;
@RunWith(BytecodeEnhancerRunner.class)
@JiraKey("HHH-16794")
public class LazyManyToOneNoProxyTest extends BaseCoreFunctionalTestCase {
private static final String USER_1_NAME = "Andrea";
private static final String USER_2_NAME = "Fab";
private static final String USER_GROUP_1_NAME = "group1";
private static final String USER_GROUP_2_NAME = "group2";
@Override
protected Class<?>[] getAnnotatedClasses() {
return new Class[] {
User.class,
UserGroup.class,
};
}
@Override
protected void afterConfigurationBuilt(Configuration configuration) {
super.afterConfigurationBuilt( configuration );
configuration.setStatementInspector( new SQLStatementInspector() );
}
SQLStatementInspector statementInspector() {
return (SQLStatementInspector) sessionFactory().getSessionFactoryOptions().getStatementInspector();
}
@Before
public void setUp() {
inTransaction(
session -> {
UserGroup group1 = new UserGroup( 1l, USER_GROUP_1_NAME );
UserGroup group2 = new UserGroup( 2l, USER_GROUP_2_NAME );
User user1 = new User( 1l, USER_1_NAME, group1 );
User user2 = new User( 2l, USER_2_NAME, group2 );
session.persist( user1 );
session.persist( user2 );
session.persist( group1 );
session.persist( group2 );
}
);
}
@Test
public void testSelect() {
inTransaction(
session -> {
SQLStatementInspector statementInspector = statementInspector();
statementInspector.clear();
User user = session.getReference( User.class, 1 );
assertThat( user ).isNotNull();
assertThat( user.getName() ).isEqualTo( USER_1_NAME );
// User#team is lazy, so it should not be initialized
assertThat( statementInspector.getSqlQueries().size() ).isEqualTo( 1 );
statementInspector.clear();
UserGroup team = user.getTeam();
assertThat( team.getName() ).isEqualTo( USER_GROUP_1_NAME );
assertThat( statementInspector.getSqlQueries().size() ).isEqualTo( 1 );
}
);
}
@Entity
@Proxy(lazy = false)
public static class User {
@Id
Long id;
String name;
@ManyToOne(fetch = FetchType.LAZY)
@JoinColumn(name = "team_id")
UserGroup team;
public User() {
}
public User(Long id, String name, UserGroup team) {
this.id = id;
this.name = name;
this.team = team;
}
public Long getId() {
return id;
}
public String getName() {
return name;
}
public UserGroup getTeam() {
return team;
}
}
@Entity
@Proxy(lazy = false)
public static class UserGroup {
@Id
Long id;
String name;
public UserGroup() {
}
public UserGroup(Long id, String name) {
this.id = id;
this.name = name;
}
public Long getId() {
return id;
}
public String getName() {
return name;
}
}
}