HHH-12138: HANA dialect doesn't support procedure parameter mode REF_CURSOR
This commit is contained in:
Jonathan Bregler
Vlad Mihalcea
parent
55ab0d5677
commit
db2e3906ab
|
|
@ -74,6 +74,8 @@ import org.hibernate.exception.spi.SQLExceptionConversionDelegate;
|
|||
import org.hibernate.internal.util.JdbcExceptionHelper;
|
||||
import org.hibernate.internal.util.StringHelper;
|
||||
import org.hibernate.mapping.Table;
|
||||
import org.hibernate.procedure.internal.StandardCallableStatementSupport;
|
||||
import org.hibernate.procedure.spi.CallableStatementSupport;
|
||||
import org.hibernate.service.ServiceRegistry;
|
||||
import org.hibernate.tool.schema.internal.StandardTableExporter;
|
||||
import org.hibernate.tool.schema.spi.Exporter;
|
||||
|
|
@ -1518,4 +1520,26 @@ public abstract class AbstractHANADialect extends Dialect {
|
|||
return this.hanaTableExporter;
|
||||
}
|
||||
|
||||
/*
|
||||
* HANA doesn't really support REF_CURSOR returns from a procedure, but REF_CURSOR support can be emulated by using
|
||||
* procedures or functions with an OUT parameter of type TABLE. The results will be returned as result sets on the
|
||||
* callable statement.
|
||||
*/
|
||||
@Override
|
||||
public CallableStatementSupport getCallableStatementSupport() {
|
||||
return StandardCallableStatementSupport.REF_CURSOR_INSTANCE;
|
||||
}
|
||||
|
||||
@Override
|
||||
public int registerResultSetOutParameter(CallableStatement statement, int position) throws SQLException {
|
||||
// Result set (TABLE) OUT parameters don't need to be registered
|
||||
return position;
|
||||
}
|
||||
|
||||
@Override
|
||||
public int registerResultSetOutParameter(CallableStatement statement, String name) throws SQLException {
|
||||
// Result set (TABLE) OUT parameters don't need to be registered
|
||||
return 0;
|
||||
}
|
||||
|
||||
}
|
||||
|
|
|
|||
|
|
@ -0,0 +1,464 @@
|
|||
package org.hibernate.test.procedure;
|
||||
|
||||
import static org.hibernate.testing.transaction.TransactionUtil.doInJPA;
|
||||
import static org.junit.Assert.assertEquals;
|
||||
import static org.junit.Assert.assertFalse;
|
||||
import static org.junit.Assert.assertNotNull;
|
||||
|
||||
import java.sql.PreparedStatement;
|
||||
import java.sql.ResultSet;
|
||||
import java.sql.SQLException;
|
||||
import java.sql.Statement;
|
||||
import java.sql.Timestamp;
|
||||
import java.time.LocalDateTime;
|
||||
import java.time.ZoneOffset;
|
||||
import java.util.List;
|
||||
|
||||
import javax.persistence.Entity;
|
||||
import javax.persistence.EntityManager;
|
||||
import javax.persistence.Id;
|
||||
import javax.persistence.NamedStoredProcedureQueries;
|
||||
import javax.persistence.NamedStoredProcedureQuery;
|
||||
import javax.persistence.ParameterMode;
|
||||
import javax.persistence.StoredProcedureParameter;
|
||||
import javax.persistence.StoredProcedureQuery;
|
||||
|
||||
import org.hibernate.Session;
|
||||
import org.hibernate.dialect.AbstractHANADialect;
|
||||
import org.hibernate.jpa.test.BaseEntityManagerFunctionalTestCase;
|
||||
import org.hibernate.procedure.ProcedureCall;
|
||||
import org.hibernate.result.Output;
|
||||
import org.hibernate.result.ResultSetOutput;
|
||||
import org.hibernate.testing.RequiresDialect;
|
||||
import org.hibernate.testing.TestForIssue;
|
||||
import org.junit.After;
|
||||
import org.junit.Before;
|
||||
import org.junit.Test;
|
||||
|
||||
/**
|
||||
* @author Vlad Mihalcea, Jonathan Bregler
|
||||
*/
|
||||
@RequiresDialect(AbstractHANADialect.class)
|
||||
public class HANAStoredProcedureTest extends BaseEntityManagerFunctionalTestCase {
|
||||
|
||||
@Override
|
||||
protected Class<?>[] getAnnotatedClasses() {
|
||||
return new Class<?>[]{
|
||||
Person.class,
|
||||
Phone.class,
|
||||
IdHolder.class
|
||||
};
|
||||
}
|
||||
|
||||
@NamedStoredProcedureQueries({
|
||||
@NamedStoredProcedureQuery(name = "singleRefCursor", procedureName = "singleRefCursor", parameters = {
|
||||
@StoredProcedureParameter(mode = ParameterMode.REF_CURSOR, type = void.class)
|
||||
}),
|
||||
@NamedStoredProcedureQuery(name = "outAndRefCursor", procedureName = "outAndRefCursor", parameters = {
|
||||
@StoredProcedureParameter(mode = ParameterMode.OUT, type = Integer.class),
|
||||
@StoredProcedureParameter(mode = ParameterMode.REF_CURSOR, type = void.class)
|
||||
})
|
||||
})
|
||||
@Entity(name = "IdHolder")
|
||||
public static class IdHolder {
|
||||
|
||||
@Id
|
||||
Long id;
|
||||
}
|
||||
|
||||
@Before
|
||||
public void init() {
|
||||
EntityManager entityManager = createEntityManager();
|
||||
entityManager.getTransaction().begin();
|
||||
|
||||
try {
|
||||
Session session = entityManager.unwrap( Session.class );
|
||||
|
||||
session.doWork( connection -> {
|
||||
Statement statement = null;
|
||||
try {
|
||||
statement = connection.createStatement();
|
||||
statement.executeUpdate(
|
||||
"CREATE OR REPLACE PROCEDURE sp_count_phones ( " +
|
||||
" IN personId INTEGER, " +
|
||||
" OUT phoneCount INTEGER ) " +
|
||||
"AS " +
|
||||
"BEGIN " +
|
||||
" SELECT COUNT(*) INTO phoneCount " +
|
||||
" FROM phone " +
|
||||
" WHERE person_id = :personId; " +
|
||||
"END;" );
|
||||
statement.executeUpdate(
|
||||
"CREATE OR REPLACE PROCEDURE sp_person_phones ( " +
|
||||
" IN personId INTEGER, " +
|
||||
" OUT personPhones phone ) " +
|
||||
"AS " +
|
||||
"BEGIN " +
|
||||
" personPhones = " +
|
||||
" SELECT *" +
|
||||
" FROM phone " +
|
||||
" WHERE person_id = :personId; " +
|
||||
"END;" );
|
||||
statement.executeUpdate(
|
||||
"CREATE OR REPLACE FUNCTION fn_count_phones ( " +
|
||||
" IN personId INTEGER ) " +
|
||||
" RETURNS phoneCount INTEGER " +
|
||||
"AS " +
|
||||
"BEGIN " +
|
||||
" SELECT COUNT(*) INTO phoneCount " +
|
||||
" FROM phone " +
|
||||
" WHERE person_id = :personId; " +
|
||||
"END;" );
|
||||
statement.executeUpdate(
|
||||
"CREATE OR REPLACE FUNCTION fn_person_and_phones ( " +
|
||||
" IN personId INTEGER ) " +
|
||||
" RETURNS TABLE (\"pr.id\" BIGINT,"
|
||||
+ " \"pr.name\" NVARCHAR(5000),"
|
||||
+ " \"pr.nickName\" NVARCHAR(5000),"
|
||||
+ " \"pr.address\" NVARCHAR(5000),"
|
||||
+ " \"pr.createdOn\" TIMESTAMP,"
|
||||
+ " \"pr.version\" INTEGER,"
|
||||
+ " \"ph.id\" BIGINT,"
|
||||
+ " \"ph.person_id\" BIGINT,"
|
||||
+ " \"ph.phone_number\" NVARCHAR(5000)) " +
|
||||
"AS " +
|
||||
"BEGIN " +
|
||||
" RETURN " +
|
||||
" SELECT " +
|
||||
" pr.id AS \"pr.id\", " +
|
||||
" pr.name AS \"pr.name\", " +
|
||||
" pr.nickName AS \"pr.nickName\", " +
|
||||
" pr.address AS \"pr.address\", " +
|
||||
" pr.createdOn AS \"pr.createdOn\", " +
|
||||
" pr.version AS \"pr.version\", " +
|
||||
" ph.id AS \"ph.id\", " +
|
||||
" ph.person_id AS \"ph.person_id\", " +
|
||||
" ph.phone_number AS \"ph.phone_number\" " +
|
||||
" FROM person pr " +
|
||||
" JOIN phone ph ON pr.id = ph.person_id " +
|
||||
" WHERE pr.id = personId; " +
|
||||
"END;" );
|
||||
statement.executeUpdate(
|
||||
"CREATE OR REPLACE " +
|
||||
"PROCEDURE singleRefCursor(OUT p_recordset TABLE(id INTEGER)) AS " +
|
||||
" BEGIN " +
|
||||
" p_recordset = " +
|
||||
" SELECT 1 as id " +
|
||||
" FROM DUMMY; " +
|
||||
" END; " );
|
||||
statement.executeUpdate(
|
||||
"CREATE OR REPLACE " +
|
||||
"PROCEDURE outAndRefCursor(OUT p_value INTEGER, OUT p_recordset TABLE(id INTEGER)) AS " +
|
||||
" BEGIN " +
|
||||
" p_recordset = " +
|
||||
" SELECT 1 as id " +
|
||||
" FROM DUMMY; " +
|
||||
" SELECT 1 INTO p_value FROM DUMMY; " +
|
||||
" END; " );
|
||||
}
|
||||
finally {
|
||||
if ( statement != null ) {
|
||||
statement.close();
|
||||
}
|
||||
}
|
||||
} );
|
||||
}
|
||||
finally {
|
||||
entityManager.getTransaction().rollback();
|
||||
entityManager.close();
|
||||
}
|
||||
|
||||
entityManager = createEntityManager();
|
||||
entityManager.getTransaction().begin();
|
||||
|
||||
try {
|
||||
Person person1 = new Person( "John Doe" );
|
||||
person1.setNickName( "JD" );
|
||||
person1.setAddress( "Earth" );
|
||||
person1.setCreatedOn( Timestamp.from( LocalDateTime.of( 2000, 1, 1, 0, 0, 0 ).toInstant( ZoneOffset.UTC ) ) );
|
||||
|
||||
entityManager.persist( person1 );
|
||||
|
||||
Phone phone1 = new Phone( "123-456-7890" );
|
||||
phone1.setId( 1L );
|
||||
|
||||
person1.addPhone( phone1 );
|
||||
|
||||
Phone phone2 = new Phone( "098_765-4321" );
|
||||
phone2.setId( 2L );
|
||||
|
||||
person1.addPhone( phone2 );
|
||||
|
||||
entityManager.getTransaction().commit();
|
||||
}
|
||||
finally {
|
||||
entityManager.close();
|
||||
}
|
||||
}
|
||||
|
||||
@After
|
||||
public void destroy() {
|
||||
EntityManager entityManager = createEntityManager();
|
||||
entityManager.getTransaction().begin();
|
||||
|
||||
try {
|
||||
Session session = entityManager.unwrap( Session.class );
|
||||
session.doWork( connection -> {
|
||||
try ( Statement statement = connection.createStatement() ) {
|
||||
statement.executeUpdate( "DROP PROCEDURE sp_count_phones" );
|
||||
}
|
||||
catch (SQLException ignore) {
|
||||
}
|
||||
} );
|
||||
}
|
||||
finally {
|
||||
entityManager.getTransaction().rollback();
|
||||
entityManager.close();
|
||||
}
|
||||
|
||||
entityManager = createEntityManager();
|
||||
entityManager.getTransaction().begin();
|
||||
|
||||
try {
|
||||
Session session = entityManager.unwrap( Session.class );
|
||||
session.doWork( connection -> {
|
||||
try ( Statement statement = connection.createStatement() ) {
|
||||
statement.executeUpdate( "DROP PROCEDURE sp_person_phones" );
|
||||
}
|
||||
catch (SQLException ignore) {
|
||||
}
|
||||
} );
|
||||
}
|
||||
finally {
|
||||
entityManager.getTransaction().rollback();
|
||||
entityManager.close();
|
||||
}
|
||||
|
||||
entityManager = createEntityManager();
|
||||
entityManager.getTransaction().begin();
|
||||
|
||||
try {
|
||||
Session session = entityManager.unwrap( Session.class );
|
||||
session.doWork( connection -> {
|
||||
try ( Statement statement = connection.createStatement() ) {
|
||||
statement.executeUpdate( "DROP FUNCTION fn_count_phones" );
|
||||
}
|
||||
catch (SQLException ignore) {
|
||||
}
|
||||
} );
|
||||
}
|
||||
finally {
|
||||
entityManager.getTransaction().rollback();
|
||||
entityManager.close();
|
||||
}
|
||||
|
||||
entityManager = createEntityManager();
|
||||
entityManager.getTransaction().begin();
|
||||
|
||||
try {
|
||||
Session session = entityManager.unwrap( Session.class );
|
||||
session.doWork( connection -> {
|
||||
try ( Statement statement = connection.createStatement() ) {
|
||||
statement.executeUpdate( "DROP PROCEDURE singleRefCursor" );
|
||||
}
|
||||
catch (SQLException ignore) {
|
||||
}
|
||||
} );
|
||||
}
|
||||
finally {
|
||||
entityManager.getTransaction().rollback();
|
||||
entityManager.close();
|
||||
}
|
||||
|
||||
entityManager = createEntityManager();
|
||||
entityManager.getTransaction().begin();
|
||||
|
||||
try {
|
||||
Session session = entityManager.unwrap( Session.class );
|
||||
session.doWork( connection -> {
|
||||
try ( Statement statement = connection.createStatement() ) {
|
||||
statement.executeUpdate( "DROP PROCEDURE outAndRefCursor" );
|
||||
}
|
||||
catch (SQLException ignore) {
|
||||
}
|
||||
} );
|
||||
}
|
||||
finally {
|
||||
entityManager.getTransaction().rollback();
|
||||
entityManager.close();
|
||||
}
|
||||
}
|
||||
|
||||
@Test
|
||||
@TestForIssue(jiraKey = "HHH-12138")
|
||||
public void testStoredProcedureOutParameter() {
|
||||
EntityManager entityManager = createEntityManager();
|
||||
entityManager.getTransaction().begin();
|
||||
|
||||
try {
|
||||
StoredProcedureQuery query = entityManager.createStoredProcedureQuery( "sp_count_phones" );
|
||||
query.registerStoredProcedureParameter( 1, Long.class, ParameterMode.IN );
|
||||
query.registerStoredProcedureParameter( 2, Long.class, ParameterMode.OUT );
|
||||
|
||||
query.setParameter( 1, 1L );
|
||||
|
||||
query.execute();
|
||||
Long phoneCount = (Long) query.getOutputParameterValue( 2 );
|
||||
assertEquals( Long.valueOf( 2 ), phoneCount );
|
||||
}
|
||||
finally {
|
||||
entityManager.getTransaction().rollback();
|
||||
entityManager.close();
|
||||
}
|
||||
}
|
||||
|
||||
@Test
|
||||
@TestForIssue(jiraKey = "HHH-12138")
|
||||
public void testStoredProcedureRefCursor() {
|
||||
EntityManager entityManager = createEntityManager();
|
||||
entityManager.getTransaction().begin();
|
||||
|
||||
try {
|
||||
StoredProcedureQuery query = entityManager.createStoredProcedureQuery( "sp_person_phones" );
|
||||
query.registerStoredProcedureParameter( 1, Long.class, ParameterMode.IN );
|
||||
query.registerStoredProcedureParameter( 2, Class.class, ParameterMode.REF_CURSOR );
|
||||
query.setParameter( 1, 1L );
|
||||
|
||||
query.execute();
|
||||
List<Object[]> postComments = query.getResultList();
|
||||
assertNotNull( postComments );
|
||||
}
|
||||
finally {
|
||||
entityManager.getTransaction().rollback();
|
||||
entityManager.close();
|
||||
}
|
||||
}
|
||||
|
||||
@Test
|
||||
@TestForIssue(jiraKey = "HHH-12138")
|
||||
public void testHibernateProcedureCallRefCursor() {
|
||||
EntityManager entityManager = createEntityManager();
|
||||
entityManager.getTransaction().begin();
|
||||
|
||||
try {
|
||||
Session session = entityManager.unwrap( Session.class );
|
||||
|
||||
ProcedureCall call = session.createStoredProcedureCall( "sp_person_phones" );
|
||||
call.registerParameter( 1, Long.class, ParameterMode.IN ).bindValue( 1L );
|
||||
call.registerParameter( 2, Class.class, ParameterMode.REF_CURSOR );
|
||||
|
||||
Output output = call.getOutputs().getCurrent();
|
||||
List<Object[]> postComments = ( (ResultSetOutput) output ).getResultList();
|
||||
assertEquals( 2, postComments.size() );
|
||||
}
|
||||
finally {
|
||||
entityManager.getTransaction().rollback();
|
||||
entityManager.close();
|
||||
}
|
||||
}
|
||||
|
||||
@Test
|
||||
@TestForIssue(jiraKey = "HHH-12138")
|
||||
public void testStoredProcedureReturnValue() {
|
||||
EntityManager entityManager = createEntityManager();
|
||||
entityManager.getTransaction().begin();
|
||||
|
||||
try {
|
||||
Integer phoneCount = (Integer) entityManager
|
||||
.createNativeQuery( "SELECT fn_count_phones(:personId) FROM DUMMY" )
|
||||
.setParameter( "personId", 1 )
|
||||
.getSingleResult();
|
||||
assertEquals( Integer.valueOf( 2 ), phoneCount );
|
||||
}
|
||||
finally {
|
||||
entityManager.getTransaction().rollback();
|
||||
entityManager.close();
|
||||
}
|
||||
}
|
||||
|
||||
@Test
|
||||
@TestForIssue(jiraKey = "HHH-12138")
|
||||
public void testNamedNativeQueryStoredProcedureRefCursor() {
|
||||
EntityManager entityManager = createEntityManager();
|
||||
entityManager.getTransaction().begin();
|
||||
|
||||
try {
|
||||
List<Object[]> postAndComments = entityManager
|
||||
.createNamedQuery(
|
||||
"fn_person_and_phones_hana" )
|
||||
.setParameter( 1, 1L )
|
||||
.getResultList();
|
||||
Object[] postAndComment = postAndComments.get( 0 );
|
||||
Person person = (Person) postAndComment[0];
|
||||
Phone phone = (Phone) postAndComment[1];
|
||||
assertEquals( 2, postAndComments.size() );
|
||||
}
|
||||
finally {
|
||||
entityManager.getTransaction().rollback();
|
||||
entityManager.close();
|
||||
}
|
||||
}
|
||||
|
||||
@Test
|
||||
@TestForIssue(jiraKey = "HHH-12138")
|
||||
public void testNamedNativeQueryStoredProcedureRefCursorWithJDBC() {
|
||||
EntityManager entityManager = createEntityManager();
|
||||
entityManager.getTransaction().begin();
|
||||
|
||||
try {
|
||||
Session session = entityManager.unwrap( Session.class );
|
||||
session.doWork( connection -> {
|
||||
try ( PreparedStatement function = connection.prepareStatement(
|
||||
"select * from fn_person_and_phones( ? )" ) ) {
|
||||
function.setInt( 1, 1 );
|
||||
function.execute();
|
||||
try ( ResultSet resultSet = function.getResultSet() ) {
|
||||
while ( resultSet.next() ) {
|
||||
Long postCommentId = resultSet.getLong( 1 );
|
||||
String review = resultSet.getString( 2 );
|
||||
}
|
||||
}
|
||||
}
|
||||
} );
|
||||
}
|
||||
finally {
|
||||
entityManager.getTransaction().rollback();
|
||||
entityManager.close();
|
||||
}
|
||||
}
|
||||
|
||||
@Test
|
||||
@TestForIssue(jiraKey = "HHH-12138")
|
||||
public void testSysRefCursorAsOutParameter() {
|
||||
|
||||
doInJPA( this::entityManagerFactory, entityManager -> {
|
||||
StoredProcedureQuery function = entityManager.createNamedStoredProcedureQuery( "singleRefCursor" );
|
||||
|
||||
function.execute();
|
||||
|
||||
Integer value = (Integer) function.getSingleResult();
|
||||
|
||||
assertFalse( function.hasMoreResults() );
|
||||
|
||||
assertEquals( Integer.valueOf( 1 ), value );
|
||||
} );
|
||||
}
|
||||
|
||||
@Test
|
||||
@TestForIssue(jiraKey = "HHH-12138")
|
||||
public void testOutAndSysRefCursorAsOutParameter() {
|
||||
|
||||
doInJPA( this::entityManagerFactory, entityManager -> {
|
||||
StoredProcedureQuery function = entityManager.createNamedStoredProcedureQuery( "outAndRefCursor" );
|
||||
|
||||
function.execute();
|
||||
|
||||
Integer value = (Integer) function.getSingleResult();
|
||||
|
||||
assertEquals( Integer.valueOf( 1 ), value );
|
||||
assertEquals( Integer.valueOf( 1 ), function.getOutputParameterValue( 1 ) );
|
||||
|
||||
assertFalse( function.hasMoreResults() );
|
||||
} );
|
||||
}
|
||||
}
|
||||
|
|
@ -34,6 +34,12 @@ import org.hibernate.annotations.NamedNativeQuery;
|
|||
callable = true,
|
||||
resultSetMapping = "person_with_phones"
|
||||
)
|
||||
@NamedNativeQuery(
|
||||
name = "fn_person_and_phones_hana",
|
||||
query = "select * from fn_person_and_phones( ? )",
|
||||
callable = false,
|
||||
resultSetMapping = "person_with_phones"
|
||||
)
|
||||
@SqlResultSetMappings({
|
||||
@SqlResultSetMapping(
|
||||
name = "person_with_phones",
|
||||
|
|
|
|||
Loading…
Reference in New Issue