Hibernate
/
hibernate-orm
mirror of https://github.com/hibernate/hibernate-orm
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

HHH-8210 JdbcCoordinatorImpl logs excessive warnings with some 

connection pools
This commit is contained in:
Brett Meyer 2013-06-27 22:48:48 -04:00
parent 77fd4d6a89
commit ded1303b30
2 changed files with 9 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
hibernate-core/src/main/java/org/hibernate/engine/jdbc/internal/JdbcCoordinatorImpl.java
View File

@ -381,7 +381,9 @@ public class JdbcCoordinatorImpl implements JdbcCoordinator {
} }
} }
if ( statement != null ) { if ( statement != null ) {
if ( LOG.isEnabled( Level.WARN ) && !xref.containsKey( statement ) ) { // Keep this at DEBUG level, rather than warn. Numerous connection pool implementations can return a
// proxy/wrapper around the JDBC Statement, causing excessive logging here. See HHH-8210.
if ( LOG.isEnabled( Level.DEBUG ) && !xref.containsKey( statement ) ) {
LOG.unregisteredStatement(); LOG.unregisteredStatement();
} }
Set<ResultSet> resultSets = xref.get( statement ); Set<ResultSet> resultSets = xref.get( statement );
@ -407,7 +409,9 @@ public class JdbcCoordinatorImpl implements JdbcCoordinator {
throw exceptionHelper.convert( e, "unable to access statement from resultset" ); throw exceptionHelper.convert( e, "unable to access statement from resultset" );
} }
if ( statement != null ) { if ( statement != null ) {
if ( LOG.isEnabled( Level.WARN ) && !xref.containsKey( statement ) ) { // Keep this at DEBUG level, rather than warn. Numerous connection pool implementations can return a
// proxy/wrapper around the JDBC Statement, causing excessive logging here. See HHH-8210.
if ( LOG.isEnabled( Level.DEBUG ) && !xref.containsKey( statement ) ) {
LOG.unregisteredStatement(); LOG.unregisteredStatement();
} }
Set<ResultSet> resultSets = xref.get( statement ); Set<ResultSet> resultSets = xref.get( statement );

4
hibernate-core/src/main/java/org/hibernate/internal/CoreMessageLogger.java
View File

@ -1342,7 +1342,9 @@ public interface CoreMessageLogger extends BasicLogger {
@Message(value = "ResultSet had no statement associated with it, but was not yet registered", id = 386) @Message(value = "ResultSet had no statement associated with it, but was not yet registered", id = 386)
void unregisteredResultSetWithoutStatement(); void unregisteredResultSetWithoutStatement();
@LogMessage(level = WARN) // Keep this at DEBUG level, rather than warn. Numerous connection pool implementations can return a
// proxy/wrapper around the JDBC Statement, causing excessive logging here. See HHH-8210.
@LogMessage(level = DEBUG)
@Message(value = "ResultSet's statement was not registered", id = 387) @Message(value = "ResultSet's statement was not registered", id = 387)
void unregisteredStatement(); void unregisteredStatement();