Hibernate
/
hibernate-orm
mirror of https://github.com/hibernate/hibernate-orm
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix a subtle double-checked locking issue

This commit is contained in:
Nathan Xu 2020-02-29 22:24:08 -05:00 committed by Steve Ebersole
parent 620dcc62c0
commit df0aa1eb2e
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
hibernate-core/src/main/java/org/hibernate/persister/collection/AbstractCollectionPersister.java
View File

@ -744,7 +744,7 @@ public abstract class AbstractCollectionPersister
}
}
private CollectionLoader standardCollectionLoader;
private volatile CollectionLoader standardCollectionLoader;
@Override
public void initialize(Object key, SharedSessionContractImplementor session) throws HibernateException {
@ -752,10 +752,13 @@ public abstract class AbstractCollectionPersister
determineLoaderToUse( key, session ).load( key, session );
}
// lazily initialize instance field via 'double-checked locking'
// see https://en.wikipedia.org/wiki/Double-checked_locking
protected CollectionLoader getStandardCollectionLoader() {
CollectionLoader localCopy = standardCollectionLoader;
if ( localCopy == null ) {
synchronized (this) {
localCopy = standardCollectionLoader;
if ( localCopy == null ) {
localCopy = createCollectionLoader( LoadQueryInfluencers.NONE );
standardCollectionLoader = localCopy;